Skip to content

Commit 2846a54

Browse files
Format .rb files outside of lib/
1 parent 2f6a3dd commit 2846a54

File tree

10 files changed

+135
-71
lines changed

10 files changed

+135
-71
lines changed

Rakefile

Lines changed: 68 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,54 @@ BUILD_SOURCES = {
1313
type: "github",
1414
repo: "ruby/ruby",
1515
rev: "master",
16-
patches: [],
17-
},
16+
patches: []
17+
}
1818
}
1919

20-
FULL_EXTS = "bigdecimal,cgi/escape,continuation,coverage,date,dbm,digest/bubblebabble,digest,digest/md5,digest/rmd160,digest/sha1,digest/sha2,etc,fcntl,fiber,gdbm,json,json/generator,json/parser,nkf,objspace,pathname,psych,racc/cparse,rbconfig/sizeof,ripper,stringio,strscan,monitor,zlib"
20+
FULL_EXTS =
21+
"bigdecimal,cgi/escape,continuation,coverage,date,dbm,digest/bubblebabble,digest,digest/md5,digest/rmd160,digest/sha1,digest/sha2,etc,fcntl,fiber,gdbm,json,json/generator,json/parser,nkf,objspace,pathname,psych,racc/cparse,rbconfig/sizeof,ripper,stringio,strscan,monitor,zlib"
2122

2223
BUILD_PROFILES = {
23-
"minimal" => { debug: false, default_exts: "", user_exts: [] },
24-
"minimal-debug" => { debug: true, default_exts: "", user_exts: [] },
25-
"minimal-js" => { debug: false, default_exts: "", user_exts: ["js", "witapi"] },
26-
"minimal-js-debug" => { debug: true, default_exts: "", user_exts: ["js", "witapi"] },
27-
"full" => { debug: false, default_exts: FULL_EXTS, user_exts: [] },
28-
"full-debug" => { debug: true, default_exts: FULL_EXTS, user_exts: [] },
29-
"full-js" => { debug: false, default_exts: FULL_EXTS, user_exts: ["js", "witapi"] },
30-
"full-js-debug" => { debug: true, default_exts: FULL_EXTS, user_exts: ["js", "witapi"] },
24+
"minimal" => {
25+
debug: false,
26+
default_exts: "",
27+
user_exts: []
28+
},
29+
"minimal-debug" => {
30+
debug: true,
31+
default_exts: "",
32+
user_exts: []
33+
},
34+
"minimal-js" => {
35+
debug: false,
36+
default_exts: "",
37+
user_exts: %w[js witapi]
38+
},
39+
"minimal-js-debug" => {
40+
debug: true,
41+
default_exts: "",
42+
user_exts: %w[js witapi]
43+
},
44+
"full" => {
45+
debug: false,
46+
default_exts: FULL_EXTS,
47+
user_exts: []
48+
},
49+
"full-debug" => {
50+
debug: true,
51+
default_exts: FULL_EXTS,
52+
user_exts: []
53+
},
54+
"full-js" => {
55+
debug: false,
56+
default_exts: FULL_EXTS,
57+
user_exts: %w[js witapi]
58+
},
59+
"full-js-debug" => {
60+
debug: true,
61+
default_exts: FULL_EXTS,
62+
user_exts: %w[js witapi]
63+
}
3164
}
3265

3366
BUILDS = [
@@ -40,7 +73,7 @@ BUILDS = [
4073
{ src: "head", target: "wasm32-unknown-wasi", profile: "full-js" },
4174
{ src: "head", target: "wasm32-unknown-wasi", profile: "full-js-debug" },
4275
{ src: "head", target: "wasm32-unknown-emscripten", profile: "minimal" },
43-
{ src: "head", target: "wasm32-unknown-emscripten", profile: "full" },
76+
{ src: "head", target: "wasm32-unknown-emscripten", profile: "full" }
4477
]
4578

4679
LIB_ROOT = File.dirname(__FILE__)
@@ -51,9 +84,7 @@ namespace :build do
5184
BUILDS.each do |params|
5285
name = "#{params[:src]}-#{params[:target]}-#{params[:profile]}"
5386
source = BUILD_SOURCES[params[:src]].merge(name: params[:src])
54-
options = params
55-
.merge(BUILD_PROFILES[params[:profile]])
56-
.merge(src: source)
87+
options = params.merge(BUILD_PROFILES[params[:profile]]).merge(src: source)
5788
debug = options[:debug]
5889
options.delete :profile
5990
options.delete :user_exts
@@ -62,17 +93,25 @@ namespace :build do
6293
if debug
6394
t.crossruby.debugflags = %w[-g]
6495
t.crossruby.wasmoptflags = %w[-O3 -g]
65-
t.crossruby.ldflags = %w[-Xlinker --stack-first -Xlinker -z -Xlinker stack-size=16777216]
96+
t.crossruby.ldflags = %w[
97+
-Xlinker
98+
--stack-first
99+
-Xlinker
100+
-z
101+
-Xlinker
102+
stack-size=16777216
103+
]
66104
else
67105
t.crossruby.debugflags = %w[-g0]
68106
t.crossruby.ldflags = %w[-Xlinker -zstack-size=16777216]
69107
end
70108

71109
toolchain = t.toolchain
72-
t.crossruby.user_exts = BUILD_PROFILES[params[:profile]][:user_exts].map do |ext|
73-
srcdir = File.join(LIB_ROOT, "ext", ext)
74-
RubyWasm::CrossRubyExtProduct.new(srcdir, toolchain)
75-
end
110+
t.crossruby.user_exts =
111+
BUILD_PROFILES[params[:profile]][:user_exts].map do |ext|
112+
srcdir = File.join(LIB_ROOT, "ext", ext)
113+
RubyWasm::CrossRubyExtProduct.new(srcdir, toolchain)
114+
end
76115
unless TOOLCHAINS.key? toolchain.name
77116
TOOLCHAINS[toolchain.name] = toolchain
78117
end
@@ -91,15 +130,12 @@ namespace :build do
91130

92131
release =
93132
if args[:tag]
94-
url = "https://api.github.com/repos/ruby/ruby.wasm/releases/tags/#{args[:tag]}"
95-
OpenURI.open_uri(url) do |f|
96-
JSON.load(f.read)
97-
end
133+
url =
134+
"https://api.github.com/repos/ruby/ruby.wasm/releases/tags/#{args[:tag]}"
135+
OpenURI.open_uri(url) { |f| JSON.load(f.read) }
98136
else
99137
url = "https://api.github.com/repos/ruby/ruby.wasm/releases?per_page=1"
100-
OpenURI.open_uri(url) do |f|
101-
JSON.load(f.read)[0]
102-
end
138+
OpenURI.open_uri(url) { |f| JSON.load(f.read)[0] }
103139
end
104140

105141
puts "Downloading from release \"#{release["tag_name"]}\""
@@ -114,7 +150,11 @@ namespace :build do
114150
url = asset["browser_download_url"]
115151
tarball = File.join("rubies", asset["name"])
116152
rm_rf tarball, verbose: false
117-
downloader.download(url, tarball, "[%2d/%2d] Downloading #{File.basename(url)}" % [i + 1, assets.size])
153+
downloader.download(
154+
url,
155+
tarball,
156+
"[%2d/%2d] Downloading #{File.basename(url)}" % [i + 1, assets.size]
157+
)
118158
sh "tar xzf #{tarball} -C ./rubies"
119159
end
120160
end

ext/js/extconf.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
require "mkmf"
2-
$objs = ["js-core.o", "bindgen/rb-js-abi-host.o"]
2+
$objs = %w[js-core.o bindgen/rb-js-abi-host.o]
33
create_makefile("js")

ext/js/lib/js.rb

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
require "js.so"
22

33
class JS::Object
4-
def method_missing(sym, *args, &block)
5-
if self[sym].typeof == "function"
6-
self.call(sym, *args, &block)
7-
else
8-
super
9-
end
4+
def method_missing(sym, *args, &block)
5+
if self[sym].typeof == "function"
6+
self.call(sym, *args, &block)
7+
else
8+
super
109
end
10+
end
1111

12-
def respond_to_missing?(sym, include_private)
13-
return true if super
14-
self[sym].typeof == "function"
15-
end
16-
end
12+
def respond_to_missing?(sym, include_private)
13+
return true if super
14+
self[sym].typeof == "function"
15+
end
16+
end

ext/witapi/extconf.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
require "mkmf"
2-
$objs = ["witapi-core.o", "bindgen/rb-abi-guest.o"]
2+
$objs = %w[witapi-core.o bindgen/rb-abi-guest.o]
33
create_makefile("witapi")
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
require_relative "./unit/test_js"
2-
require_relative "./unit/test_object"
2+
require_relative "./unit/test_object"

packages/npm-packages/ruby-wasm-wasi/test/unit/test_js.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ class JS::TestJS < Test::Unit::TestCase
55
def test_is_a?
66
# A ruby object always returns false
77
assert_false JS.is_a?(1, Integer)
8-
assert_false JS.is_a?('x', String)
8+
assert_false JS.is_a?("x", String)
99
# A js object is not an instance of itself
1010
assert_false JS.is_a?(JS.global, JS.global)
1111
# globalThis is an instance of Object

packages/npm-packages/ruby-wasm-wasi/test/unit/test_object.rb

Lines changed: 29 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,13 @@ def assert_object_eql?(result, a, b)
2121
def test_eql?
2222
assert_object_eql? true, JS.eval("return 24;"), JS.eval("return 24;")
2323
assert_object_eql? true, JS.eval("return null;"), JS.eval("return null;")
24-
assert_object_eql? true, JS.eval("return undefined;"), JS.eval("return undefined;")
24+
assert_object_eql? true,
25+
JS.eval("return undefined;"),
26+
JS.eval("return undefined;")
2527
assert_object_eql? true, JS.eval("return 'x';"), JS.eval("return 'x';")
26-
assert_object_eql? true, JS.eval("return null;"), JS.eval("return undefined;")
28+
assert_object_eql? true,
29+
JS.eval("return null;"),
30+
JS.eval("return undefined;")
2731

2832
assert_object_eql? false, JS.eval("return 24;"), JS.eval("return 42;")
2933
assert_object_eql? false, JS.eval("return NaN;"), JS.eval("return NaN;")
@@ -35,11 +39,21 @@ def assert_object_strictly_eql?(result, a, b)
3539
end
3640

3741
def test_strictly_eql?
38-
assert_object_strictly_eql? true, JS.eval("return 24;"), JS.eval("return 24;")
39-
assert_object_strictly_eql? true, JS.eval("return null;"), JS.eval("return null;")
40-
assert_object_strictly_eql? true, JS.eval("return undefined;"), JS.eval("return undefined;")
41-
assert_object_strictly_eql? false, JS.eval("return new String('str');"), JS.eval("return 'str';")
42-
assert_object_strictly_eql? false, JS.eval("return null;"), JS.eval("return undefined;")
42+
assert_object_strictly_eql? true,
43+
JS.eval("return 24;"),
44+
JS.eval("return 24;")
45+
assert_object_strictly_eql? true,
46+
JS.eval("return null;"),
47+
JS.eval("return null;")
48+
assert_object_strictly_eql? true,
49+
JS.eval("return undefined;"),
50+
JS.eval("return undefined;")
51+
assert_object_strictly_eql? false,
52+
JS.eval("return new String('str');"),
53+
JS.eval("return 'str';")
54+
assert_object_strictly_eql? false,
55+
JS.eval("return null;"),
56+
JS.eval("return undefined;")
4357
end
4458

4559
def test_to_s
@@ -76,13 +90,14 @@ def test_method_missing_with_block
7690
JS
7791
block_called = false
7892
# TODO: Support return value in block
79-
result = obj.takeBlock do |a, b, c|
80-
block_called = true
81-
# TODO: Compare them as integers after introducing `JS::Object#to_i`
82-
assert_equal 1.to_s, a.to_s
83-
assert_equal 2.to_s, b.to_s
84-
assert_equal 3.to_s, c.to_s
85-
end
93+
result =
94+
obj.takeBlock do |a, b, c|
95+
block_called = true
96+
# TODO: Compare them as integers after introducing `JS::Object#to_i`
97+
assert_equal 1.to_s, a.to_s
98+
assert_equal 2.to_s, b.to_s
99+
assert_equal 3.to_s, c.to_s
100+
end
86101
assert_true block_called
87102
end
88103

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
class IO
2-
def winsize
3-
[24, 80]
4-
end
2+
def winsize
3+
[24, 80]
4+
end
55

6-
def wait_readable(timeout = nil)
7-
false
8-
end
6+
def wait_readable(timeout = nil)
7+
false
8+
end
99
end
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
module Reline
2-
def self.get_screen_size
3-
raise Errno::EINVAL
4-
end
5-
class Unicode
6-
def self.calculate_width(str, allow_escape_code = false)
7-
1
8-
end
2+
def self.get_screen_size
3+
raise Errno::EINVAL
4+
end
5+
class Unicode
6+
def self.calculate_width(str, allow_escape_code = false)
7+
1
98
end
9+
end
1010
end

tasks/format.rake

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,16 @@
11
namespace :format do
22
begin
33
require "syntax_tree/rake_tasks"
4-
SyntaxTree::Rake::WriteTask.new(:ruby)
4+
SyntaxTree::Rake::WriteTask.new(
5+
:ruby,
6+
Rake::FileList[
7+
"Rakefile",
8+
"lib/**/*.rb",
9+
"ext/**/*.rb",
10+
"tasks/**/*.rb",
11+
"packages/**/*.rb",
12+
],
13+
)
514
rescue LoadError
615
end
716

0 commit comments

Comments
 (0)