Skip to content

Commit 4c1d85f

Browse files
Use rb_define_private_method to hide private methods in docs
1 parent 4ee47b2 commit 4c1d85f

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

ext/js/js-core.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -469,6 +469,7 @@ void Init_js() {
469469

470470
i_to_js = rb_intern("to_js");
471471
rb_cJS_Object = rb_define_class_under(rb_mJS, "Object", rb_cObject);
472+
VALUE rb_cJS_singleton = rb_singleton_class(rb_cJS_Object);
472473
rb_define_alloc_func(rb_cJS_Object, jsvalue_s_allocate);
473474
rb_define_method(rb_cJS_Object, "[]", _rb_js_obj_aref, 1);
474475
rb_define_method(rb_cJS_Object, "[]=", _rb_js_obj_aset, 2);
@@ -478,9 +479,10 @@ void Init_js() {
478479
rb_define_method(rb_cJS_Object, "hash", _rb_js_obj_hash, 0);
479480
rb_define_method(rb_cJS_Object, "call", _rb_js_obj_call, -1);
480481
rb_define_method(rb_cJS_Object, "typeof", _rb_js_obj_typeof, 0);
481-
rb_define_method(rb_cJS_Object, "__export_to_js", _rb_js_export_to_js, 0);
482-
rb_define_singleton_method(rb_cJS_Object, "__import_from_js",
483-
_rb_js_import_from_js, 0);
482+
rb_define_private_method(rb_cJS_Object, "__export_to_js", _rb_js_export_to_js,
483+
0);
484+
rb_define_private_method(rb_cJS_singleton, "__import_from_js",
485+
_rb_js_import_from_js, 0);
484486
rb_define_method(rb_cJS_Object, "to_s", _rb_js_obj_to_s, 0);
485487
rb_define_alias(rb_cJS_Object, "inspect", "to_s");
486488
rb_define_method(rb_cJS_Object, "to_i", _rb_js_obj_to_i, 0);

packages/npm-packages/ruby-wasm-wasi/src/index.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -275,10 +275,7 @@ class JsValueTransport {
275275

276276
importJsValue(value: JsAbiValue, vm: RubyVM): RbValue {
277277
this._takenJsValue = value;
278-
return vm.eval(`
279-
require "js"
280-
JS::Object.__import_from_js
281-
`);
278+
return vm.eval('require "js"; JS::Object').call("__import_from_js");
282279
}
283280
}
284281

0 commit comments

Comments
 (0)