Parse signed hex values (#2258)

* made hex value parsing accept signed values

* fixed unit test

Co-authored-by: Thomas Tuegel <[email protected]>

Author: MirceaS

kore/src/Kore/Builtin/String.hs

@@ -305,7 +305,7 @@ evalString2Base = Builtin.functionEvaluator evalString2Base0
                             [(result, "")] -> Right (result, "")
                             _              -> Left ""
                     10 -> Text.signed Text.decimal
-                    16 -> Text.hexadecimal
+                    16 -> Text.signed Text.hexadecimal
                     _  -> const empty
         case readN _str of
             Right (result, Text.unpack -> "") ->

kore/test/Test/Kore/Builtin/String.hs

@@ -297,10 +297,10 @@ test_string2Base =
         [asInternal "42", Test.Int.asInternal 16]
         (Test.Int.asPattern 66)
     , Test.Int.testInt
-        "string2Base hex negative is bottom"
+        "string2Base hex negative"
         string2BaseStringSymbol
         [asInternal "-42", Test.Int.asInternal 16]
-        bottom
+        (Test.Int.asPattern (-66))
     , Test.Int.testInt
         "string2Base hex is bottom"
         string2BaseStringSymbol
@@ -317,7 +317,7 @@ test_string2Base =
         [asInternal "foobar", Test.Int.asInternal 16]
         bottom
     , Test.Int.testInt
-        "string2Base hex from hex is bottom"
+        "string2Base hex from hex"
         string2BaseStringSymbol
         [asInternal "baad", Test.Int.asInternal 16]
         (Test.Int.asPattern 47789)