Migrate Jenkins to Github actions (#595)

* Initial version parameter

* Run all configs

* Update default.nix

* Flake tests in CI

* Run a subset of tests

* Reduce?

* Increase

* GC?

* Opt in to self-hosting

* No nix?

* Reduce size

* Cut tests in Jenkins

* Make flake default for tests

* Tidy up

* Test logs

* Even smaller

Co-authored-by: Everett Hildenbrandt <[email protected]>

Author: Baltoli

.github/workflows/test-flake.yml

@@ -43,3 +43,6 @@ jobs:
 
       - name: 'Build LLVM backend'
         run: GC_DONT_GC=1 nix build .
+
+      - name: 'Test LLVM backend'
+        run: GC_DONT_GC=1 nix flake check --print-build-logs

.github/workflows/test.yml

@@ -4,64 +4,6 @@ pipeline {
     ansiColor('xterm')
   }
   stages {
-    stage("Init title") {
-      when { changeRequest() }
-      steps { script { currentBuild.displayName = "PR ${env.CHANGE_ID}: ${env.CHANGE_TITLE}" } }
-    }
-    stage('Build and test Arch Linux') {
-      agent {
-        dockerfile {
-          filename 'Dockerfile.arch'
-          additionalBuildArgs '--build-arg USER_ID=$(id -u) --build-arg GROUP_ID=$(id -g) --pull'
-        }
-      }
-      options { timeout(time: 30, unit: 'MINUTES') }
-      steps {
-        sh '''
-          ./ciscript Debug
-          ./ciscript Release
-          ./ciscript RelWithDebInfo
-          ./ciscript FastBuild
-          ./ciscript GcStats
-        '''
-      }
-    }
-    stage('Build and test Ubuntu Focal') {
-      agent {
-        dockerfile {
-          additionalBuildArgs '--build-arg USER_ID=$(id -u) --build-arg GROUP_ID=$(id -g) --build-arg BASE_IMAGE=ubuntu:focal --build-arg LLVM_VERSION=10'
-          reuseNode true
-        }
-      }
-      options { timeout(time: 30, unit: 'MINUTES') }
-      steps {
-        sh '''
-          ./ciscript Debug
-          ./ciscript Release
-          ./ciscript RelWithDebInfo
-          ./ciscript FastBuild
-          ./ciscript GcStats
-        '''
-      }
-    }
-    stage('Build and test Ubuntu Jammy') {
-      agent {
-        dockerfile {
-          additionalBuildArgs '--build-arg USER_ID=$(id -u) --build-arg GROUP_ID=$(id -g) --build-arg BASE_IMAGE=ubuntu:jammy --build-arg LLVM_VERSION=14'
-          reuseNode true
-        }
-      }
-      options { timeout(time: 30, unit: 'MINUTES') }
-      steps {
-        sh '''
-          ./ciscript Debug
-          ./ciscript Release
-          ./ciscript RelWithDebInfo
-          ./ciscript FastBuild
-          ./ciscript GcStats
-        '''
-      }
-    }
     stage('Update K Submodule') {
       when { branch 'master' }
       agent {

Jenkinsfile

@@ -22,7 +22,7 @@ in { pkgs ? pinned
 
   # Build an optimized release package.
   # Currently requires dependents to use LTO. Use sparingly.
-, release ? false }:
+, cmakeBuildType ? "FastBuild" }:
 
 let
   localOverlay = import ./nix/overlay.nix;
@@ -36,7 +36,8 @@ let
           # Avoid spurious rebuilds by ignoring files that don't affect the build.
           mavenix = import sources."mavenix" { inherit (prev) pkgs; };
         in {
-          llvm-backend-release = release;
+          llvm-version = 13;
+          llvm-backend-build-type = cmakeBuildType;
           inherit (mavenix) buildMaven;
           mavenix-cli = mavenix.cli;
 

ciscript

@@ -3,9 +3,7 @@
 
   inputs = {
     utils.url = "github:numtide/flake-utils";
-    # locked due to https://github.com/NixOS/nixpkgs/pull/172397/files
-    nixpkgs.url =
-      "github:nixos/nixpkgs/a923e194a3f21ed8a31367c96530a06756ed993e";
+    nixpkgs.url = "github:nixos/nixpkgs";
     immer-src.url =
       "github:runtimeverification/immer/198c2ae260d49ef1800a2fe4433e07d7dec20059";
     immer-src.flake = false;
@@ -20,6 +18,8 @@
 
   outputs = { self, nixpkgs, utils, immer-src, rapidjson-src, pybind11-src, mavenix }:
     let
+      inherit (nixpkgs) lib;
+
       # put devShell and any other required packages into local overlay
       # if you have additional overlays, you may add them here
       localOverlay = import ./nix/overlay.nix; # this should expose devShell
@@ -64,10 +64,13 @@
       llvm-backend-overlay =
         nixpkgs.lib.composeManyExtensions [ depsOverlay localOverlay ];
 
-      pkgsForSystem = system: llvm-backend-release:
+      pkgsForSystem = system: llvm-version: llvm-backend-build-type:
         import nixpkgs {
           overlays = [
-            (_: _: { inherit llvm-backend-release; })
+            (_: _: {
+              inherit llvm-version;
+              inherit llvm-backend-build-type;
+            })
             mavenix.overlay
             llvm-backend-overlay
           ];
@@ -80,16 +83,50 @@
       "aarch64-darwin"
     ] (system:
       let
-        packagesRelease = pkgsForSystem system true;
-        packages = pkgsForSystem system false;
-      in {
+        listToChecks = checks:
+          builtins.listToAttrs (lib.imap0 (i: v: { name = "check_${toString i}"; value = v; }) checks);
+
+        matrix = builtins.listToAttrs (lib.forEach (lib.cartesianProductOfSets {
+          llvm-version = [12 13 14];
+          build-type = ["Debug" "Release" "RelWithDebInfo" "FastBuild" "GcStats"];
+        }) (
+          args:
+            let pkgs = pkgsForSystem system args.llvm-version args.build-type; in
+            {
+              name = "llvm-backend-${toString args.llvm-version}-${args.build-type}";
+              value = {
+                inherit (pkgs) llvm-backend llvm-backend-matching integration-tests devShell;
+              };
+            }
+        ));
+      in with matrix; {
         packages = utils.lib.flattenTree {
-          inherit (packages) llvm-backend llvm-backend-matching;
-          llvm-backend-release = packagesRelease.llvm-backend;
-          default = packages.llvm-backend;
+          inherit (llvm-backend-14-FastBuild) llvm-backend llvm-backend-matching;
+          default = llvm-backend-14-FastBuild.llvm-backend;
+          llvm-backend-release = llvm-backend-14-Release.llvm-backend;
         };
-        checks = { inherit (packages) integration-tests; };
-        devShells.default = packages.devShell;
+        checks = listToChecks [
+          # Check that the backend compiles on each supported version of LLVM,
+          # but don't run the test suite on all 15 configurations.
+
+          # Disable the full set temporarily while the checks run on a hosted
+          # runner.
+          # llvm-backend-12-Debug.llvm-backend
+          llvm-backend-12-FastBuild.llvm-backend
+
+          # llvm-backend-13-Debug.llvm-backend
+          llvm-backend-13-FastBuild.llvm-backend
+
+          # llvm-backend-14-Debug.integration-tests
+          # llvm-backend-14-Release.integration-tests
+
+          # llvm-backend-14-RelWithDebInfo.integration-tests
+          # llvm-backend-14-FastBuild.integration-tests
+          # llvm-backend-14-GcStats.integration-tests
+
+          llvm-backend-14-FastBuild.integration-tests
+        ];
+        devShells.default = llvm-backend-14-FastBuild.devShell;
       }) // {
         # non-system suffixed items should go here
         overlays.default = llvm-backend-overlay;

default.nix

@@ -3,12 +3,12 @@
 # Runtime dependencies:
 host,
 # Options:
-release ? false # optimized release build, currently: LTO
+cmakeBuildType ? "FastBuild" # optimized release build, currently: LTO
 }:
 stdenv.mkDerivation {
   pname = "llvm-backend";
   version = "0";
-  inherit src;
+  inherit src cmakeBuildType;
 
   nativeBuildInputs = [ cmake flex llvm pkgconfig python3 ];
   buildInputs = [ boost libyaml ];
@@ -41,11 +41,9 @@ stdenv.mkDerivation {
     "-DUSE_NIX=TRUE"
     "-DCMAKE_SKIP_BUILD_RPATH=FALSE"
     "-DBUILD_TESTS=True"
-    "-DK_LLVM_BACKEND_LTO=${if isArmMac then "OFF" else "ON"}"
+    "-DK_LLVM_BACKEND_LTO=OFF"
   ];
 
-  cmakeBuildType = if release then "Release" else "FastBuild";
-
   NIX_CFLAGS_COMPILE = [ "-Wno-error" ];
 
   doCheck = true;

flake.lock

@@ -1,6 +1,6 @@
 final: prev:
 let
-  llvmPackages = prev.llvmPackages_13.override {
+  llvmPackages = prev."llvmPackages_${toString prev.llvm-version}".override {
     bootBintoolsNoLibc = null;
     bootBintools = null;
   };
@@ -32,7 +32,7 @@ let
       llvmPackages.stdenv
     else
       prev.overrideCC llvmPackages.stdenv clang;
-    release = prev.llvm-backend-release;
+    cmakeBuildType = prev.llvm-backend-build-type;
     src = prev.llvm-backend-src;
     inherit jemalloc;
     host.clang = clang;