Changelog #118

Author: lnicola

generated_assists.adoc

@@ -276,7 +276,7 @@ pub(crate) fn frobnicate() {}
 
 [discrete]
 === `convert_bool_then_to_if`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/convert_bool_then.rs#L134[convert_bool_then.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/convert_bool_then.rs#L133[convert_bool_then.rs]
 
 Converts a `bool::then` method call to an equivalent if expression.
 
@@ -428,7 +428,7 @@ fn main() {
 
 [discrete]
 === `convert_to_guarded_return`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/convert_to_guarded_return.rs#L20[convert_to_guarded_return.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/convert_to_guarded_return.rs#L21[convert_to_guarded_return.rs]
 
 Replace a large conditional with a guarded return.
 
@@ -501,7 +501,7 @@ impl Point {
 
 [discrete]
 === `convert_while_to_loop`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/convert_while_to_loop.rs#L18[convert_while_to_loop.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/convert_while_to_loop.rs#L19[convert_while_to_loop.rs]
 
 Replace a while with a loop.
 
@@ -648,7 +648,7 @@ fn bar(name: i32) -> i32 {
 
 [discrete]
 === `extract_struct_from_enum_variant`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/extract_struct_from_enum_variant.rs#L29[extract_struct_from_enum_variant.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/extract_struct_from_enum_variant.rs#L28[extract_struct_from_enum_variant.rs]
 
 Extracts a struct from enum variant.
 
@@ -1479,7 +1479,7 @@ impl<'a> Cursor<'a> {
 
 [discrete]
 === `invert_if`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/invert_if.rs#L12[invert_if.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/invert_if.rs#L13[invert_if.rs]
 
 This transforms if expressions of the form `if !x {A} else {B}` into `if x {B} else {A}`
 This also works with `!=`. This assist can only be applied with the cursor on `if`.
@@ -1612,7 +1612,7 @@ fn handle(action: Action) {
 
 [discrete]
 === `move_arm_cond_to_match_guard`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/move_guard.rs#L79[move_guard.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/move_guard.rs#L69[move_guard.rs]
 
 Moves if expression from match arm body into a guard.
 
@@ -1684,7 +1684,7 @@ fn t() {}
 
 [discrete]
 === `move_guard_to_arm_body`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/move_guard.rs#L11[move_guard.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/move_guard.rs#L8[move_guard.rs]
 
 Moves match guard into match arm body.
 
@@ -2086,7 +2086,7 @@ impl Debug for S {
 
 [discrete]
 === `replace_if_let_with_match`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/replace_if_let_with_match.rs#L19[replace_if_let_with_match.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/replace_if_let_with_match.rs#L24[replace_if_let_with_match.rs]
 
 Replaces a `if let` expression with a `match` expression.
 
@@ -2146,7 +2146,7 @@ fn compute() -> Option<i32> { None }
 
 [discrete]
 === `replace_match_with_if_let`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/replace_if_let_with_match.rs#L160[replace_if_let_with_match.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/replace_if_let_with_match.rs#L174[replace_if_let_with_match.rs]
 
 Replaces a binary `match` with a wildcard pattern and no guards with an `if let` expression.
 

generated_config.adoc

@@ -213,6 +213,11 @@ Note that your client must specify the `additionalTextEdits` LSP client capabili
 Toggles the additional completions that automatically show method calls and field accesses
 with `self` prefixed to them when inside a method.
 --
+[[rust-analyzer.completion.privateEditable.enable]]rust-analyzer.completion.privateEditable.enable (default: `false`)::
++
+--
+Enables completions of private items and fields that are defined in the current workspace even if they are not visible at the current position.
+--
 [[rust-analyzer.diagnostics.enable]]rust-analyzer.diagnostics.enable (default: `true`)::
 +
 --

generated_features.adoc

@@ -174,7 +174,7 @@ Displays the ItemTree of the currently open file, for debugging.
 
 
 === Expand Macro Recursively
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/expand_macro.rs#L16[expand_macro.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/expand_macro.rs#L15[expand_macro.rs]
 
 Shows the full macro expansion of the macro at current cursor.
 
@@ -312,7 +312,7 @@ image::https://user-images.githubusercontent.com/48062697/113020657-b560f500-917
 
 
 === Highlight Related
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/highlight_related.rs#L36[highlight_related.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/highlight_related.rs#L38[highlight_related.rs]
 
 Highlights constructs related to the thing under the cursor:
 - if on an identifier, highlights all references to that identifier in the current file

manual.adoc

@@ -40,6 +40,20 @@ To add the sources manually, run the following command:
 $ rustup component add rust-src
 ```
 
+=== Toolchain
+
+Only the latest stable standard library source is officially supported for use with rust-analyzer.
+If you are using an older toolchain or have an override set, rust-analyzer may fail to understand the Rust source.
+You will either need to update your toolchain or use an older version of rust-analyzer that is compatible with your toolchain.
+
+If you are using an override in your project, you can still force rust-analyzer to use the stable toolchain via the environment variable `RUSTUP_TOOLCHAIN`.
+For example, with VS Code or coc-rust-analyzer:
+
+[source,json]
+----
+{ "rust-analyzer.server.extraEnv": { "RUSTUP_TOOLCHAIN": "stable" } }
+----
+
 === VS Code
 
 This is the best supported editor at the moment.
@@ -86,8 +100,7 @@ It will ask your permission to download the matching language server version bin
 ===== Nightly
 
 We ship nightly releases for VS Code.
-You can opt in to these by switching to the pre-release version in the Code extension page or settings.
-To help us out with testing the newest code and follow the bleeding edge of our `master`, please use the following config:
+To help us out by testing the newest code, you can enable pre-release versions in the Code extension page.
 
 ==== Manual installation
 
@@ -240,7 +253,6 @@ The are several LSP client implementations for vim or neovim:
    * same configurations as VSCode extension, `rust-analyzer.server.path`, `rust-analyzer.cargo.features` etc.
    * same commands too, `rust-analyzer.analyzerStatus`, `rust-analyzer.ssr` etc.
    * inlay hints for variables and method chaining, _Neovim Only_
-   * semantic highlighting is not implemented yet
 
 Note: for code actions, use `coc-codeaction-cursor` and `coc-codeaction-selected`; `coc-codeaction` and `coc-codeaction-line` are unlikely to be useful.
 
@@ -362,22 +374,19 @@ if executable('rust-analyzer')
 endif
 ----
 
-=== Sublime Text 3
-
-Prerequisites: You have installed the <<rust-analyzer-language-server-binary,`rust-analyzer` binary>>.
+=== Sublime Text
 
-You also need the `LSP` package.
-To install it:
+==== Sublime Text 4:
+* Follow the instructions in link:https://github.com/sublimelsp/LSP-rust-analyzer[LSP-rust-analyzer].
 
-1. If you've never installed a Sublime Text package, install Package Control:
-   * Open the command palette (Win/Linux: `ctrl+shift+p`, Mac: `cmd+shift+p`)
-   * Type `Install Package Control`, press enter
-2. In the command palette, run `Package control: Install package`, and in the list that pops up, type `LSP` and press enter.
+NOTE: Install link:https://packagecontrol.io/packages/LSP-file-watcher-chokidar[LSP-file-watcher-chokidar] to enable file watching (`workspace/didChangeWatchedFiles`).
 
-Finally, with your Rust project open, in the command palette, run `LSP: Enable Language Server In Project` or `LSP: Enable Language Server Globally`, then select `rust-analyzer` in the list that pops up to enable the rust-analyzer LSP.
-The latter means that rust-analyzer is enabled by default in Rust projects.
+==== Sublime Text 3:
+* Install the <<rust-analyzer-language-server-binary,`rust-analyzer` binary>>.
+* Install the link:https://packagecontrol.io/packages/LSP[LSP package].
+* From the command palette, run `LSP: Enable Language Server Globally` and select `rust-analyzer`.
 
-If it worked, you should see "rust-analyzer, Line X, Column Y" on the left side of the bottom bar, and after waiting a bit, functionality like tooltips on hovering over variables should become available.
+If it worked, you should see "rust-analyzer, Line X, Column Y" on the left side of the status bar, and after waiting a bit, functionalities like tooltips on hovering over variables should become available.
 
 If you get an error saying `No such file or directory: 'rust-analyzer'`, see the <<rust-analyzer-language-server-binary,`rust-analyzer` binary>> section on installing the language server binary.
 
@@ -427,6 +436,40 @@ Then click on apply, and restart the LSP server for your rust project.
 
 https://gitlab.com/cppit/jucipp[juCi++] has built-in support for the language server protocol, and since version 1.7.0 offers installation of both Rust and rust-analyzer when opening a Rust file.
 
+=== Kakoune
+
+https://kakoune.org/[Kakoune] supports LSP with the help of https://github.com/kak-lsp/kak-lsp[`kak-lsp`].
+Follow the https://github.com/kak-lsp/kak-lsp#installation[instructions] to install `kak-lsp`.
+To configure `kak-lsp`, refer to the https://github.com/kak-lsp/kak-lsp#configuring-kak-lsp[configuration section] which is basically about copying the https://github.com/kak-lsp/kak-lsp/blob/master/kak-lsp.toml[configuration file] in the right place (latest versions should use `rust-analyzer` by default).
+
+Finally, you need to configure Kakoune to talk to `kak-lsp` (see https://github.com/kak-lsp/kak-lsp#usage[Usage section]).
+A basic configuration will only get you LSP but you can also activate inlay diagnostics and auto-formatting on save.
+The following might help you get all of this.
+
+[source,txt]
+----
+eval %sh{kak-lsp --kakoune -s $kak_session}  # Not needed if you load it with plug.kak.
+hook global WinSetOption filetype=rust %{
+    # Enable LSP
+    lsp-enable-window
+
+    # Auto-formatting on save
+    hook window BufWritePre .* lsp-formatting-sync
+
+    # Configure inlay hints (only on save)
+    hook window -group rust-inlay-hints BufWritePost .* rust-analyzer-inlay-hints
+    hook -once -always window WinSetOption filetype=.* %{
+        remove-hooks window rust-inlay-hints
+    }
+}
+----
+
+=== Helix
+
+https://docs.helix-editor.com/[Helix] supports LSP by default.
+However, it won't install `rust-analyzer` automatically.
+You can follow instructions for installing <<rust-analyzer-language-server-binary,`rust-analyzer` binary>>.
+
 == Troubleshooting
 
 Start with looking at the rust-analyzer version.

thisweek/_posts/2022-02-28-changelog-118.adoc

@@ -0,0 +1,62 @@
+= Changelog #118
+:sectanchors:
+:page-layout: post
+
+Commit: commit:4e72700e38421a12993fe5fa5c33d712652bc6c8[] +
+Release: release:2022-02-28[]
+
+== Sponsors
+
+**Become a sponsor:** On https://opencollective.com/rust-analyzer/[OpenCollective] or
+https://github.com/sponsors/rust-analyzer[GitHub Sponsors].
+
+== New Features
+
+* pr:11549[] (first contribution) add support for `concat_bytes!`.
+* pr:11481[] display parameter names when hovering over a function pointer alias:
++
+image::https://user-images.githubusercontent.com/308347/155932516-2459a4e5-dae8-40bc-a094-adc64d48025e.png[]
+* pr:11513[] expand `derive` attribute into a pseudo expansion:
++
+image::https://user-images.githubusercontent.com/3757771/155107902-abca028d-f985-408a-b2ec-97aa34e8ae83.png[]
++
+image::https://user-images.githubusercontent.com/3757771/155108170-b0e81d69-3533-4ad3-8f81-c34ce87dc46b.gif[]
+* pr:11462[] highlight continue points:
++
+image::https://user-images.githubusercontent.com/308347/155933288-3e1a1e43-6dcc-4ced-9385-f469d9a39a99.png[]
+* pr:11375[] add support for `if`- and `while`- `let` chains.
+* pr:11538[] disable private-editable completions by default (controlled by `rust-analyzer.completion.privateEditable.enable`).
+
+== Fixes
+
+* pr:11461[] (first-contribution) filter generics in `Extract struct from enum variant`.
+* pr:11531[] (first contribution) make `fill_match_arms` assist handle `+#[doc(hidden)]+` and `#[non_exhaustive]`.
+* pr:11535[] (first contribution) add install instructions for Kakoune and Helix.
+* pr:11524[] (first contribution) state that only the latest stable toolchain is officially supported.
+* pr:11424[] pass required features to `cargo` when using the `Run` action.
+* pr:11540[] resolve private fields in type inference.
+* pr:11490[] fix doc test formatting with generics.
+* pr:11525[] drop generic args in path in `replace_qualified_name_with_use`.
+* pr:11562[] don't emit `unresolvedReference` highlight tags in unlinked files.
+* pr:11516[] don't count commas when looking for the derive attribute in diagnostics.
+* pr:11517[] fix qualified record literal completion triggering too eagerly.
+* pr:11522[] make code lenses work on attributed items.
+* pr:11530[] fix `expand_macro` always expanding the first listed derive.
+* pr:11472[] fix visibility in `impl` items and change `pub(crate)` to `pub` in `extract_module`.
+* pr:11552[] properly display `$crate` in hovers.
+* pr:11554[] fix type mismatches with `unreachable!` in Rust 1.59.
+* pr:11565[] fix body selection in `while` loops with block conditions.
+* pr:11567[] fix `if` with block conditions.
+* pr:11514[] update manual for `coc-rust-analyzer`.
+
+== Internal Improvements
+
+* pr:11573[] reuse buffer in `TextEdit::apply` and add tests.
+* pr:11550[] refactor autoderef/method resolution.
+* pr:11455[] handle proc-macro functions as the proc-macro they resolve to.
+* pr:11527[] split unresolved proc-macro error out of `mbe`.
+* pr:11536[] resolve functions as proc-macros via `FileAstId`.
+* pr:11537[] reduce visibility of proc-macros to `pub(crate)` in nameres.
+* pr:11548[] add CSV output to `analysis-stats`.
+* pr:11564[] clean up highlighting tests.
+* pr:11560[] update `url` to make `webrender` build when computing metrics.