Changelog #81

lnicola · lnicola · commit 496c0ea2bce7 · 2021-06-14T09:44:20.000+03:00
diff --git a/generated_assists.adoc b/generated_assists.adoc
@@ -210,7 +210,7 @@ fn main() {
 
 [discrete]
 === `change_visibility`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/change_visibility.rs#L10[change_visibility.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/change_visibility.rs#L12[change_visibility.rs]
 
 Adds or changes existing visibility specifier.
 
@@ -330,9 +330,9 @@ fn main() {
 
 [discrete]
 === `convert_tuple_struct_to_named_struct`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/convert_tuple_struct_to_named_struct.rs#L9[convert_tuple_struct_to_named_struct.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/convert_tuple_struct_to_named_struct.rs#L10[convert_tuple_struct_to_named_struct.rs]
 
-Converts tuple struct to struct with named fields.
+Converts tuple struct to struct with named fields, and analogously for tuple enum variants.
 
 .Before
 ```rust
diff --git a/generated_diagnostic.adoc b/generated_diagnostic.adoc
@@ -1,54 +1,70 @@
 //Generated file, do not edit by hand, see `xtask/src/codegen`
 === break-outside-of-loop
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/diagnostics.rs#L250[diagnostics.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/break_outside_of_loop.rs#L3[break_outside_of_loop.rs]
 
 This diagnostic is triggered if the `break` keyword is used outside of a loop.
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
 == inactive-code
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir/src/diagnostics.rs#L129[diagnostics.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/inactive_code.rs#L9[inactive_code.rs]
 
 This diagnostic is shown for code with inactive `#[cfg]` attributes.
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
 == incorrect-ident-case
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/diagnostics.rs#L381[diagnostics.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/incorrect_case.rs#L12[incorrect_case.rs]
 
 This diagnostic is triggered if an item name doesn't follow https://doc.rust-lang.org/1.0.0/style/style/naming/README.html[Rust naming convention].
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
 == macro-error
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir/src/diagnostics.rs#L202[diagnostics.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/macro_error.rs#L3[macro_error.rs]
 
 This diagnostic is shown for macro expansion errors.
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
 == mismatched-arg-count
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/diagnostics.rs#L298[diagnostics.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/mismatched_arg_count.rs#L3[mismatched_arg_count.rs]
 
 This diagnostic is triggered if a function is invoked with an incorrect amount of arguments.
 
 
+// IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
+
+== missing-fields
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/missing_fields.rs#L11[missing_fields.rs]
+
+This diagnostic is triggered if record lacks some fields that exist in the corresponding structure.
+
+Example:
+
+```rust
+struct A { a: u8, b: u8 }
+
+let a = A { a: 10 };
+```
+
+
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
 == missing-match-arm
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/diagnostics.rs#L166[diagnostics.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/missing_match_arms.rs#L5[missing_match_arms.rs]
 
 This diagnostic is triggered if `match` block is missing one or more match arms.
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
 == missing-ok-or-some-in-tail-expr
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/diagnostics.rs#L191[diagnostics.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/missing_ok_or_some_in_tail_expr.rs#L9[missing_ok_or_some_in_tail_expr.rs]
 
 This diagnostic is triggered if a block that should return `Result` returns a value not wrapped in `Ok`,
 or if a block that should return `Option` returns a value not wrapped in `Some`.
@@ -64,62 +80,42 @@ fn foo() -> Result<u8, ()> {
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
-== missing-pat-fields
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/diagnostics.rs#L117[diagnostics.rs]
-
-This diagnostic is triggered if pattern lacks some fields that exist in the corresponding structure.
-
-Example:
-
-```rust
-struct A { a: u8, b: u8 }
-
-let a = A { a: 10, b: 20 };
+== missing-unsafe
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/missing_unsafe.rs#L3[missing_unsafe.rs]
 
-if let A { a } = a {
-    // ...
-}
-```
+This diagnostic is triggered if an operation marked as `unsafe` is used outside of an `unsafe` function or block.
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
-== missing-structure-fields
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/diagnostics.rs#L70[diagnostics.rs]
-
-This diagnostic is triggered if record lacks some fields that exist in the corresponding structure.
-
-Example:
-
-```rust
-struct A { a: u8, b: u8 }
+== no-such-field
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/no_such_field.rs#L14[no_such_field.rs]
 
-let a = A { a: 10 };
-```
+This diagnostic is triggered if created structure does not have field provided in record.
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
-== missing-unsafe
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/diagnostics.rs#L274[diagnostics.rs]
+== remove-this-semicolon
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/remove_this_semicolon.rs#L11[remove_this_semicolon.rs]
 
-This diagnostic is triggered if an operation marked as `unsafe` is used outside of an `unsafe` function or block.
+This diagnostic is triggered when there's an erroneous `;` at the end of the block.
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
-== no-such-field
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/diagnostics.rs#L43[diagnostics.rs]
+== replace-filter-map-next-with-find-map
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/replace_filter_map_next_with_find_map.rs#L14[replace_filter_map_next_with_find_map.rs]
 
-This diagnostic is triggered if created structure does not have field provided in record.
+This diagnostic is triggered when `.filter_map(..).next()` is used, rather than the more concise `.find_map(..)`.
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
-== replace-filter-map-next-with-find-map
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/diagnostics.rs#L422[diagnostics.rs]
+== unimplemented-builtin-macro
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/unimplemented_builtin_macro.rs#L6[unimplemented_builtin_macro.rs]
 
-This diagnostic is triggered when `.filter_map(..).next()` is used, rather than the more concise `.find_map(..)`.
+This diagnostic is shown for builtin macros which are not yet implemented by rust-analyzer
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
@@ -134,32 +130,41 @@ crates rust-analyzer failed to discover. The file will not have IDE features ava
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
 == unresolved-extern-crate
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir/src/diagnostics.rs#L48[diagnostics.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/unresolved_extern_crate.rs#L3[unresolved_extern_crate.rs]
 
 This diagnostic is triggered if rust-analyzer is unable to discover referred extern crate.
 
 
+// IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
+
+== unresolved-import
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/unresolved_import.rs#L3[unresolved_import.rs]
+
+This diagnostic is triggered if rust-analyzer is unable to resolve a path in
+a `use` declaration.
+
+
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
 == unresolved-macro-call
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir/src/diagnostics.rs#L100[diagnostics.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/unresolved_macro_call.rs#L6[unresolved_macro_call.rs]
 
-This diagnostic is triggered if rust-analyzer is unable to resolve the path to a
-macro in a macro invocation.
+This diagnostic is triggered if rust-analyzer is unable to resolve the path
+to a macro in a macro invocation.
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
 == unresolved-module
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir/src/diagnostics.rs#L23[diagnostics.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/unresolved_module.rs#L8[unresolved_module.rs]
 
 This diagnostic is triggered if rust-analyzer is unable to discover referred module.
 
 
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
 == unresolved-proc-macro
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir/src/diagnostics.rs#L162[diagnostics.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/diagnostics/unresolved_proc_macro.rs#L6[unresolved_proc_macro.rs]
 
 This diagnostic is shown when a procedural macro can not be found. This usually means that
 procedural macro support is simply disabled (and hence is only a weak hint instead of an error),
diff --git a/generated_features.adoc b/generated_features.adoc
@@ -85,7 +85,7 @@ Displays the ItemTree of the currently open file, for debugging.
 // IMPORTANT: master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
 
 == Expand Macro Recursively
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/expand_macro.rs#L17[expand_macro.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/expand_macro.rs#L14[expand_macro.rs]
 
 Shows the full macro expansion of the macro at current cursor.
 
diff --git a/thisweek/_posts/2021-06-14-changelog-81.adoc b/thisweek/_posts/2021-06-14-changelog-81.adoc
@@ -0,0 +1,52 @@
+= Changelog #81
+:sectanchors:
+:page-layout: post
+
+Commit: commit:f0618a8f06a464840079f30b3e25bcdcca3922a3[] +
+Release: release:2021-06-14[]
+
+== Sponsors
+
+**Become a sponsor:** On https://opencollective.com/rust-analyzer/[OpenCollective] or
+https://github.com/sponsors/rust-analyzer[GitHub Sponsors].
+
+== New Features
+
+* pr:9144[] (first contribution) extend "Convert tuple to named struct" assist to work for enum variants.
+* pr:9106[] "Go to definition" on an `impl` function goes to the corresponding function in the trait.
++
+image::https://user-images.githubusercontent.com/6652840/120403989-39aa3280-c2fa-11eb-9359-639346878acd.gif[]
+* pr:9223[] complete associated types in `dyn` and `impl trait`.
+* pr:9202[] make "Memory usage" work on Windows.
+* pr:9204[] improve memory usage info accuracy on `glibc` Linux.
+* pr:9244[] make block-local trait impls work.
+* pr:9153[] show server status when click on the VS Code status bar entry to show the server status.
+
+== Fixes
+
+* pr:9180[] fix some IDE functionality inside attribute macros.
+* pr:9239[] fix coercion in match with expected type.
+* pr:9182[] don't complete derive macros as function-like macros.
+* pr:9187[] fix edge case in import granularity guessing.
+* pr:9186[] prefer attr macros in "Expand macro recursively".
+* pr:9191[] don't descend into `MacroCall` `TokenTree` delimiters.
+* pr:9196[] don't classify attributes on macro-calls as the macro itself.
+* pr:9209[] don't suggest "Remove unused param" in trait impls.
+* pr:9215[] enable "Change visibility" assist for `use` and `macro` items.
+* pr:9216[] don't allow lookup by `self` for unprefixed completions.
+* pr:9218[] make item search respect trait impl items.
+* pr:9221[] correctly highlight tuple field accesses.
+* pr:9161[] fix incorrect config usage in hover references.
+
+== Internal Improvements
+
+* pr:9240[] (first contribution) fix a small typo.
+* pr:9169[] steps towards attribute macro token mapping.
+* pr:9217[] don't stringify and reparse `cfg_attr`-gated attributes.
+* pr:9192[] build test-macros in a build script.
+* pr:9238[] upgrade `cov-mark` for cross-crate usage.
+* pr:9243[] check that coverage marks are always paired.
+* pr:9164[], pr:9170[], pr:9171[] simplify completions some more.
+* pr:9242[] fix some `clippy` warnings.
+* pr:9166[] clarify issue label documentation.
+* pr:9230[], pr:9237[], pr:9233[], pr:9245[], pr:9246[], pr:9247[], pr:9248[], pr:9249[], pr:9250[], pr:9252[], pr:9253[], pr:9255[], pr:9256[], pr:9257[] move diagnostics to a `hir`-based API.
