Merge #285: Take all get_index_info rpc call return values as Option<>

300b3cc Take all get_index_info rpc call return values as Option<> (dev7ba)

Pull request description:

  The values returned by get_index_info are optional depending on whether the values txindex=1, blockfilterindex=1, and coinstatsindex=1 are configured in bitcoin.conf.

  This causes the library to fail in case any of these indices are not configured.

  I closed last pull request due to problems with rebase.

ACKs for top commit:
  apoelstra:
    ACK 300b3cc

Tree-SHA512: b027faf3fb2d798eb981f0a52ab8641c4e48d94ba41d39271e83bc4647b74c60fa153e9ba3dc440e3fe781b78ee39089e52b6081bc77f20e97025daebd8f9392

Author: apoelstra

integration_test/src/main.rs

@@ -215,6 +215,7 @@ fn main() {
     test_disconnect_node(&cl);
     test_add_ban(&cl);
     test_set_network_active(&cl);
+    test_get_index_info(&cl);
     test_stop(cl);
 }
 
@@ -1262,6 +1263,15 @@ fn test_getblocktemplate(cl: &Client) {
     cl.generate_to_address(2, &RANDOM_ADDRESS).unwrap();
 }
 
+fn test_get_index_info(cl: &Client) {
+    if version() >= 210000 {
+        let gii = cl.get_index_info().unwrap();
+        assert!(gii.txindex.is_some());
+        assert!(gii.coinstatsindex.is_none());
+        assert!(gii.basic_block_filter_index.is_some());
+    }
+}
+
 fn test_stop(cl: Client) {
     println!("Stopping: '{}'", cl.stop().unwrap());
 }

json/src/lib.rs

@@ -2125,10 +2125,10 @@ pub struct IndexStatus {
 
 #[derive(Serialize, Deserialize, Clone, PartialEq, Eq, Debug)]
 pub struct GetIndexInfoResult {
-    pub txindex: IndexStatus,
-    pub coinstatsindex: IndexStatus,
+    pub txindex: Option<IndexStatus>,
+    pub coinstatsindex: Option<IndexStatus>,
     #[serde(rename = "basic block filter index")]
-    pub basic_block_filter_index: IndexStatus,
+    pub basic_block_filter_index: Option<IndexStatus>,
 }
 
 impl<'a> serde::Serialize for PubKeyOrAddress<'a> {