Skip to content
This repository was archived by the owner on Apr 13, 2021. It is now read-only.

Commit e89dded

Browse files
committed
Remove TODO: make tag constants u5s
Using the u5 type for tag constants would clean up the code at some places, but to achieve this a workaround for constructing these constants would be necessary (since rust has no constexpr functions yet). All workarounds I see aren't worth it (unsafe or lazy_static).
1 parent b89b583 commit e89dded

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/ser.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,6 @@ impl ToBase32<Vec<u5>> for TaggedField {
266266
assert!(data.len() < 1024, "Every tagged field data can be at most 1023 bytes long.");
267267

268268
let mut sized_data = Vec::<u5>::with_capacity(data.len() + 3);
269-
// TODO: think about saving tag constants as u5c
270269
sized_data.push(u5::try_from_u8(tag).expect("Tags should be <32."));
271270
sized_data.extend_from_slice(
272271
&try_stretch(

0 commit comments

Comments
 (0)