Add/update set2 scancodes #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- scancode for backslash/pipe is 0x5d and not 0x61; - added scancodes for print screen (0xE07C), control-break (0xE07D) and alt-sysreq (0x84).
thejpster
requested changes
Oct 15, 2021
|
Thank you for the PR! I've left some comments :) |
- `AltSysReq` is now just `SysReq` as it signals the function, not the means of typing it; - similar for `ControlBreak`, which is now just named `Break`.
|
Thank you for your review; I've processed your remarks and commented on them. |
thejpster
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0x5dnot0x61;0xE07C), control-break (0xE07D) and alt-sysreq (0x84).