Pause/break support #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tapping "Pause" generates E1,14,77,E1,F0,14,F0,77 We now decode this as: * PauseBreak/Down * NumLock/Down * PauseBreak/Up * NumLock/Up Tapping "Print Scr" generates E0,12,E0,7C. This becomes: We now decode this as: * PrintScreen/SingleShot * PrintScreen2/SingleShot Note the addition of the "SingleShot" KeyState, for keys that don't have a Make/Break pair. This avoids users waiting a "Break" that never happens.
Means we can add keys without breaking backwards compatibility. KeyEvents are also manually numbered to discourage anyone adding one in the middle instead of at the end.
|
Need to change MSRV |
Required for [non-exhaustive]
|
Closes #17 |
jamesmunns
approved these changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Pause/Break and PrintScreen keys on Scancode Set 2.
Makes Key Events non-exhaustive (so we can add more later without a breaking change)
Switches to Github Actions (we were still on travis-ci!)