add a Cargo feature, cm7-r0p1, to fix a Cortex-M7 BASEPRI erratum #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@homunkulus r+ |
|
📌 Commit 4cd62a9 has been approved by |
japaric
pushed a commit
that referenced
this pull request
Jan 11, 2018
add a Cargo feature, cm7-r0p1, to fix a Cortex-M7 BASEPRI erratum see japaric/cortex-m-rtfm#53 for background information
|
💔 Test failed - status-travis |
|
@homunkulus r+ |
|
📌 Commit f6ee6d0 has been approved by |
japaric
pushed a commit
that referenced
this pull request
Jan 11, 2018
add a Cargo feature, cm7-r0p1, to fix a Cortex-M7 BASEPRI erratum see japaric/cortex-m-rtfm#53 for background information
|
☀️ Test successful - status-travis |
japaric
pushed a commit
to rtic-rs/rtic
that referenced
this pull request
Jan 11, 2018
add a Cargo feature, cm7-r0p1, to fix a Cortex-M7 BASEPRI erratum closes #53 alternative solution to #54 depends on rust-embedded/cortex-m#72
japaric
pushed a commit
to rtic-rs/rtic
that referenced
this pull request
Jan 11, 2018
add a Cargo feature, cm7-r0p1, to fix a Cortex-M7 BASEPRI erratum closes #53 alternative solution to #54 depends on rust-embedded/cortex-m#72
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
`exception!(HardFault, ..)` and `exception!(*, ..)` can now be omitted from programs to pick up the default behavior of an infinite loop. Existing programs that define these exception handlers will continue to work w/o any functional change. closes #72
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
85: [WIP] provide defaults for DefaultHandler and HardFault r=korken89 a=japaric `exception!(HardFault, ..)` and `exception!(*, ..)` can now be omitted from programs to pick up the default behavior of an infinite loop. Existing programs that define these exception handlers will continue to work w/o any functional change. closes #72 -- Annoyances: - The handlers can't be *just* an infinite loop because of rust-lang/rust#28728. If we define the handlers as just `loop {}` they will become an abort (UDF) instruction. And that would turn HardFault into infinite recursion. For that reason I have made them into an infinite loop that does some side effect - If you stick to the defaults then the symbol name of the default handler changes from `DefaultHandler` (override) to `DefaultDefaultHandler` (default). We can make these two names more similar but I think we can not prevent the rename. Something similar happens with UserHardFault (which becomes DefaultUserHardFault when not overridden). cc @rust-embedded/cortex-m Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see japaric/cortex-m-rtfm#53 for background information