Load runtime filter from URL

Author: Kobzol

site/frontend/src/pages/compare/compile/common.ts

@@ -23,6 +23,7 @@ export type CompileBenchmarkFilter = {
     library: boolean;
   };
 } & BenchmarkFilter;
+
 export const defaultCompileFilter: CompileBenchmarkFilter = {
   name: null,
   nonRelevant: false,

site/frontend/src/pages/compare/compile/compile-page.vue

@@ -17,6 +17,7 @@ import {
 } from "./common";
 import {BenchmarkInfo} from "../../../api";
 import {importantCompileMetrics} from "../metrics";
+import {getBoolOrDefault} from "../shared";
 
 const props = defineProps<{
   data: CompareResponse;
@@ -28,45 +29,65 @@ function loadFilterFromUrl(
   urlParams: Dict<string>,
   defaultFilter: CompileBenchmarkFilter
 ): CompileBenchmarkFilter {
-  function getBoolOrDefault(name: string, defaultValue: boolean): boolean {
-    if (urlParams.hasOwnProperty(name)) {
-      return urlParams[name] === "true";
-    }
-    return defaultValue;
-  }
-
   return {
     name: urlParams["name"] ?? defaultFilter.name,
-    nonRelevant: getBoolOrDefault("nonRelevant", defaultFilter.nonRelevant),
-    showRawData: getBoolOrDefault("showRawData", defaultFilter.showRawData),
+    nonRelevant: getBoolOrDefault(
+      urlParams,
+      "nonRelevant",
+      defaultFilter.nonRelevant
+    ),
+    showRawData: getBoolOrDefault(
+      urlParams,
+      "showRawData",
+      defaultFilter.showRawData
+    ),
     profile: {
-      check: getBoolOrDefault("check", defaultFilter.profile.check),
-      debug: getBoolOrDefault("debug", defaultFilter.profile.debug),
-      opt: getBoolOrDefault("opt", defaultFilter.profile.opt),
-      doc: getBoolOrDefault("doc", defaultFilter.profile.doc),
+      check: getBoolOrDefault(urlParams, "check", defaultFilter.profile.check),
+      debug: getBoolOrDefault(urlParams, "debug", defaultFilter.profile.debug),
+      opt: getBoolOrDefault(urlParams, "opt", defaultFilter.profile.opt),
+      doc: getBoolOrDefault(urlParams, "doc", defaultFilter.profile.doc),
     },
     scenario: {
-      full: getBoolOrDefault("full", defaultFilter.scenario.full),
-      incrFull: getBoolOrDefault("incrFull", defaultFilter.scenario.incrFull),
+      full: getBoolOrDefault(urlParams, "full", defaultFilter.scenario.full),
+      incrFull: getBoolOrDefault(
+        urlParams,
+        "incrFull",
+        defaultFilter.scenario.incrFull
+      ),
       incrUnchanged: getBoolOrDefault(
+        urlParams,
         "incrUnchanged",
         defaultFilter.scenario.incrUnchanged
       ),
       incrPatched: getBoolOrDefault(
+        urlParams,
         "incrPatched",
         defaultFilter.scenario.incrPatched
       ),
     },
     category: {
-      primary: getBoolOrDefault("primary", defaultFilter.category.primary),
+      primary: getBoolOrDefault(
+        urlParams,
+        "primary",
+        defaultFilter.category.primary
+      ),
       secondary: getBoolOrDefault(
+        urlParams,
         "secondary",
         defaultFilter.category.secondary
       ),
     },
     artifact: {
-      binary: getBoolOrDefault("binary", defaultFilter.artifact.binary),
-      library: getBoolOrDefault("library", defaultFilter.artifact.library),
+      binary: getBoolOrDefault(
+        urlParams,
+        "binary",
+        defaultFilter.artifact.binary
+      ),
+      library: getBoolOrDefault(
+        urlParams,
+        "library",
+        defaultFilter.artifact.library
+      ),
     },
   };
 }

site/frontend/src/pages/compare/runtime/runtime-page.vue

@@ -6,20 +6,43 @@ import {computeSummary, filterNonRelevant} from "../data";
 import {
   computeRuntimeComparisonsWithNonRelevant,
   defaultRuntimeFilter,
+  RuntimeBenchmarkFilter,
 } from "./common";
-import {deepCopy} from "../../../utils/copy";
 import MetricSelector from "../metric-selector.vue";
 import {BenchmarkInfo} from "../../../api";
 import {importantRuntimeMetrics} from "../metrics";
 import ComparisonsTable from "./comparisons-table.vue";
+import {getBoolOrDefault} from "../shared";
+import {getUrlParams} from "../../../utils/navigation";
 
 const props = defineProps<{
   data: CompareResponse;
   selector: CompareSelector;
   benchmarkInfo: BenchmarkInfo;
 }>();
 
-const filter = ref(deepCopy(defaultRuntimeFilter));
+function loadFilterFromUrl(
+  urlParams: Dict<string>,
+  defaultFilter: RuntimeBenchmarkFilter
+): RuntimeBenchmarkFilter {
+  return {
+    name: urlParams["name"] ?? defaultFilter.name,
+    nonRelevant: getBoolOrDefault(
+      urlParams,
+      "nonRelevant",
+      defaultFilter.nonRelevant
+    ),
+    showRawData: getBoolOrDefault(
+      urlParams,
+      "showRawData",
+      defaultFilter.showRawData
+    ),
+  };
+}
+
+const urlParams = getUrlParams();
+const filter = ref(loadFilterFromUrl(urlParams, defaultRuntimeFilter));
+
 const allComparisons = computed(() =>
   computeRuntimeComparisonsWithNonRelevant(
     filter.value,

site/frontend/src/pages/compare/shared.ts

@@ -67,3 +67,14 @@ export function formatPercentChange(
 export function isValidValue(size: number | undefined): boolean {
   return size !== undefined && size !== 0;
 }
+
+export function getBoolOrDefault(
+  params: Dict<string>,
+  name: string,
+  defaultValue: boolean
+): boolean {
+  if (params.hasOwnProperty(name)) {
+    return params[name] === "true";
+  }
+  return defaultValue;
+}