Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Commit 674b52a

Browse files
committed
Auto merge of rust-lang#13862 - danieleades:logic-bug, r=lnicola
comment out disabled code
2 parents 6e89e77 + db41e6b commit 674b52a

File tree

2 files changed

+1
-27
lines changed

2 files changed

+1
-27
lines changed

crates/rust-analyzer/tests/slow-tests/tidy.rs

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ fn files_are_tidy() {
8282
check_dbg(&path, &text);
8383
check_test_attrs(&path, &text);
8484
check_trailing_ws(&path, &text);
85-
deny_clippy(&path, &text);
8685
tidy_docs.visit(&path, &text);
8786
tidy_marks.visit(&path, &text);
8887
}
@@ -144,32 +143,6 @@ fn check_cargo_toml(path: &Path, text: String) {
144143
}
145144
}
146145

147-
fn deny_clippy(path: &Path, text: &str) {
148-
let ignore = &[
149-
// The documentation in string literals may contain anything for its own purposes
150-
"ide-db/src/generated/lints.rs",
151-
// The tests test clippy lint hovers
152-
"ide/src/hover/tests.rs",
153-
// The tests test clippy lint completions
154-
"ide-completion/src/tests/attribute.rs",
155-
];
156-
if ignore.iter().any(|p| path.ends_with(p)) {
157-
return;
158-
}
159-
160-
if text.contains("\u{61}llow(clippy") {
161-
panic!(
162-
"\n\nallowing lints is forbidden: {}.
163-
rust-analyzer intentionally doesn't check clippy on CI.
164-
You can allow lint globally via `xtask clippy`.
165-
See https://github.com/rust-lang/rust-clippy/issues/5537 for discussion.
166-
167-
",
168-
path.display()
169-
)
170-
}
171-
}
172-
173146
#[cfg(not(feature = "in-rust-tree"))]
174147
#[test]
175148
fn check_licenses() {

crates/syntax/src/syntax_node.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ impl SyntaxTreeBuilder {
4848
pub fn finish(self) -> Parse<SyntaxNode> {
4949
let (green, errors) = self.finish_raw();
5050
// Disable block validation, see https://github.com/rust-lang/rust-analyzer/pull/10357
51+
#[allow(clippy::overly_complex_bool_expr)]
5152
if cfg!(debug_assertions) && false {
5253
let node = SyntaxNode::new_root(green.clone());
5354
crate::validation::validate_block_structure(&node);

0 commit comments

Comments
 (0)