refactor: rename to descriptive name

1hakusai1 · 1hakusai1 · commit 97a7d2354a59 · 2025-01-16T09:33:52.000+09:00
diff --git a/src/tools/rust-analyzer/crates/ide/src/goto_definition.rs b/src/tools/rust-analyzer/crates/ide/src/goto_definition.rs
@@ -82,7 +82,8 @@ pub(crate) fn goto_definition(
         return Some(RangeInfo::new(original_token.text_range(), navs));
     }
 
-    if let Some(navs) = find_from_definition(file_id, &original_token, sema) {
+    if let Some(navs) = find_definition_for_known_blanket_dual_impls(file_id, &original_token, sema)
+    {
         return Some(RangeInfo::new(original_token.text_range(), navs));
     }
 
@@ -131,7 +132,7 @@ pub(crate) fn goto_definition(
 }
 
 // If the token is into(), try_into(), parse(), search the definition of From, TryFrom, FromStr.
-fn find_from_definition(
+fn find_definition_for_known_blanket_dual_impls(
     file_id: FileId,
     original_token: &SyntaxToken,
     sema: &Semantics<'_, RootDatabase>,

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,8 @@ pub(crate) fn goto_definition(`
`82`	`82`	`return Some(RangeInfo::new(original_token.text_range(), navs));`
`83`	`83`	`}`
`84`	`84`
`85`		`- if let Some(navs) = find_from_definition(file_id, &original_token, sema) {`
	`85`	`+ if let Some(navs) = find_definition_for_known_blanket_dual_impls(file_id, &original_token, sema)`
	`86`	`+ {`
`86`	`87`	`return Some(RangeInfo::new(original_token.text_range(), navs));`
`87`	`88`	`}`
`88`	`89`
`@@ -131,7 +132,7 @@ pub(crate) fn goto_definition(`
`131`	`132`	`}`
`132`	`133`
`133`	`134`	`// If the token is into(), try_into(), parse(), search the definition of From, TryFrom, FromStr.`
`134`		`-fn find_from_definition(`
	`135`	`+fn find_definition_for_known_blanket_dual_impls(`
`135`	`136`	`file_id: FileId,`
`136`	`137`	`original_token: &SyntaxToken,`
`137`	`138`	`sema: &Semantics<'_, RootDatabase>,`