Separate compile and runtime metrics

This makes the select box in compare/runtime page more precise, and it also fills it with relevant data if only runtime entries are present in the DB (this is only relevant for local execution of the site).

Author: Kobzol

database/src/lib.rs

@@ -594,7 +594,7 @@ impl Index {
     // millions of queries and labels and iterating all of them is eventually
     // going to be impractical. But for now it performs quite well, so we'll go
     // for it as keeping indices around would be annoying.
-    pub fn metrics(&self) -> Vec<String> {
+    pub fn compile_metrics(&self) -> Vec<String> {
         self.pstat_series
             .map
             .keys()
@@ -605,6 +605,17 @@ impl Index {
             .collect()
     }
 
+    pub fn runtime_metrics(&self) -> Vec<String> {
+        self.runtime_pstat_series
+            .map
+            .keys()
+            .map(|(_, metric)| metric)
+            .collect::<std::collections::HashSet<_>>()
+            .into_iter()
+            .map(|s| s.to_string())
+            .collect()
+    }
+
     // FIXME: in theory this won't scale indefinitely as there's potentially
     // millions of queries and labels and iterating all of them is eventually
     // going to be impractical. But for now it performs quite well, so we'll go

site/frontend/src/api.ts

@@ -2,8 +2,10 @@ import {getJson} from "./utils/requests";
 import {INFO_URL} from "./urls";
 
 export interface BenchmarkInfo {
-  // Known statistic values from the DB
-  stats: [string];
+  // Known compile metrics from the DB
+  compile_metrics: [string];
+  // Known runtime metrics from the DB
+  runtime_metrics: [string];
   // Last loaded run date
   as_of: string | null;
 }

site/frontend/src/pages/compare/compile/compile-page.vue

@@ -189,7 +189,7 @@ const filteredSummary = computed(() => computeSummary(comparisons.value));
   <MetricSelector
     :quick-links="importantCompileMetrics"
     :selected-metric="selector.stat"
-    :benchmark-info="benchmarkInfo"
+    :metrics="benchmarkInfo.compile_metrics"
   />
   <Filters
     :defaultFilter="defaultCompileFilter"

site/frontend/src/pages/compare/header/data-selector.vue

@@ -79,7 +79,10 @@ const opened = ref(false);
             "
           >
             <select class="stats" ref="statRef">
-              <option v-for="value in props.info.stats" :value="value">
+              <option
+                v-for="value in props.info.compile_metrics"
+                :value="value"
+              >
                 {{ value }}
               </option>
             </select>

site/frontend/src/pages/compare/metric-selector.vue

@@ -9,7 +9,7 @@ import {MetricDescription} from "./metrics";
 const props = defineProps<{
   quickLinks: MetricDescription[];
   selectedMetric: string;
-  benchmarkInfo: BenchmarkInfo;
+  metrics: string[];
 }>();
 
 function navigateToMetric(metric: string) {
@@ -37,9 +37,9 @@ function changeMetric(e: Event) {
         metric.label
       }}</a>
     </div>
-    <select class="stats" @change="changeMetric">
+    <select class="stats" @change="changeMetric" v-if="metrics.length > 0">
       <option
-        v-for="value in benchmarkInfo.stats"
+        v-for="value in metrics"
         :value="value"
         :selected="value === selectedMetric"
       >

site/frontend/src/pages/compare/runtime/runtime-page.vue

@@ -92,9 +92,9 @@ const filteredSummary = computed(() => computeSummary(comparisons.value));
 
 <template>
   <MetricSelector
-    :selected-metric="selector.stat"
-    :benchmark-info="benchmarkInfo"
     :quick-links="importantRuntimeMetrics"
+    :selected-metric="selector.stat"
+    :metrics="benchmarkInfo.runtime_metrics"
   />
   <Filters
     :defaultFilter="defaultRuntimeFilter"

site/frontend/src/pages/graphs/data-selector.vue

@@ -53,7 +53,7 @@ function submitSettings() {
       <option value="percentrelative">Percent Delta from Previous</option>
     </select>
     <select ref="statRef">
-      <option v-for="value in info.stats" :value="value">
+      <option v-for="value in info.compile_metrics" :value="value">
         {{ value }}
       </option></select
     >&nbsp;<a href="#" @click.prevent="submitSettings">Submit</a>

site/src/api.rs

@@ -14,8 +14,11 @@ pub mod info {
 
     #[derive(Debug, Clone, PartialEq, Serialize)]
     pub struct Response {
-        /// Sorted list of statistic names known
-        pub stats: Vec<String>,
+        /// Sorted list of known compile metrics
+        pub compile_metrics: Vec<String>,
+
+        /// Sorted list of known runtime metrics
+        pub runtime_metrics: Vec<String>,
 
         /// Chronologically last loaded run date.
         pub as_of: Option<Date>,

site/src/request_handlers.rs

@@ -21,10 +21,15 @@ use crate::api::{info, ServerResult};
 use crate::load::SiteCtxt;
 
 pub fn handle_info(ctxt: &SiteCtxt) -> info::Response {
-    let mut metrics = ctxt.index.load().metrics();
-    metrics.sort();
+    let mut compile_metrics = ctxt.index.load().compile_metrics();
+    compile_metrics.sort();
+
+    let mut runtime_metrics = ctxt.index.load().runtime_metrics();
+    runtime_metrics.sort();
+
     info::Response {
-        stats: metrics,
+        compile_metrics,
+        runtime_metrics,
         as_of: ctxt.index.load().commits().last().map(|d| d.date),
     }
 }