Skip to content

4.34 Macros #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2017
Merged

4.34 Macros #220

merged 2 commits into from
Jan 30, 2017

Conversation

KeenS
Copy link
Member

@KeenS KeenS commented Dec 12, 2016

@tatsuya6502 レビューお願いします。

@tatsuya6502 tatsuya6502 self-requested a review January 23, 2017 15:07
@tatsuya6502 tatsuya6502 added this to the 1.9 milestone Jan 24, 2017
@tatsuya6502 tatsuya6502 changed the title 4.32 Macros 4.34 Macros Jan 24, 2017
@tatsuya6502
Copy link
Member

tatsuya6502 commented Jan 28, 2017

Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KeenS 1点だけコメントしました。ご確認をお願いします。

呼出構文を変更して識別可能なトークンを先頭につけることでこの問題は回避することができます。
そのようにする場合、例えば `$(T $t:ty)* E $e:exp` のように書くことができます。
そのようにする場合、例えば `$(I $i:ident)* E $e:exp` のように書くことができます。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいのですが、原文で E $e:expE $e:expr に修正されていますので、訳文の方でも修正をお願いします。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

気付きませんでした。ありがとうございます。

Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KeenS 修正ありがとうございました。レビューOKですので、マージします。

おつかれさまでした!

@tatsuya6502 tatsuya6502 merged commit 0de224a into rust-lang-ja:master Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants