Skip to content

Commit 60539e9

Browse files
committed
ci: bump cargo-semver-checks to 0.24.0
Also remove workaround since the issue was fixed in upstream.
1 parent 637ade0 commit 60539e9

File tree

2 files changed

+3
-17
lines changed

2 files changed

+3
-17
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
- name: Install cargo-semver-checks
9999
run: |
100100
mkdir installed-bins
101-
curl -Lf https://github.com/obi1kenobi/cargo-semver-checks/releases/download/v0.22.1/cargo-semver-checks-x86_64-unknown-linux-gnu.tar.gz \
101+
curl -Lf https://github.com/obi1kenobi/cargo-semver-checks/releases/download/v0.24.0/cargo-semver-checks-x86_64-unknown-linux-gnu.tar.gz \
102102
| tar -xz --directory=./installed-bins
103103
echo `pwd`/installed-bins >> $GITHUB_PATH
104104
- run: ci/validate-version-bump.sh

crates/xtask-bump-check/src/xtask.rs

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -148,26 +148,13 @@ fn bump_check(args: &clap::ArgMatches, config: &cargo::util::Config) -> CargoRes
148148
anyhow::bail!(msg)
149149
}
150150

151-
// Tracked by https://github.com/obi1kenobi/cargo-semver-checks/issues/511
152-
let exclude_args = [
153-
"--exclude",
154-
"cargo-credential-1password",
155-
"--exclude",
156-
"cargo-credential-libsecret",
157-
"--exclude",
158-
"cargo-credential-macos-keychain",
159-
"--exclude",
160-
"cargo-credential-wincred",
161-
];
162-
163151
// Even when we test against baseline-rev, we still need to make sure a
164152
// change doesn't violate SemVer rules against crates.io releases. The
165153
// possibility of this happening is nearly zero but no harm to check twice.
166154
let mut cmd = ProcessBuilder::new("cargo");
167155
cmd.arg("semver-checks")
168156
.arg("check-release")
169-
.arg("--workspace")
170-
.args(&exclude_args);
157+
.arg("--workspace");
171158
config.shell().status("Running", &cmd)?;
172159
cmd.exec()?;
173160

@@ -176,8 +163,7 @@ fn bump_check(args: &clap::ArgMatches, config: &cargo::util::Config) -> CargoRes
176163
cmd.arg("semver-checks")
177164
.arg("--workspace")
178165
.arg("--baseline-rev")
179-
.arg(referenced_commit.id().to_string())
180-
.args(&exclude_args);
166+
.arg(referenced_commit.id().to_string());
181167
config.shell().status("Running", &cmd)?;
182168
cmd.exec()?;
183169
}

0 commit comments

Comments
 (0)