Don't pass through CARGO_MAKEFLAGS args on BSD platforms
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are incompatible with bsdmake, and will cause failures in any packages that use this lib on systems where make == bsdmake.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are incompatible with bsdmake, and will cause failures in
any packages that use this lib on systems where make == bsdmake.
Tested on OpenBSD 6.2/amd64 against
git2-rs. This fixed all build failures on that platform.Another possible solution is forcing bsd platforms to use
gmake, but this introduces an external dependency and is otherwise unnecessary becausecmakegenerates portableMakefiles