Skip to content

Add no_build_target option #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2018
Merged

Add no_build_target option #49

merged 3 commits into from
Aug 3, 2018

Conversation

rzumer
Copy link
Contributor

@rzumer rzumer commented Aug 2, 2018

Fixes #37. I assume there is a good reason why a target of None is unwrapped to install, but if not, we can skip adding an extra parameter and simply fall back to no target.

@rzumer
Copy link
Contributor Author

rzumer commented Aug 3, 2018

Reopening the PR to trigger a rebuild...

@rzumer rzumer closed this Aug 3, 2018
@rzumer rzumer reopened this Aug 3, 2018
Instead of always setting it to true.
@alexcrichton alexcrichton merged commit 4998d28 into rust-lang:master Aug 3, 2018
@alexcrichton
Copy link
Member

Thanks!

@rzumer
Copy link
Contributor Author

rzumer commented Aug 3, 2018

Thanks for the merge, if this could be rolled into a version update soon I would appreciate it, since it's necessary to compile correctly on some targets.

@alexcrichton
Copy link
Member

Published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants