Merge pull request #1317 from CvX/eslint-fix-avoid-leaking-state-in-ember-objects

ESLint: fix “ember/avoid-leaking-state-in-ember-objects” error.

Author: Turbo87

.eslintrc.js

@@ -30,7 +30,6 @@ module.exports = {
             'avoidEscape': true,
         }],
         'ember/no-on-calls-in-components': 'off',
-        'ember/avoid-leaking-state-in-ember-objects': 'off',
         'ember/no-capital-letters-in-routes': 'off',
     },
     overrides: [

app/controllers/me/index.js

@@ -3,6 +3,7 @@ import { sort, filterBy, notEmpty } from '@ember/object/computed';
 import { inject as service } from '@ember/service';
 
 export default Controller.extend({
+    // eslint-disable-next-line ember/avoid-leaking-state-in-ember-objects
     tokenSort: ['created_at:desc'],
 
     sortedTokens: sort('model.api_tokens', 'tokenSort'),

app/models/crate.js

@@ -24,8 +24,11 @@ export default DS.Model.extend({
         ...badge,
         component_name: `badge-${badge.badge_type}`
     })),
+
+    // eslint-disable-next-line ember/avoid-leaking-state-in-ember-objects
     badge_sort: ['badge_type'],
     annotated_badges: sort('enhanced_badges', 'badge_sort'),
+
     owners: DS.hasMany('users', { async: true }),
     owner_team: DS.hasMany('teams', { async: true }),
     owner_user: DS.hasMany('users', { async: true }),

app/routes/dashboard.js

@@ -5,8 +5,6 @@ import RSVP from 'rsvp';
 import AuthenticatedRoute from '../mixins/authenticated-route';
 
 export default Route.extend(AuthenticatedRoute, {
-    data: {},
-
     setupController(controller) {
         this._super(...arguments);
 

app/routes/index.js

@@ -1,13 +1,15 @@
 import Route from '@ember/routing/route';
 
 export default Route.extend({
-    headTags: [{
-        type: 'meta',
-        attrs: {
-            name: 'description',
-            content: 'cargo is the package manager and crate host for rust'
-        }
-    }],
+    headTags() {
+        return [{
+            type: 'meta',
+            attrs: {
+                name: 'description',
+                content: 'cargo is the package manager and crate host for rust',
+            },
+        }];
+    },
 
     setupController(controller) {
         controller.get('dataTask').perform();

tests/acceptance/crate-test.js

@@ -195,8 +195,8 @@ module('Acceptance | crate page', function(hooks) {
         this.server.loadFixtures();
 
         this.owner.register('service:session', Service.extend({
-            currentUser: {
-                login: 'iain8'
+            get currentUser() {
+                return { login: 'iain8' };
             },
             loadUser() {},
         }));
@@ -210,8 +210,8 @@ module('Acceptance | crate page', function(hooks) {
         this.server.loadFixtures();
 
         this.owner.register('service:session', Service.extend({
-            currentUser: {
-                login: 'thehydroimpulse'
+            get currentUser() {
+                return { login: 'thehydroimpulse' };
             },
             loadUser() {},
         }));