models/version: Extract loadReadmeTask

Author: Turbo87

app/controllers/crate/version.js

@@ -128,25 +128,18 @@ export default Controller.extend({
   }),
 
   loadReadmeTask: task(function* () {
-    if (this.currentVersion.get('readme_path')) {
-      try {
-        let r = yield fetch(this.currentVersion.get('readme_path'));
-        if (r.ok) {
-          this.crate.set('readme', yield r.text());
-
-          if (typeof document !== 'undefined') {
-            setTimeout(() => {
-              let e = document.createEvent('CustomEvent');
-              e.initCustomEvent('hashchange', true, true);
-              window.dispatchEvent(e);
-            });
-          }
-        } else {
-          this.crate.set('readme', null);
-        }
-      } catch (error) {
-        this.crate.set('readme', null);
+    try {
+      this.crate.set('readme', yield this.currentVersion.loadReadmeTask.perform());
+
+      if (typeof document !== 'undefined') {
+        setTimeout(() => {
+          let e = document.createEvent('CustomEvent');
+          e.initCustomEvent('hashchange', true, true);
+          window.dispatchEvent(e);
+        });
       }
+    } catch (error) {
+      this.crate.set('readme', null);
     }
   }),
 

app/models/version.js

@@ -39,4 +39,15 @@ export default Model.extend({
 
     return { normal, build, dev };
   }).keepLatest(),
+
+  loadReadmeTask: task(function* () {
+    if (this.readme_path) {
+      let response = yield fetch(this.readme_path);
+      if (!response.ok) {
+        throw new Error(`README request for ${this.crateName} v${this.num} failed`);
+      }
+
+      return yield response.text();
+    }
+  }).keepLatest(),
 });