Skip to content

Commit 0f7f785

Browse files
Turbo87Turbo87
committed
ESLint: Enable "no-var" rule
1 parent e14815f commit 0f7f785

22 files changed

+79
-80
lines changed

‎.eslintrc.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ module.exports = {
2121
'comma-dangle': 'off',
2222
'dot-notation': 'off',
2323
'indent': ['error', 4],
24-
'no-var': 'off',
2524
'operator-linebreak': 'off',
2625
'quotes': ['error', 'single', {
2726
'allowTemplateLiterals': true,

‎app/adapters/category-slug.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import Ember from 'ember';
33

44
export default ApplicationAdapter.extend({
55
pathForType(modelName) {
6-
var decamelized = Ember.String.underscore(
6+
let decamelized = Ember.String.underscore(
77
Ember.String.decamelize(modelName)
88
);
99
return Ember.String.pluralize(decamelized);

‎app/adapters/dependency.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default ApplicationAdapter.extend({
66
return this._super(...arguments);
77
}
88
delete query.reverse;
9-
var { crate } = query;
9+
let { crate } = query;
1010
delete query.crate;
1111
return this.ajax(`/${this.urlPrefix()}/crates/${crate.get('id')}/reverse_dependencies`,
1212
'GET', { data: query });

‎app/components/download-graph.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -84,39 +84,39 @@ export default Ember.Component.extend({
8484
this.$().show();
8585
}
8686

87-
var myData = window.google.visualization.arrayToDataTable(data);
87+
let myData = window.google.visualization.arrayToDataTable(data);
8888

89-
var fmt = new window.google.visualization.DateFormat({
89+
let fmt = new window.google.visualization.DateFormat({
9090
pattern: 'LLL d, yyyy',
9191
});
9292
fmt.format(myData, 0);
9393

9494
// use a DataView to calculate an x-day moving average
95-
var days = 7;
96-
var view = new window.google.visualization.DataView(myData);
97-
var moving_avg_func_for_col = function(col) {
95+
let days = 7;
96+
let view = new window.google.visualization.DataView(myData);
97+
let moving_avg_func_for_col = function(col) {
9898
return function(dt, row) {
9999
// For the last rows (the *first* days, remember, the dataset is
100100
// backwards), we cannot calculate the avg. of previous days.
101101
if (row >= dt.getNumberOfRows() - days) {
102102
return null;
103103
}
104104

105-
var total = 0;
106-
for (var i = days; i > 0; i--) {
105+
let total = 0;
106+
for (let i = days; i > 0; i--) {
107107
total += dt.getValue(row + i, col);
108108
}
109-
var avg = total / days;
109+
let avg = total / days;
110110
return {
111111
v: avg,
112112
f: avg.toFixed(2)
113113
};
114114
};
115115
};
116116

117-
var columns = [0]; // 0 = datetime
118-
var seriesOption = {};
119-
var [headers] = data;
117+
let columns = [0]; // 0 = datetime
118+
let seriesOption = {};
119+
let [headers] = data;
120120
// Walk over the headers/colums in reverse order, as the newest version
121121
// is at the end, but in the UI we want it at the top of the chart legend.
122122

@@ -145,7 +145,7 @@ export default Ember.Component.extend({
145145
});
146146
view.setColumns(columns);
147147

148-
var chart = new window.google.visualization.ComboChart(this.get('element'));
148+
let chart = new window.google.visualization.ComboChart(this.get('element'));
149149
chart.draw(view, {
150150
chartArea: { 'left': 85, 'width': '77%', 'height': '80%' },
151151
hAxis: {

‎app/controllers/crate/version.js

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ export default Ember.Controller.extend({
4040
displayedAuthors: computed('currentVersion.authors.[]', function() {
4141
return DS.PromiseArray.create({
4242
promise: this.get('currentVersion.authors').then((authors) => {
43-
var ret = authors.slice();
44-
var others = authors.get('meta');
45-
for (var i = 0; i < others.names.length; i++) {
43+
let ret = authors.slice();
44+
let others = authors.get('meta');
45+
for (let i = 0; i < others.names.length; i++) {
4646
ret.push({ name: others.names[i] });
4747
}
4848
return ret;
@@ -54,17 +54,17 @@ export default Ember.Controller.extend({
5454
anyCategories: computed.gt('categories.length', 0),
5555

5656
currentDependencies: computed('currentVersion.dependencies', function() {
57-
var deps = this.get('currentVersion.dependencies');
57+
let deps = this.get('currentVersion.dependencies');
5858

5959
if (deps === null) {
6060
return [];
6161
}
6262

6363
return DS.PromiseArray.create({
6464
promise: deps.then((deps) => {
65-
var non_dev = deps.filter((dep) => dep.get('kind') !== 'dev');
66-
var map = {};
67-
var ret = [];
65+
let non_dev = deps.filter((dep) => dep.get('kind') !== 'dev');
66+
let map = {};
67+
let ret = [];
6868

6969
non_dev.forEach((dep) => {
7070
if (!(dep.get('crate_id') in map)) {
@@ -79,7 +79,7 @@ export default Ember.Controller.extend({
7979
}),
8080

8181
currentDevDependencies: computed('currentVersion.dependencies', function() {
82-
var deps = this.get('currentVersion.dependencies');
82+
let deps = this.get('currentVersion.dependencies');
8383
if (deps === null) {
8484
return [];
8585
}
@@ -120,26 +120,26 @@ export default Ember.Controller.extend({
120120

121121
let extra = this.get('extraDownloads') || [];
122122

123-
var dates = {};
124-
var versions = [];
125-
for (var i = 0; i < 90; i++) {
126-
var now = moment().subtract(i, 'days');
123+
let dates = {};
124+
let versions = [];
125+
for (let i = 0; i < 90; i++) {
126+
let now = moment().subtract(i, 'days');
127127
dates[now.format('MMM D')] = { date: now, cnt: {} };
128128
}
129129

130130
downloads.forEach((d) => {
131-
var version_id = d.get('version.id');
132-
var key = moment(d.get('date')).utc().format('MMM D');
131+
let version_id = d.get('version.id');
132+
let key = moment(d.get('date')).utc().format('MMM D');
133133
if (dates[key]) {
134-
var prev = dates[key].cnt[version_id] || 0;
134+
let prev = dates[key].cnt[version_id] || 0;
135135
dates[key].cnt[version_id] = prev + d.get('downloads');
136136
}
137137
});
138138

139139
extra.forEach((d) => {
140-
var key = moment(d.date).utc().format('MMM D');
140+
let key = moment(d.date).utc().format('MMM D');
141141
if (dates[key]) {
142-
var prev = dates[key].cnt[null] || 0;
142+
let prev = dates[key].cnt[null] || 0;
143143
dates[key].cnt[null] = prev + d.downloads;
144144
}
145145
});
@@ -157,15 +157,15 @@ export default Ember.Controller.extend({
157157
});
158158
}
159159

160-
var headers = ['Date'];
160+
let headers = ['Date'];
161161
versions.sort((b) => b.num).reverse();
162-
for (i = 0; i < versions.length; i++) {
162+
for (let i = 0; i < versions.length; i++) {
163163
headers.push(versions[i].num);
164164
}
165-
var data = [headers];
166-
for (var date in dates) {
167-
var row = [dates[date].date.toDate()];
168-
for (i = 0; i < versions.length; i++) {
165+
let data = [headers];
166+
for (let date in dates) {
167+
let row = [dates[date].date.toDate()];
168+
for (let i = 0; i < versions.length; i++) {
169169
row.push(dates[date].cnt[versions[i].id] || 0);
170170
}
171171
data.push(row);

‎app/controllers/dashboard.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ export default Ember.Controller.extend({
3535
actions: {
3636
loadMore() {
3737
this.set('loadingMore', true);
38-
var page = (this.get('myFeed').length / 10) + 1;
38+
let page = (this.get('myFeed').length / 10) + 1;
3939

4040
ajax(`/me/updates?page=${page}`).then((data) => {
41-
var versions = data.versions.map(version =>
41+
let versions = data.versions.map(version =>
4242
this.store.push(this.store.normalize('version', version)));
4343

4444
this.get('myFeed').pushObjects(versions);

‎app/controllers/me/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export default Ember.Controller.extend({
1515
}).then((d) => {
1616
this.get('model').set('api_token', d.api_token);
1717
}).catch((reason) => {
18-
var msg;
18+
let msg;
1919
if (reason.status === 403) {
2020
msg = 'A login is required to perform this action';
2121
} else {

‎app/helpers/format-email.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import Ember from 'ember';
22

3-
var escape = Ember.Handlebars.Utils.escapeExpression;
3+
const escape = Ember.Handlebars.Utils.escapeExpression;
44

55
export function formatEmail(email) {
6-
var formatted = email.match(/^(.*?)\s*(?:<(.*)>)?$/);
7-
var ret = '';
6+
let formatted = email.match(/^(.*?)\s*(?:<(.*)>)?$/);
7+
let ret = '';
88

99
ret += escape(formatted[1]);
1010

‎app/helpers/format-num.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ export function formatNum(value) {
55
return '0';
66
}
77

8-
var ret = '';
9-
var cnt = 0;
8+
let ret = '';
9+
let cnt = 0;
1010
while (value > 0) {
1111
if (cnt > 0 && cnt % 3 === 0) {
1212
ret = `,${ret}`;

‎app/initializers/google.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Ember from 'ember';
22

3-
export var initialize = function() {
3+
export function initialize() {
44
Ember.$.getScript('https://www.google.com/jsapi', function() {
55
window.google.load('visualization', '1.0', {
66
packages: ['corechart'],
@@ -10,7 +10,7 @@ export var initialize = function() {
1010
}
1111
});
1212
});
13-
};
13+
}
1414

1515
export default {
1616
name: 'google',

‎app/mixins/authenticated-route.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Ember from 'ember';
22

33
export default Ember.Mixin.create({
44
beforeModel(transition) {
5-
var user = this.session.get('currentUser');
5+
let user = this.session.get('currentUser');
66
if (user !== null) {
77
return;
88
}

‎app/mixins/pagination.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ export default Ember.Mixin.create({
77

88
// Gives page numbers to the surrounding 9 pages.
99
pages: computed('currentPage', 'availablePages', function() {
10-
var pages = [];
11-
var currentPage = this.get('currentPage');
12-
var availablePages = this.get('availablePages');
13-
var lowerBound = 0;
14-
var upperBound = 0;
10+
let pages = [];
11+
let currentPage = this.get('currentPage');
12+
let availablePages = this.get('availablePages');
13+
let lowerBound = 0;
14+
let upperBound = 0;
1515

1616
// Always show the same number of pages even if we're
1717
// at the beginning or at the end of the list.
@@ -25,7 +25,7 @@ export default Ember.Mixin.create({
2525
lowerBound = currentPage - Math.ceil(VIEWABLE_PAGES / 2);
2626
upperBound = currentPage + Math.floor(VIEWABLE_PAGES / 2);
2727
}
28-
for (var i = lowerBound; i < upperBound; i++) {
28+
for (let i = lowerBound; i < upperBound; i++) {
2929
pages.push(i + 1);
3030
}
3131
return pages;
@@ -48,8 +48,8 @@ export default Ember.Mixin.create({
4848
}),
4949

5050
nextPage: computed('currentPage', 'availablePages', function() {
51-
var nextPage = this.get('currentPage') + 1;
52-
var availablePages = this.get('availablePages');
51+
let nextPage = this.get('currentPage') + 1;
52+
let availablePages = this.get('availablePages');
5353
if (nextPage <= availablePages) {
5454
return nextPage;
5555
} else {
@@ -58,7 +58,7 @@ export default Ember.Mixin.create({
5858
}),
5959

6060
prevPage: computed('currentPage', function() {
61-
var prevPage = this.get('currentPage') - 1;
61+
let prevPage = this.get('currentPage') - 1;
6262
if (prevPage > 0) {
6363
return prevPage;
6464
} else {

‎app/routes/application.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default Ember.Route.extend({
66
if (this.session.get('isLoggedIn') &&
77
this.session.get('currentUser') === null) {
88
ajax('/me').then((response) => {
9-
var user = this.store.push(this.store.normalize('user', response.user));
9+
let user = this.store.push(this.store.normalize('user', response.user));
1010
user.set('api_token', response.api_token);
1111
this.session.set('currentUser', user);
1212
}).catch(() => this.session.logoutUser()).finally(() => {

‎app/routes/crate.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default Ember.Route.extend({
1616
},
1717

1818
setHeadTags(model) {
19-
var headTags = [{
19+
let headTags = [{
2020
type: 'meta',
2121
tagId: 'meta-description-tag',
2222
attrs: {

‎app/routes/crate/docs.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ import Ember from 'ember';
22

33
export default Ember.Route.extend({
44
redirect() {
5-
var crate = this.modelFor('crate');
5+
let crate = this.modelFor('crate');
66

7-
var documentation = crate.get('documentation');
7+
let documentation = crate.get('documentation');
88
if (documentation) {
99
window.location = documentation;
1010
} else {
1111
// Redirect to the crate's main page and show a flash error if
1212
// no documentation is found
13-
var message = 'Crate does not supply a documentation URL';
13+
let message = 'Crate does not supply a documentation URL';
1414
this.controllerFor('application').set('nextFlashError', message);
1515
this.replaceWith('crate', crate);
1616
}

‎app/routes/crate/repo.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ import Ember from 'ember';
22

33
export default Ember.Route.extend({
44
redirect() {
5-
var crate = this.modelFor('crate');
5+
let crate = this.modelFor('crate');
66

7-
var repository = crate.get('repository');
7+
let repository = crate.get('repository');
88
if (repository) {
99
window.location = repository;
1010
} else {
1111
// Redirect to the crate's main page and show a flash error if
1212
// no repository is found
13-
var message = 'Crate does not supply a repository URL';
13+
let message = 'Crate does not supply a repository URL';
1414
this.controllerFor('application').set('nextFlashError', message);
1515
this.replaceWith('crate', crate);
1616
}

‎app/routes/github-authorize.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ import ajax from 'ic-ajax';
1717
export default Ember.Route.extend({
1818
beforeModel(transition) {
1919
return ajax('/authorize', { data: transition.queryParams }).then((d) => {
20-
var item = JSON.stringify({ ok: true, data: d });
20+
let item = JSON.stringify({ ok: true, data: d });
2121
if (window.opener) {
2222
window.opener.github_response = item;
2323
}
2424
}).catch((d) => {
25-
var item = JSON.stringify({ ok: false, data: d });
25+
let item = JSON.stringify({ ok: false, data: d });
2626
if (window.opener) {
2727
window.opener.github_response = item;
2828
}

‎app/routes/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default Ember.Route.extend({
1212

1313
model() {
1414
function addCrates(store, crates) {
15-
for (var i = 0; i < crates.length; i++) {
15+
for (let i = 0; i < crates.length; i++) {
1616
crates[i] = store.push(store.normalize('crate', crates[i]));
1717
}
1818
}

0 commit comments

Comments
 (0)