Make all crate name lookups case insensitive

Author: alexcrichton

src/bin/migrate.rs

@@ -397,6 +397,19 @@ fn migrations() -> Vec<Migration> {
 
         }, proc(_) Ok(())),
         Migration::add_column(20141120162357, "dependencies", "kind", "INTEGER"),
+        Migration::new(20141121191309, proc(tx) {
+            try!(tx.execute("ALTER TABLE crates DROP CONSTRAINT \
+                             packages_name_key", &[]));
+            try!(tx.execute("CREATE UNIQUE INDEX index_crates_name \
+                             ON crates (lower(name))", &[]));
+            Ok(())
+
+        }, proc(tx) {
+            try!(tx.execute("DROP INDEX index_crates_name", &[]));
+            try!(tx.execute("ALTER TABLE crates ADD CONSTRAINT packages_name_key \
+                             UNIQUE (name)", &[]));
+            Ok(())
+        }),
     ];
     // NOTE: Generate a new id via `date +"%Y%m%d%H%M%S"`
 

src/krate.rs

@@ -77,7 +77,7 @@ impl Crate {
 
     pub fn find_by_name(conn: &Connection, name: &str) -> CargoResult<Crate> {
         let stmt = try!(conn.prepare("SELECT * FROM crates \
-                                      WHERE name = $1 LIMIT 1"));
+                                      WHERE lower(name) = lower($1) LIMIT 1"));
         match try!(stmt.query(&[&name as &ToSql])).next() {
             Some(row) => Ok(Model::from_row(&row)),
             None => Err(FromError::from_error(NotFound)),
@@ -114,7 +114,7 @@ impl Crate {
                                              keywords = $5,
                                              license = $6,
                                              repository = $7
-                                       WHERE name = $8
+                                       WHERE lower(name) = lower($8)
                                    RETURNING *"));
         let mut rows = try!(stmt.query(&[&documentation, &homepage,
                                          &description, &readme, &keywords,
@@ -666,7 +666,7 @@ pub fn download(req: &mut Request) -> CargoResult<Response> {
                                 FROM crates
                                 INNER JOIN versions ON
                                     crates.id = versions.crate_id
-                                WHERE crates.name = $1
+                                WHERE lower(crates.name) = lower($1)
                                   AND versions.num = $2
                                 LIMIT 1"));
     let mut rows = try!(stmt.query(&[&crate_name as &ToSql, &version as &ToSql]));

src/tests/krate.rs

@@ -321,6 +321,17 @@ fn new_krate_duplicate_version() {
             "{}", json.errors);
 }
 
+#[test]
+fn new_crate_similar_name() {
+    let (_b, app, middle) = ::app();
+    let mut req = new_req(app, "foo", "1.0.0");
+    ::mock_user(&mut req, ::user("foo"));
+    ::mock_crate(&mut req, ::krate("Foo"));
+    let json = bad_resp!(middle.call(&mut req));
+    assert!(json.errors[0].detail.as_slice().contains("already uploaded"),
+            "{}", json.errors);
+}
+
 #[test]
 fn new_krate_git_upload() {
     let (_b, app, middle) = ::app();
@@ -428,6 +439,15 @@ fn download() {
     let mut resp = ok_resp!(middle.call(&mut req));
     let downloads = ::json::<Downloads>(&mut resp);
     assert_eq!(downloads.version_downloads.len(), 1);
+
+    req.with_path("/api/v1/crates/FOO/1.0.0/download");
+    let resp = t_resp!(middle.call(&mut req));
+    assert_eq!(resp.status.val0(), 302);
+
+    req.with_path("/api/v1/crates/FOO/1.0.0/downloads");
+    let mut resp = ok_resp!(middle.call(&mut req));
+    let downloads = ::json::<Downloads>(&mut resp);
+    assert_eq!(downloads.version_downloads.len(), 1);
 }
 
 #[test]