Skip to content

Commit 1c7a11c

Browse files
committed
Auto merge of #2373 - Turbo87:get, r=locks
Remove unnecessary `this.get()` calls With the newer Ember.js versions this is no longer necessary in the majority of cases 🎉 r? @locks
2 parents 54be6fc + f65bac4 commit 1c7a11c

File tree

9 files changed

+10
-10
lines changed

9 files changed

+10
-10
lines changed

app/components/owned-crate-row.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export default Component.extend({
1313

1414
actions: {
1515
toggleEmailNotifications() {
16-
this.set('emailNotifications', !this.get('emailNotifications'));
16+
this.set('emailNotifications', !this.emailNotifications);
1717
},
1818
},
1919
});

app/controllers/category/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default Controller.extend(PaginationMixin, {
2121
return 'Alphabetical';
2222
} else if (this.sort === 'new') {
2323
return 'Newly Added';
24-
} else if (this.get('sort') === 'recent-updates') {
24+
} else if (this.sort === 'recent-updates') {
2525
return 'Recent Updates';
2626
} else {
2727
return 'Recent Downloads';

app/controllers/crates.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default Controller.extend(PaginationMixin, {
1919
return 'All-Time Downloads';
2020
} else if (this.sort === 'recent-downloads') {
2121
return 'Recent Downloads';
22-
} else if (this.get('sort') === 'recent-updates') {
22+
} else if (this.sort === 'recent-updates') {
2323
return 'Recent Updates';
2424
} else if (this.sort === 'new') {
2525
return 'Newly Added';

app/controllers/keyword/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default Controller.extend(PaginationMixin, {
1919
return 'Alphabetical';
2020
} else if (this.sort === 'new') {
2121
return 'Newly Added';
22-
} else if (this.get('sort') === 'recent-updates') {
22+
} else if (this.sort === 'recent-updates') {
2323
return 'Recent Updates';
2424
} else {
2525
return 'Recent Downloads';

app/controllers/me/crates.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default Controller.extend(PaginationMixin, {
1919
return 'All-Time Downloads';
2020
} else if (this.sort === 'recent-downloads') {
2121
return 'Recent Downloads';
22-
} else if (this.get('sort') === 'recent-updates') {
22+
} else if (this.sort === 'recent-updates') {
2323
return 'Recent Updates';
2424
} else if (this.sort === 'new') {
2525
return 'Newly Added';

app/controllers/search.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export default Controller.extend(PaginationMixin, {
3131
return 'All-Time Downloads';
3232
} else if (this.sort === 'recent-downloads') {
3333
return 'Recent Downloads';
34-
} else if (this.get('sort') === 'recent-updates') {
34+
} else if (this.sort === 'recent-updates') {
3535
return 'Recent Updates';
3636
} else if (this.sort === 'new') {
3737
return 'Newly Added';

app/controllers/team.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export default Controller.extend(PaginationMixin, {
1717
return 'All-Time Downloads';
1818
} else if (this.sort === 'recent-downloads') {
1919
return 'Recent Downloads';
20-
} else if (this.get('sort') === 'recent-updates') {
20+
} else if (this.sort === 'recent-updates') {
2121
return 'Recent Updates';
2222
} else if (this.sort === 'new') {
2323
return 'Newly Added';

app/controllers/user.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export default Controller.extend(PaginationMixin, {
1818
return 'All-Time Downloads';
1919
} else if (this.sort === 'recent-downloads') {
2020
return 'Recent Downloads';
21-
} else if (this.get('sort') === 'recent-updates') {
21+
} else if (this.sort === 'recent-updates') {
2222
return 'Recent Updates';
2323
} else if (this.sort === 'new') {
2424
return 'Newly Added';

app/routes/accept-invite.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ export default Route.extend({
77
try {
88
await ajax(`/api/v1/me/crate_owner_invitations/accept/${params.token}`, { method: 'PUT', body: '{}' });
99
this.set('response', { accepted: true });
10-
return { response: this.get('response') };
10+
return { response: this.response };
1111
} catch (error) {
1212
this.set('response', { accepted: false });
13-
return { response: this.get('response') };
13+
return { response: this.response };
1414
}
1515
},
1616
});

0 commit comments

Comments
 (0)