Move on_call out of the main app

We don't want to require pagerduty for external registries. But making
this code no-op if the environment variables are missing would mean we
don't get informed if things are mis-configured or un-configured.

We aren't expecting this to be called from most code, only a handful of
binaries that are specifically intended to monitor the service. In order
to prevent this code from accidentally getting used throughout the app
(though hopefully nobody is calling a function documented as "wakes up
whoever is on-call" willy nilly), we can move this into the `bin`
directory.

We're specifically using `on_call/mod.rs` instead of `on_call.rs` so
Cargo doesn't think that this file is supposed to be its own binary.

Author: sgrif

src/on_call.rs renamed to src/bin/on_call/mod.rs

@@ -1,7 +1,10 @@
-use reqwest::{self, header, StatusCode as Status};
+extern crate cargo_registry;
+extern crate reqwest;
+
+use self::reqwest::{header, StatusCode as Status};
 use std::env;
 
-use util::*;
+use self::cargo_registry::util::*;
 
 #[derive(Serialize, Debug)]
 #[serde(rename_all = "snake_case", tag = "event_type")]

src/bin/test-pagerduty.rs

@@ -7,11 +7,12 @@
 
 #![deny(warnings)]
 
-extern crate cargo_registry;
+#[macro_use]
+extern crate serde_derive;
 
-use std::env::args;
+mod on_call;
 
-use cargo_registry::on_call;
+use std::env::args;
 
 fn main() {
     let args = args().collect::<Vec<_>>();

src/lib.rs

@@ -69,7 +69,6 @@ pub mod email;
 pub mod git;
 pub mod github;
 pub mod middleware;
-pub mod on_call;
 pub mod render;
 pub mod schema;
 pub mod uploaders;