Avoid cloning app config where possible

Author: jtgeibel

src/app.rs

@@ -44,7 +44,7 @@ impl App {
     /// - GitHub OAuth
     /// - Database connection pools
     /// - A `git2::Repository` instance from the index repo checkout (that server.rs ensures exists)
-    pub fn new(config: &Config, http_client: Option<Client>) -> App {
+    pub fn new(config: Config, http_client: Option<Client>) -> App {
         use oauth2::prelude::*;
         use oauth2::{AuthUrl, ClientId, ClientSecret, Scope, TokenUrl};
         use url::Url;
@@ -126,7 +126,7 @@ impl App {
             read_only_replica_database,
             github,
             session_key: config.session_key.clone(),
-            config: config.clone(),
+            config,
             http_client,
         }
     }

src/bin/server.rs

@@ -27,7 +27,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     let config = cargo_registry::Config::default();
     let client = Client::new();
 
-    let app = App::new(&config, Some(client));
+    let app = App::new(config.clone(), Some(client));
     let app = cargo_registry::build_handler(Arc::new(app));
 
     // On every server restart, ensure the categories available in the database match

src/tests/all.rs

@@ -160,7 +160,7 @@ fn build_app(
         None
     };
 
-    let app = App::new(&config, client);
+    let app = App::new(config, client);
     t!(t!(app.primary_database.get()).begin_test_transaction());
     let app = Arc::new(app);
     let handler = cargo_registry::build_handler(Arc::clone(&app));