Address review comments

Author: jtgeibel

src/tests/badge.rs

@@ -37,10 +37,10 @@ impl BadgeTestCrate {
             .db(|conn| Badge::update_crate(conn, &self.krate, Some(badges)).unwrap())
     }
 
-    /// Update the crate with badges, returning invalid badges
-    fn update_with_none(&self) -> Vec<String> {
+    /// Update the crate to have no badges
+    fn update_with_none(&self) {
         self.app
-            .db(|conn| Badge::update_crate(conn, &self.krate, None).unwrap())
+            .db(|conn| Badge::update_crate(conn, &self.krate, None).unwrap());
     }
 
     /// Return the crate's badges
@@ -382,7 +382,7 @@ fn travis_ci_required_keys() {
 
     let invalid_badges = krate.update(&badges);
     assert_eq!(invalid_badges.len(), 1);
-    assert_eq!(invalid_badges.first().unwrap(), &"travis-ci");
+    assert_eq!(invalid_badges.first().unwrap(), "travis-ci");
     assert_eq!(krate.badges(), vec![]);
 }
 
@@ -399,7 +399,7 @@ fn gitlab_required_keys() {
 
     let invalid_badges = krate.update(&badges);
     assert_eq!(invalid_badges.len(), 1);
-    assert_eq!(invalid_badges.first().unwrap(), &"gitlab");
+    assert_eq!(invalid_badges.first().unwrap(), "gitlab");
     assert_eq!(krate.badges(), vec![]);
 }
 
@@ -423,7 +423,7 @@ fn isitmaintained_issue_resolution_required_keys() {
     assert_eq!(invalid_badges.len(), 1);
     assert_eq!(
         invalid_badges.first().unwrap(),
-        &"isitmaintained_issue_resolution"
+        "isitmaintained_issue_resolution"
     );
     assert_eq!(krate.badges(), vec![]);
 }
@@ -448,7 +448,7 @@ fn isitmaintained_open_issues_required_keys() {
     assert_eq!(invalid_badges.len(), 1);
     assert_eq!(
         invalid_badges.first().unwrap(),
-        &"isitmaintained_open_issues"
+        "isitmaintained_open_issues"
     );
     assert_eq!(krate.badges(), vec![]);
 }
@@ -466,7 +466,7 @@ fn codecov_required_keys() {
 
     let invalid_badges = krate.update(&badges);
     assert_eq!(invalid_badges.len(), 1);
-    assert_eq!(invalid_badges.first().unwrap(), &"codecov");
+    assert_eq!(invalid_badges.first().unwrap(), "codecov");
     assert_eq!(krate.badges(), vec![]);
 }
 
@@ -483,7 +483,7 @@ fn coveralls_required_keys() {
 
     let invalid_badges = krate.update(&badges);
     assert_eq!(invalid_badges.len(), 1);
-    assert_eq!(invalid_badges.first().unwrap(), &"coveralls");
+    assert_eq!(invalid_badges.first().unwrap(), "coveralls");
     assert_eq!(krate.badges(), vec![]);
 }
 
@@ -500,7 +500,7 @@ fn circle_ci_required_keys() {
 
     let invalid_badges = krate.update(&badges);
     assert_eq!(invalid_badges.len(), 1);
-    assert_eq!(invalid_badges.first().unwrap(), &"circle-ci");
+    assert_eq!(invalid_badges.first().unwrap(), "circle-ci");
     assert_eq!(krate.badges(), vec![]);
 }
 
@@ -520,7 +520,7 @@ fn maintenance_required_keys() {
 
     let invalid_badges = krate.update(&badges);
     assert_eq!(invalid_badges.len(), 1);
-    assert_eq!(invalid_badges.first().unwrap(), &"maintenance");
+    assert_eq!(invalid_badges.first().unwrap(), "maintenance");
     assert_eq!(krate.badges(), vec![]);
 }
 
@@ -542,7 +542,7 @@ fn maintenance_invalid_values() {
 
     let invalid_badges = krate.update(&badges);
     assert_eq!(invalid_badges.len(), 1);
-    assert_eq!(invalid_badges.first().unwrap(), &"maintenance");
+    assert_eq!(invalid_badges.first().unwrap(), "maintenance");
     assert_eq!(krate.badges(), vec![]);
 }
 
@@ -563,6 +563,6 @@ fn unknown_badge() {
 
     let invalid_badges = krate.update(&badges);
     assert_eq!(invalid_badges.len(), 1);
-    assert_eq!(invalid_badges.first().unwrap(), &"not-a-badge");
+    assert_eq!(invalid_badges.first().unwrap(), "not-a-badge");
     assert_eq!(krate.badges(), vec![]);
 }