Drop 82 unused Debug impls

Author: jtgeibel

src/admin/delete_crate.rs

@@ -3,7 +3,7 @@ use crate::{admin::dialoguer, db, models::Crate, schema::crates};
 use clap::Clap;
 use diesel::prelude::*;
 
-#[derive(Clap, Debug)]
+#[derive(Clap)]
 #[clap(
     name = "delete-crate",
     about = "Purge all references to a crate from the database.",

src/admin/delete_version.rs

@@ -8,7 +8,7 @@ use crate::{
 use clap::Clap;
 use diesel::prelude::*;
 
-#[derive(Clap, Debug)]
+#[derive(Clap)]
 #[clap(
     name = "delete-version",
     about = "Purge all references to a crate's version from the database.",

src/admin/migrate.rs

@@ -3,7 +3,7 @@ use anyhow::Error;
 static CATEGORIES_TOML: &'static str = include_str!("../boot/categories.toml");
 diesel_migrations::embed_migrations!("./migrations");
 
-#[derive(clap::Clap, Debug, Copy, Clone)]
+#[derive(clap::Clap, Copy, Clone)]
 #[clap(
     name = "migrate",
     about = "Verify config, migrate the database, and other release tasks."

src/admin/on_call.rs

@@ -54,7 +54,7 @@ impl Event {
     }
 }
 
-#[derive(serde::Serialize, Debug)]
+#[derive(serde::Serialize)]
 struct FullEvent {
     service_key: String,
     #[serde(flatten)]

src/admin/populate.rs

@@ -4,7 +4,7 @@ use clap::Clap;
 use diesel::prelude::*;
 use rand::{thread_rng, Rng};
 
-#[derive(Clap, Debug)]
+#[derive(Clap)]
 #[clap(
     name = "populate",
     about = "Populate a set of dummy download statistics for a specific version in the database."

src/admin/render_readmes.rs

@@ -16,7 +16,7 @@ use tar::{self, Archive};
 
 const CACHE_CONTROL_README: &str = "public,max-age=604800";
 
-#[derive(Clap, Debug)]
+#[derive(Clap)]
 #[clap(
     name = "render-readmes",
     about = "Iterates over every crate versions ever uploaded and (re-)renders their \

src/admin/test_pagerduty.rs

@@ -24,7 +24,7 @@ impl FromStr for EventType {
     }
 }
 
-#[derive(Clap, Debug)]
+#[derive(Clap)]
 #[clap(name = "test-pagerduty", about = "Send a test event to pagerduty")]
 pub struct Opts {
     #[clap(possible_values = &["trigger", "acknowledge", "resolve"])]

src/admin/transfer_crates.rs

@@ -9,7 +9,7 @@ use std::process::exit;
 use clap::Clap;
 use diesel::prelude::*;
 
-#[derive(Clap, Debug)]
+#[derive(Clap)]
 #[clap(
     name = "transfer-crates",
     about = "Transfer all crates from one user to another."

src/admin/verify_token.rs

@@ -2,7 +2,7 @@ use crate::{db, models::User, util::errors::AppResult};
 
 use clap::Clap;
 
-#[derive(Clap, Debug)]
+#[derive(Clap)]
 #[clap(
     name = "verify-token",
     about = "Look up a username by API token.",

src/bin/crates-admin.rs

@@ -7,14 +7,14 @@ use cargo_registry::admin::{
 
 use clap::Clap;
 
-#[derive(Clap, Debug)]
+#[derive(Clap)]
 #[clap(name = "crates-admin")]
 struct Opts {
     #[clap(subcommand)]
     command: SubCommand,
 }
 
-#[derive(Clap, Debug)]
+#[derive(Clap)]
 enum SubCommand {
     DeleteCrate(delete_crate::Opts),
     DeleteVersion(delete_version::Opts),

src/boot/categories.rs

@@ -6,7 +6,6 @@ use crate::db;
 use anyhow::{Context, Result};
 use diesel::prelude::*;
 
-#[derive(Debug)]
 struct Category {
     slug: String,
     name: String,

src/config.rs

@@ -1,7 +1,6 @@
 use crate::publish_rate_limit::PublishRateLimit;
 use crate::{env, env_optional, uploaders::Uploader, Env, Replica};
 
-#[derive(Debug)]
 pub struct Config {
     pub uploader: Uploader,
     pub session_key: String,
@@ -28,7 +27,6 @@ pub struct Config {
     pub instance_metrics_log_every_seconds: Option<u64>,
 }
 
-#[derive(Debug)]
 pub struct DbPoolConfig {
     pub url: String,
     pub read_only_mode: bool,

src/controllers/helpers/pagination.rs

@@ -189,7 +189,6 @@ impl<T: 'static> IntoIterator for Paginated<T> {
     }
 }
 
-#[derive(Debug)]
 pub(crate) struct PaginatedQuery<T> {
     query: T,
     options: PaginationOptions,

src/controllers/util.rs

@@ -10,7 +10,6 @@ use crate::util::errors::{
     InsecurelyGeneratedTokenRevoked,
 };
 
-#[derive(Debug)]
 pub struct AuthenticatedUser {
     user: User,
     token_id: Option<i32>,

src/downloads_counter.rs

@@ -22,7 +22,6 @@ use std::sync::atomic::{AtomicI64, AtomicUsize, Ordering};
 /// persisted, so it's possible to lose some of them if the process exits ungracefully. While
 /// that's far from ideal, the advantage of batching database updates far outweights potentially
 /// losing some download counts.
-#[derive(Debug)]
 pub struct DownloadsCounter {
     /// Inner storage for the download counts.
     inner: DashMap<i32, AtomicUsize>,

src/email.rs

@@ -8,7 +8,6 @@ use lettre::transport::smtp::authentication::{Credentials, Mechanism};
 use lettre::transport::smtp::SmtpTransport;
 use lettre::{Message, Transport};
 
-#[derive(Debug)]
 pub struct Emails {
     backend: EmailBackend,
 }

src/git.rs

@@ -52,7 +52,7 @@ impl Credentials {
     }
 }
 
-#[derive(Serialize, Deserialize, Debug)]
+#[derive(Serialize, Deserialize)]
 pub struct Crate {
     pub name: String,
     pub vers: String,
@@ -64,7 +64,7 @@ pub struct Crate {
     pub links: Option<String>,
 }
 
-#[derive(Serialize, Deserialize, Debug)]
+#[derive(Serialize, Deserialize)]
 pub struct Dependency {
     pub name: String,
     pub req: String,

src/github.rs

@@ -10,7 +10,6 @@ use std::str;
 use crate::util::errors::{cargo_err, internal, not_found, AppError, AppResult};
 use reqwest::blocking::Client;
 
-#[derive(Debug)]
 pub struct GitHubClient {
     base_url: String,
     client: Option<Client>,

src/lib.rs

@@ -64,7 +64,7 @@ pub mod views;
 /// The app's `config.env` value is set in *src/bin/server.rs* to `Production` if the environment
 /// variable `HEROKU` is set and `Development` otherwise. `config.env` is set to `Test`
 /// unconditionally in *src/test/all.rs*.
-#[derive(PartialEq, Eq, Clone, Copy, Debug)]
+#[derive(PartialEq, Eq, Clone, Copy)]
 pub enum Env {
     Development,
     Test,
@@ -82,7 +82,7 @@ pub enum Env {
 ///
 /// There may be more ways to run crates.io servers in the future, such as a
 /// mirror that also has private crates that crates.io does not have.
-#[derive(PartialEq, Eq, Clone, Copy, Debug)]
+#[derive(PartialEq, Eq, Clone, Copy)]
 pub enum Replica {
     Primary,
     ReadOnlyMirror,

src/middleware/debug.rs

@@ -2,7 +2,7 @@
 
 use super::prelude::*;
 
-#[derive(Clone, Copy, Debug)]
+#[derive(Clone, Copy)]
 pub struct Debug;
 
 impl Middleware for Debug {
@@ -21,7 +21,7 @@ impl Middleware for Debug {
     }
 }
 
-#[derive(Clone, Copy, Debug)]
+#[derive(Clone, Copy)]
 struct DebugRequest;
 
 impl Middleware for DebugRequest {

src/models/category.rs

@@ -4,7 +4,7 @@ use diesel::{self, *};
 use crate::models::Crate;
 use crate::schema::*;
 
-#[derive(Clone, Identifiable, Queryable, QueryableByName, Debug)]
+#[derive(Clone, Identifiable, Queryable, QueryableByName)]
 #[table_name = "categories"]
 pub struct Category {
     pub id: i32,
@@ -28,7 +28,7 @@ type WithSlugsCaseSensitive<'a> = diesel::dsl::Eq<
 >;
 type BySlugsCaseSensitive<'a> = diesel::dsl::Filter<categories::table, WithSlugsCaseSensitive<'a>>;
 
-#[derive(Associations, Insertable, Identifiable, Debug, Clone, Copy)]
+#[derive(Associations, Insertable, Identifiable, Clone, Copy)]
 #[belongs_to(Category)]
 #[belongs_to(Crate)]
 #[table_name = "crates_categories"]
@@ -138,7 +138,7 @@ impl Category {
 
 /// Struct for inserting categories; only used in tests. Actual categories are inserted
 /// in src/boot/categories.rs.
-#[derive(Insertable, AsChangeset, Default, Debug)]
+#[derive(Insertable, AsChangeset, Default)]
 #[table_name = "categories"]
 pub struct NewCategory<'a> {
     pub category: &'a str,

src/models/crate_owner_invitation.rs

@@ -6,14 +6,13 @@ use crate::models::{CrateOwner, OwnerKind};
 use crate::schema::{crate_owner_invitations, crate_owners, crates};
 use crate::util::errors::{AppResult, OwnershipInvitationExpired};
 
-#[derive(Debug)]
 pub enum NewCrateOwnerInvitationOutcome {
     AlreadyExists,
     InviteCreated { plaintext_token: String },
 }
 
 /// The model representing a row in the `crate_owner_invitations` database table.
-#[derive(Clone, Debug, PartialEq, Eq, Identifiable, Queryable)]
+#[derive(Clone, PartialEq, Eq, Identifiable, Queryable)]
 #[primary_key(invited_user_id, crate_id)]
 pub struct CrateOwnerInvitation {
     pub invited_user_id: i32,
@@ -32,7 +31,7 @@ impl CrateOwnerInvitation {
         conn: &PgConnection,
         config: &Config,
     ) -> AppResult<NewCrateOwnerInvitationOutcome> {
-        #[derive(Insertable, Clone, Copy, Debug)]
+        #[derive(Insertable, Clone, Copy)]
         #[table_name = "crate_owner_invitations"]
         struct NewRecord {
             invited_user_id: i32,

src/models/download.rs

@@ -2,7 +2,7 @@ use crate::models::Version;
 use crate::schema::version_downloads;
 use chrono::NaiveDate;
 
-#[derive(Queryable, Identifiable, Associations, Debug, Clone, Copy)]
+#[derive(Queryable, Identifiable, Associations, Clone, Copy)]
 #[belongs_to(Version)]
 #[primary_key(version_id, date)]
 pub struct VersionDownload {

src/models/follow.rs

@@ -1,7 +1,7 @@
 use crate::models::User;
 use crate::schema::follows;
 
-#[derive(Insertable, Queryable, Identifiable, Associations, Clone, Copy, Debug)]
+#[derive(Insertable, Queryable, Identifiable, Associations, Clone, Copy)]
 #[belongs_to(User)]
 #[primary_key(user_id, crate_id)]
 #[table_name = "follows"]

src/models/helpers/with_count.rs

@@ -1,4 +1,4 @@
-#[derive(QueryableByName, Queryable, Debug)]
+#[derive(QueryableByName, Queryable)]
 pub struct WithCount<T> {
     #[diesel(embed)]
     pub(crate) record: T,

src/models/keyword.rs

@@ -4,15 +4,15 @@ use diesel::prelude::*;
 use crate::models::Crate;
 use crate::schema::*;
 
-#[derive(Clone, Identifiable, Queryable, Debug)]
+#[derive(Clone, Identifiable, Queryable)]
 pub struct Keyword {
     pub id: i32,
     pub keyword: String,
     pub crates_cnt: i32,
     pub created_at: NaiveDateTime,
 }
 
-#[derive(Associations, Insertable, Identifiable, Debug, Clone, Copy)]
+#[derive(Associations, Insertable, Identifiable, Clone, Copy)]
 #[belongs_to(Keyword)]
 #[belongs_to(Crate)]
 #[table_name = "crates_keywords"]

src/models/krate.rs

@@ -78,7 +78,7 @@ type WithName<'a> = diesel::dsl::Eq<CanonCrateName<crates::name>, CanonCrateName
 type ByName<'a> = diesel::dsl::Filter<All, WithName<'a>>;
 type ByExactName<'a> = diesel::dsl::Filter<All, diesel::dsl::Eq<crates::name, &'a str>>;
 
-#[derive(Insertable, AsChangeset, Default, Debug)]
+#[derive(Insertable, AsChangeset, Default)]
 #[table_name = "crates"]
 #[changeset_options(treat_none_as_null = "true")]
 #[primary_key(name, max_upload_size)] // This is actually just to skip updating them

src/models/owner.rs

@@ -7,7 +7,7 @@ use crate::util::errors::{cargo_err, AppResult};
 use crate::models::{Crate, Team, User};
 use crate::schema::{crate_owners, users};
 
-#[derive(Insertable, Associations, Identifiable, Debug, Clone, Copy)]
+#[derive(Insertable, Associations, Identifiable, Clone, Copy)]
 #[belongs_to(Crate)]
 #[belongs_to(User, foreign_key = "owner_id")]
 #[belongs_to(Team, foreign_key = "owner_id")]
@@ -44,7 +44,6 @@ pub enum OwnerKind {
 }
 
 /// Unifies the notion of a User or a Team.
-#[derive(Debug)]
 pub enum Owner {
     User(User),
     Team(Team),

src/models/rights.rs

@@ -1,6 +1,6 @@
 /// Access rights to the crate (publishing and ownership management)
 /// NOTE: The order of these variants matters!
-#[derive(PartialEq, Eq, PartialOrd, Ord, Debug, Clone, Copy)]
+#[derive(PartialEq, Eq, PartialOrd, Ord, Clone, Copy)]
 pub enum Rights {
     None,
     Publish,

src/models/team.rs

@@ -10,7 +10,7 @@ use crate::schema::{crate_owners, teams};
 
 /// For now, just a Github Team. Can be upgraded to other teams
 /// later if desirable.
-#[derive(Queryable, Identifiable, Serialize, Deserialize, Debug)]
+#[derive(Queryable, Identifiable, Serialize, Deserialize)]
 pub struct Team {
     /// Unique table id
     pub id: i32,
@@ -29,7 +29,7 @@ pub struct Team {
     pub org_id: Option<i32>,
 }
 
-#[derive(Insertable, AsChangeset, Debug)]
+#[derive(Insertable, AsChangeset)]
 #[table_name = "teams"]
 pub struct NewTeam<'a> {
     pub login: &'a str,

src/models/user.rs

@@ -23,7 +23,7 @@ pub struct User {
 }
 
 /// Represents a new user record insertable to the `users` table
-#[derive(Insertable, Debug, Default)]
+#[derive(Insertable, Default)]
 #[table_name = "users"]
 pub struct NewUser<'a> {
     pub gh_id: i32,

src/models/version.rs

@@ -9,7 +9,7 @@ use crate::models::{Crate, Dependency, User};
 use crate::schema::*;
 
 // Queryable has a custom implementation below
-#[derive(Clone, Identifiable, Associations, Debug, Queryable, Deserialize, Serialize)]
+#[derive(Clone, Identifiable, Associations, Queryable, Deserialize, Serialize)]
 #[belongs_to(Crate)]
 pub struct Version {
     pub id: i32,
@@ -25,7 +25,7 @@ pub struct Version {
     pub published_by: Option<i32>,
 }
 
-#[derive(Insertable, Debug)]
+#[derive(Insertable)]
 #[table_name = "versions"]
 pub struct NewVersion {
     crate_id: i32,

src/s3/lib.rs

@@ -11,7 +11,7 @@ use std::time::Duration;
 
 pub use reqwest::Error;
 
-#[derive(Clone, Debug)]
+#[derive(Clone)]
 pub struct Bucket {
     name: String,
     region: Option<String>,