remove duplication of log print, by printing empty metadata_length string if none has been added to request extensions

Author: smokytheangel0

src/middleware/log_request.rs

@@ -31,37 +31,26 @@ impl Handler for LogRequests {
         let response_time =
             response_time.as_secs() * 1000 + u64::from(response_time.subsec_nanos()) / 1_000_000;
 
-        if let Some(metadata_length) = req.mut_extensions().pop::<u64>() {
-            print!(
-                "at={level} method={method} path=\"{path}\" \
-                 request_id={request_id} fwd=\"{ip}\" service={time_ms}ms \
-                 status={status} user_agent=\"{user_agent}\"\
-                 metadata_length={metadata_length}",
-                level = level,
-                method = req.method(),
-                path = FullPath(req),
-                ip = request_header(req, "X-Real-Ip"),
-                time_ms = response_time,
-                user_agent = request_header(req, "User-Agent"),
-                request_id = request_header(req, "X-Request-Id"),
-                status = response_code,
-                metadata_length = metadata_length,
-            );
-        } else {
-            print!(
-                "at={level} method={method} path=\"{path}\" \
-                 request_id={request_id} fwd=\"{ip}\" service={time_ms}ms \
-                 status={status} user_agent=\"{user_agent}\"",
-                level = level,
-                method = req.method(),
-                path = FullPath(req),
-                ip = request_header(req, "X-Real-Ip"),
-                time_ms = response_time,
-                user_agent = request_header(req, "User-Agent"),
-                request_id = request_header(req, "X-Request-Id"),
-                status = response_code,
-            );
-        }
+        let metadata_length = req
+            .extensions()
+            .find::<u64>()
+            .map_or(String::new(), |l| format!(" metadata_length={}", l));
+
+        print!(
+            "at={level} method={method} path=\"{path}\" \
+             request_id={request_id} fwd=\"{ip}\" service={time_ms}ms \
+             status={status} user_agent=\"{user_agent}\"\
+             metadata_length={metadata_length}",
+            level = level,
+            method = req.method(),
+            path = FullPath(req),
+            ip = request_header(req, "X-Real-Ip"),
+            time_ms = response_time,
+            user_agent = request_header(req, "User-Agent"),
+            request_id = request_header(req, "X-Request-Id"),
+            status = response_code,
+            metadata_length = metadata_length,
+        );
 
         if let Err(ref e) = res {
             print!(" error=\"{}\"", e.description());