Auto merge of #5170 - Turbo87:header-icons, r=pichfl

bors · bors · commit 3c7336e495b1 · 2022-09-01T08:23:17.000Z
Remove icons from page headers These icons are not particularly pretty and don't really serve a purpose. Let's remove them to make room for something better and more consistent :) ### Before <img width="1043" alt="Bildschirmfoto 2022-09-01 um 10 19 43" src="https://user-images.githubusercontent.com/141300/187867218-6bf071e8-168b-461f-bce2-e1c5a7e0b861.png"> ### After <img width="1083" alt="Bildschirmfoto 2022-09-01 um 10 19 54" src="https://user-images.githubusercontent.com/141300/187867226-6f13ecea-d84a-4077-bac7-b5a898bd1135.png">
diff --git a/app/components/crate-header.hbs b/app/components/crate-header.hbs
@@ -1,7 +1,6 @@
 <PageHeader local-class="header" data-test-heading>
   <div local-class="header-row">
     <div local-class="heading">
-      {{svg-jar "crate" local-class="crate-icon"}}
       <h1 data-test-crate-name>{{@crate.name}}</h1>
       {{#if @version}}
         <h2 data-test-crate-version>{{@version.num}}</h2>
diff --git a/app/components/crate-header.module.css b/app/components/crate-header.module.css
@@ -27,13 +27,6 @@
     }
 }
 
-.crate-icon {
-    flex-shrink: 0;
-    margin-right: 10px;
-    width: 32px;
-    height: 32px;
-}
-
 .description {
     margin-top: 15px;
     line-height: 1.35;
diff --git a/app/components/page-header.hbs b/app/components/page-header.hbs
@@ -3,7 +3,6 @@
     {{yield}}
   {{else}}
     <h1 local-class="heading">
-      {{svg-jar (or @icon "crate") local-class="icon"}}
       {{@title}}
       {{#if @suffix}}
         <small local-class="suffix">{{@suffix}}</small>
diff --git a/app/components/page-header.module.css b/app/components/page-header.module.css
@@ -11,13 +11,6 @@
     margin: 0;
 }
 
-.icon {
-    flex-shrink: 0;
-    margin-right: 10px;
-    width: 32px;
-    height: 32px;
-}
-
 .suffix {
     color: var(--main-color-light);
     padding-left: 10px;
diff --git a/app/templates/category/index.hbs b/app/templates/category/index.hbs
@@ -1,7 +1,6 @@
 {{page-title this.category.category ' - Categories'}}
 
 <PageHeader local-class="header">
-  <LinkTo @route="categories" aria-label="Categories">{{svg-jar "crate"}}</LinkTo>
   <h1>
     {{#each this.category.parent_categories as |parent|}}<LinkTo @route="category" @model={{parent.slug}}>{{parent.category}}</LinkTo>::{{/each}}
     {{~ this.category.category }}
diff --git a/app/templates/crate/docs.hbs b/app/templates/crate/docs.hbs
@@ -1,5 +1,4 @@
 <div id="crates-heading">
-  {{svg-jar "circle-with-i"}}
   <h1>Documentation for <em>{{this.model.name}}</em></h1>
 </div>
 
diff --git a/app/templates/dashboard.hbs b/app/templates/dashboard.hbs
@@ -1,7 +1,6 @@
 {{page-title 'Dashboard'}}
 
 <PageHeader local-class="header">
-  {{svg-jar "dashboard" local-class="header-icon"}}
   <h1>My Dashboard</h1>
   <div local-class="stats">
     <div local-class='downloads'>
diff --git a/app/templates/data-access.hbs b/app/templates/data-access.hbs
@@ -1,4 +1,4 @@
-<PageHeader @title="Accessing the Crates.io Data" @icon="circle-with-i"/>
+<PageHeader @title="Accessing the Crates.io Data" />
 
 <p>
   There are several ways of accessing the Crates.io data. You should try the
diff --git a/app/templates/install.hbs b/app/templates/install.hbs
@@ -1,4 +1,4 @@
-<PageHeader @title="Install Cargo" @icon="download"/>
+<PageHeader @title="Install Cargo" />
 
 <p>
   Redirecting you to <code>https://doc.rust-lang.org/cargo/getting-started/installation.html</code>&#8230;
diff --git a/app/templates/me/pending-invites.hbs b/app/templates/me/pending-invites.hbs
@@ -1,6 +1,6 @@
 {{page-title 'Pending Invites'}}
 
-<PageHeader @title="Pending Owner Invites" @icon="gear"/>
+<PageHeader @title="Pending Owner Invites" />
 
 <div local-class="list">
   {{#each this.model as |invite|}}
diff --git a/app/templates/policies.hbs b/app/templates/policies.hbs
@@ -1,4 +1,4 @@
-<PageHeader @title="Crates.io Package Policies" @icon="circle-with-i"/>
+<PageHeader @title="Crates.io Package Policies" />
 
 <p>
   In general, these policies are guidelines. Problems are often contextual, and
diff --git a/app/templates/search.hbs b/app/templates/search.hbs
@@ -3,7 +3,6 @@
 <PageHeader
   @title="Search Results"
   @suffix={{if this.q (concat "for '" this.q "'")}}
-  @icon="magnifier"
   @showSpinner={{this.dataTask.isRunning}}
   data-test-header
 />
diff --git a/app/templates/settings/appearance.hbs b/app/templates/settings/appearance.hbs
@@ -1,6 +1,6 @@
 {{page-title 'Settings'}}
 
-<PageHeader @title="Account Settings" @icon="gear"/>
+<PageHeader @title="Account Settings" />
 
 <SettingsPage>
   <h2>Appearance</h2>
diff --git a/app/templates/settings/email-notifications.hbs b/app/templates/settings/email-notifications.hbs
@@ -1,6 +1,6 @@
 {{page-title 'Settings'}}
 
-<PageHeader @title="Account Settings" @icon="gear"/>
+<PageHeader @title="Account Settings" />
 
 <SettingsPage>
   <form local-class="me-email-notifications" {{on "submit" (prevent-default this.saveEmailNotifications)}} >
diff --git a/app/templates/settings/profile.hbs b/app/templates/settings/profile.hbs
@@ -1,6 +1,6 @@
 {{page-title 'Settings'}}
 
-<PageHeader @title="Account Settings" @icon="gear"/>
+<PageHeader @title="Account Settings" />
 
 <SettingsPage>
   <div local-class='me-profile'>
diff --git a/app/templates/settings/tokens.hbs b/app/templates/settings/tokens.hbs
@@ -1,6 +1,6 @@
 {{page-title 'Settings'}}
 
-<PageHeader @title="Account Settings" @icon="gear"/>
+<PageHeader @title="Account Settings" />
 
 <SettingsPage>
   <Settings::ApiTokens @tokens={{@model}} />
diff --git a/public/assets/circle-with-i.svg b/public/assets/circle-with-i.svg
diff --git a/public/assets/dashboard.svg b/public/assets/dashboard.svg
diff --git a/public/assets/gear.svg b/public/assets/gear.svg
diff --git a/public/assets/magnifier.svg b/public/assets/magnifier.svg

Original file line number	Diff line number	Diff line change
`@@ -27,13 +27,6 @@`
`27`	`27`	`}`
`28`	`28`	`}`
`29`	`29`
`30`		`-.crate-icon {`
`31`		`- flex-shrink: 0;`
`32`		`- margin-right: 10px;`
`33`		`- width: 32px;`
`34`		`- height: 32px;`
`35`		`-}`
`36`		`-`
`37`	`30`	`.description {`
`38`	`31`	`margin-top: 15px;`
`39`	`32`	`line-height: 1.35;`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`<div id="crates-heading">`
`2`		`- {{svg-jar "circle-with-i"}}`
`3`	`2`	`<h1>Documentation for <em>{{this.model.name}}</em></h1>`
`4`	`3`	`</div>`
`5`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<PageHeader @title="Accessing the Crates.io Data" @icon="circle-with-i"/>`
	`1`	`+<PageHeader @title="Accessing the Crates.io Data" />`
`2`	`2`
`3`	`3`	`<p>`
`4`	`4`	`There are several ways of accessing the Crates.io data. You should try the`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<PageHeader @title="Install Cargo" @icon="download"/>`
	`1`	`+<PageHeader @title="Install Cargo" />`
`2`	`2`
`3`	`3`	`<p>`
`4`	`4`	`Redirecting you to <code>https://doc.rust-lang.org/cargo/getting-started/installation.html</code>…`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<PageHeader @title="Crates.io Package Policies" @icon="circle-with-i"/>`
	`1`	`+<PageHeader @title="Crates.io Package Policies" />`
`2`	`2`
`3`	`3`	`<p>`
`4`	`4`	`In general, these policies are guidelines. Problems are often contextual, and`