Auto merge of #2375 - Turbo87:redundante-prop, r=locks

dashboard: Remove redundant `visibleStats` property

and enable ESLint rule that prevents it in the future :)

r? @locks

Author: bors

.eslintrc.js

@@ -19,7 +19,6 @@ module.exports = {
     'ember/no-empty-attrs': 'off',
     'ember/no-get': 'off',
     'ember/no-mixins': 'off',
-    'ember/require-computed-macros': 'off',
     'ember/require-computed-property-dependencies': 'off',
   },
   overrides: [

app/controllers/dashboard.js

@@ -26,10 +26,6 @@ export default Controller.extend({
     return this.myFollowing.slice(0, TO_SHOW);
   }),
 
-  visibleStats: computed('myStats', function () {
-    return this.myStats;
-  }),
-
   hasMoreCrates: computed('myCrates.[]', function () {
     return this.get('myCrates.length') > TO_SHOW;
   }),

app/templates/dashboard.hbs

@@ -6,7 +6,7 @@
   <div local-class="stats">
     <div local-class='downloads'>
       <img src="/assets/download.svg">
-      <span local-class='num'>{{format-num this.visibleStats.total_downloads}}</span>
+      <span local-class='num'>{{format-num this.myStats.total_downloads}}</span>
       <span local-class="stats-label">Total Downloads</span>
     </div>
   </div>