Skip to content

Commit 44472fc

Browse files
committed
crate.version: Remove unnecessary readme observer
1 parent d84e99d commit 44472fc

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

app/controllers/crate/version.js

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ import { inject as service } from '@ember/service';
33
import Controller from '@ember/controller';
44
import PromiseProxyMixin from '@ember/object/promise-proxy-mixin';
55
import ArrayProxy from '@ember/array/proxy';
6-
// eslint-disable-next-line ember/no-observers
7-
import { computed, observer } from '@ember/object';
6+
import { computed } from '@ember/object';
87
import moment from 'moment';
98

109
const NUM_VERSIONS = 5;
@@ -163,6 +162,14 @@ export default Controller.extend({
163162
let r = await fetch(this.currentVersion.get('readme_path'));
164163
if (r.ok) {
165164
this.crate.set('readme', await r.text());
165+
166+
if (typeof document !== 'undefined') {
167+
setTimeout(() => {
168+
let e = document.createEvent('CustomEvent');
169+
e.initCustomEvent('hashchange', true, true);
170+
window.dispatchEvent(e);
171+
});
172+
}
166173
} else {
167174
this.crate.set('readme', null);
168175
}
@@ -171,16 +178,4 @@ export default Controller.extend({
171178
}
172179
}
173180
},
174-
175-
// eslint-disable-next-line ember/no-observers
176-
report: observer('crate.readme', function () {
177-
if (typeof document === 'undefined') {
178-
return;
179-
}
180-
setTimeout(() => {
181-
let e = document.createEvent('CustomEvent');
182-
e.initCustomEvent('hashchange', true, true);
183-
window.dispatchEvent(e);
184-
});
185-
}),
186181
});

0 commit comments

Comments
 (0)