Skip to content

Commit 45fc81b

Browse files
committed
Use "ember-native-dom-helpers" for simulated user actions
1 parent a3e5db1 commit 45fc81b

File tree

8 files changed

+18
-24
lines changed

8 files changed

+18
-24
lines changed

tests/acceptance/categories-test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { test } from 'qunit';
2+
import { visit } from 'ember-native-dom-helpers';
23
import moduleForAcceptance from 'cargo/tests/helpers/module-for-acceptance';
34

45
moduleForAcceptance('Acceptance | categories');

tests/acceptance/crate-test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { test } from 'qunit';
2+
import { click, visit, currentURL, currentRouteName } from 'ember-native-dom-helpers';
23
import moduleForAcceptance from 'cargo/tests/helpers/module-for-acceptance';
34

45
moduleForAcceptance('Acceptance | crate page');

tests/acceptance/crates-test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { test } from 'qunit';
2+
import { click, visit, currentURL } from 'ember-native-dom-helpers';
23
import moduleForAcceptance from 'cargo/tests/helpers/module-for-acceptance';
34

45
moduleForAcceptance('Acceptance | crates page');

tests/acceptance/front-page-test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { test } from 'qunit';
2+
import { visit, currentURL } from 'ember-native-dom-helpers';
23
import moduleForAcceptance from 'cargo/tests/helpers/module-for-acceptance';
34

45
moduleForAcceptance('Acceptance | front page');

tests/acceptance/keyword-test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { test } from 'qunit';
2+
import { visit } from 'ember-native-dom-helpers';
23
import moduleForAcceptance from 'cargo/tests/helpers/module-for-acceptance';
34

45
moduleForAcceptance('Acceptance | keywords');

tests/acceptance/search-test.js

Lines changed: 11 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { test } from 'qunit';
2+
import { fillIn, keyEvent, visit, triggerEvent, currentURL, blur } from 'ember-native-dom-helpers';
23
import moduleForAcceptance from 'cargo/tests/helpers/module-for-acceptance';
34

45
moduleForAcceptance('Acceptance | search');
@@ -8,10 +9,7 @@ test('searching for "rust"', async function(assert) {
89

910
await visit('/');
1011
await fillIn('[data-test-search-input]', 'rust');
11-
12-
findWithAssert('[data-test-search-form]').submit();
13-
14-
await wait();
12+
await triggerEvent('[data-test-search-form]', 'submit');
1513

1614
assert.equal(currentURL(), '/search?q=rust');
1715
assert.equal(document.title, 'Search Results for \'rust\' - Cargo: packages for Rust');
@@ -31,38 +29,27 @@ test('searching for "rust"', async function(assert) {
3129
test('pressing S key to focus the search bar', async function(assert) {
3230
server.loadFixtures();
3331

34-
const KEYCODE_S = 83;
35-
const KEYCODE_A = 65;
36-
37-
function assertSearchBarIsFocused() {
38-
assert.dom('[data-test-search-input]').isFocused();
39-
find('[data-test-search-input]').blur();
40-
}
41-
4232
await visit('/');
4333

44-
findWithAssert('[data-test-search-input]').blur();
45-
46-
await keyEvent(document, 'keypress', KEYCODE_A);
34+
await blur('[data-test-search-input]');
35+
await keyEvent(document, 'keypress', 'a');
4736
assert.dom('[data-test-search-input]').isNotFocused();
48-
find('[data-test-search-input]').blur();
4937

50-
await keyEvent(document, 'keypress', KEYCODE_S);
51-
assertSearchBarIsFocused();
38+
await blur('[data-test-search-input]');
39+
await keyEvent(document, 'keypress', 's');
40+
assert.dom('[data-test-search-input]').isFocused();
5241

53-
await keyEvent(document, 'keydown', KEYCODE_S);
54-
assertSearchBarIsFocused();
42+
await blur('[data-test-search-input]');
43+
await keyEvent(document, 'keydown', 's');
44+
assert.dom('[data-test-search-input]').isFocused();
5545
});
5646

5747
test('check search results are by default displayed by relevance', async function(assert) {
5848
server.loadFixtures();
5949

6050
await visit('/');
6151
await fillIn('[data-test-search-input]', 'rust');
62-
63-
findWithAssert('[data-test-search-form]').submit();
64-
65-
await wait();
52+
await triggerEvent('[data-test-search-form]', 'submit');
6653

6754
assert.dom('[data-test-search-sort] [data-test-current-order]').hasText('Relevance');
6855
});

tests/acceptance/team-page-test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { test } from 'qunit';
2+
import { visit } from 'ember-native-dom-helpers';
23
import moduleForAcceptance from 'cargo/tests/helpers/module-for-acceptance';
34

45
moduleForAcceptance('Acceptance | team page');

tests/acceptance/user-page-test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { test } from 'qunit';
2+
import { visit } from 'ember-native-dom-helpers';
23
import moduleForAcceptance from 'cargo/tests/helpers/module-for-acceptance';
34

45
moduleForAcceptance('Acceptance | user page');

0 commit comments

Comments
 (0)