Skip to content

Commit 4eb4e2e

Browse files
committed
Auto merge of #2473 - Turbo87:pretty-bytes, r=locks
Replace custom `format-crate-size` helper with `pretty-bytes` dependency see https://github.com/sindresorhus/pretty-bytes r? @locks
2 parents 3fe74e8 + 43ec2f8 commit 4eb4e2e

File tree

6 files changed

+13
-34
lines changed

6 files changed

+13
-34
lines changed

app/helpers/format-crate-size.js

Lines changed: 0 additions & 11 deletions
This file was deleted.

app/helpers/pretty-bytes.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { helper } from '@ember/component/helper';
2+
3+
import prettyBytes from 'pretty-bytes';
4+
5+
export default helper(([bytes], options) => prettyBytes(bytes, options));

app/templates/crate/version.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
{{#if this.currentVersion.crate_size}}
8282
<div>
8383
<div local-class='crate-size'>Crate Size</div>
84-
<div local-class='size'>{{format-crate-size this.currentVersion.crate_size}}</div>
84+
<div local-class='size'>{{pretty-bytes this.currentVersion.crate_size}}</div>
8585
</div>
8686
{{/if}}
8787

package-lock.json

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@
3838
},
3939
"dependencies": {
4040
"fastboot-app-server": "^2.0.0",
41-
"morgan": "^1.10.0"
41+
"morgan": "^1.10.0",
42+
"pretty-bytes": "^5.3.0"
4243
},
4344
"devDependencies": {
4445
"@ember/optional-features": "^1.3.0",

tests/unit/helpers/format-crate-size-test.js

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)