mirage: Replace ember-cli-mirage with direct miragejs usage

Author: Turbo87

.eslintrc.js

@@ -109,7 +109,7 @@ module.exports = {
 
     // mirage files
     {
-      files: ['mirage/**/*.js'],
+      files: ['tests/mirage/**/*.js'],
       rules: {
         // disabled because of different `.find()` meaning
         'unicorn/no-array-callback-reference': 'off',

.github/workflows/ci.yml

@@ -39,7 +39,6 @@ jobs:
           files_ignore: |
             app/**
             e2e/**
-            mirage/**
             public/**
             tests/**
             .eslintrc

config/environment.js

@@ -63,8 +63,6 @@ module.exports = function (environment) {
 
   if (environment === 'production') {
     // here you can enable a production-specific feature
-    delete ENV['ember-cli-mirage'];
-
     ENV.sentry = {
       dsn: process.env.SENTRY_DSN_WEB,
     };

docs/ARCHITECTURE.md

@@ -87,7 +87,6 @@
     "ember-cli-head": "2.0.0",
     "ember-cli-htmlbars": "6.3.0",
     "ember-cli-inject-live-reload": "2.1.0",
-    "ember-cli-mirage": "3.0.4",
     "ember-cli-notifications": "9.1.0",
     "ember-click-outside": "6.1.1",
     "ember-concurrency": "4.0.2",
@@ -98,6 +97,7 @@
     "ember-event-helpers": "0.1.1",
     "ember-exam": "9.0.0",
     "ember-fetch": "8.1.2",
+    "ember-inflector": "5.0.2",
     "ember-keyboard": "9.0.1",
     "ember-link": "3.3.0",
     "ember-load-initializers": "3.0.1",
@@ -142,8 +142,7 @@
     "ember-get-config": "2.1.1",
     "ember-inflector": "5.0.2",
     "ember-modifier": "4.2.0",
-    "ember-svg-jar>cheerio": "1.0.0-rc.12",
-    "miragejs": "0.1.48"
+    "ember-svg-jar>cheerio": "1.0.0-rc.12"
   },
   "pnpm": {
     "peerDependencyRules": {

package.json

@@ -9,8 +9,8 @@ import { getPageTitle } from 'ember-page-title/test-support';
 
 import { setupApplicationTest } from 'crates-io/tests/helpers';
 
-import { summary } from '../../mirage/route-handlers/summary';
 import axeConfig from '../axe-config';
+import { summary } from '../mirage/route-handlers/summary';
 
 module('Acceptance | front page', function (hooks) {
   setupApplicationTest(hooks);

pnpm-lock.yaml

@@ -10,8 +10,8 @@ import { getPageTitle } from 'ember-page-title/test-support';
 
 import { setupApplicationTest } from 'crates-io/tests/helpers';
 
-import { list as listCrates } from '../../mirage/route-handlers/crates';
 import axeConfig from '../axe-config';
+import { list as listCrates } from '../mirage/route-handlers/crates';
 
 module('Acceptance | search', function (hooks) {
   setupApplicationTest(hooks);

tests/acceptance/front-page-test.js

@@ -1,19 +1,37 @@
-import { setupMirage } from 'ember-cli-mirage/test-support';
+import { settled } from '@ember/test-helpers';
+
 import window from 'ember-window-mock';
 import { setupWindowMock } from 'ember-window-mock/test-support';
 
+import makeServer from '../mirage/config';
 import { setupFakeTimers } from './fake-timers';
 
 export default function (hooks) {
-  setupMirage(hooks);
   setupWindowMock(hooks);
   setupFakeTimers(hooks, '2017-11-20T12:00:00');
 
   // To have deterministic visual tests, the seed has to be constant
   hooks.beforeEach(function () {
+    this.server = makeServer({
+      environment: 'test',
+    });
+
+    if (location.search.includes('mirageLogging')) {
+      this.server.logging = true;
+    }
+
     this.authenticateAs = user => {
       this.server.create('mirage-session', { user });
       window.localStorage.setItem('isLoggedIn', '1');
     };
   });
+
+  hooks.afterEach(async function () {
+    await settled();
+
+    if (this.server) {
+      this.server.shutdown();
+      delete this.server;
+    }
+  });
 }

tests/acceptance/search-test.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../helpers';
-import setupMirage from '../../helpers/setup-mirage';
+import { setupTest } from '../../../helpers';
+import setupMirage from '../../../helpers/setup-mirage';
 
 module('Mirage | GET /api/v1/categories/:id', function (hooks) {
   setupTest(hooks);

tests/helpers/setup-mirage.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../helpers';
-import setupMirage from '../../helpers/setup-mirage';
+import { setupTest } from '../../../helpers';
+import setupMirage from '../../../helpers/setup-mirage';
 
 module('Mirage | GET /api/v1/categories', function (hooks) {
   setupTest(hooks);

mirage/config.js renamed to tests/mirage/config.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../helpers';
-import setupMirage from '../../helpers/setup-mirage';
+import { setupTest } from '../../../helpers';
+import setupMirage from '../../../helpers/setup-mirage';
 
 module('Mirage | GET /api/v1/category_slugs', function (hooks) {
   setupTest(hooks);

mirage/factories/api-token.js renamed to tests/mirage/factories/api-token.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../helpers';
-import setupMirage from '../../helpers/setup-mirage';
+import { setupTest } from '../../../helpers';
+import setupMirage from '../../../helpers/setup-mirage';
 
 module('Mirage | PUT /api/v1/confirm/:token', function (hooks) {
   setupTest(hooks);

mirage/factories/category.js renamed to tests/mirage/factories/category.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../helpers';
-import setupMirage from '../../helpers/setup-mirage';
+import { setupTest } from '../../../helpers';
+import setupMirage from '../../../helpers/setup-mirage';
 
 const ADD_USER_BODY = JSON.stringify({ owners: ['john-doe'] });
 

mirage/factories/crate-owner-invitation.js renamed to tests/mirage/factories/crate-owner-invitation.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../helpers';
-import setupMirage from '../../helpers/setup-mirage';
+import { setupTest } from '../../../helpers';
+import setupMirage from '../../../helpers/setup-mirage';
 
 module('Mirage | DELETE /api/v1/crates/:name', function (hooks) {
   setupTest(hooks);

mirage/factories/crate-ownership.js renamed to tests/mirage/factories/crate-ownership.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../helpers';
-import setupMirage from '../../helpers/setup-mirage';
+import { setupTest } from '../../../helpers';
+import setupMirage from '../../../helpers/setup-mirage';
 
 module('Mirage | GET /api/v1/crates/:id/downloads', function (hooks) {
   setupTest(hooks);

mirage/factories/crate.js renamed to tests/mirage/factories/crate.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../../helpers';
-import setupMirage from '../../../helpers/setup-mirage';
+import { setupTest } from '../../../../helpers';
+import setupMirage from '../../../../helpers/setup-mirage';
 
 module('Mirage | DELETE /api/v1/crates/:crateId/follow', function (hooks) {
   setupTest(hooks);

mirage/factories/dependency.js renamed to tests/mirage/factories/dependency.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../../helpers';
-import setupMirage from '../../../helpers/setup-mirage';
+import { setupTest } from '../../../../helpers';
+import setupMirage from '../../../../helpers/setup-mirage';
 
 module('Mirage | GET /api/v1/crates/:crateId/following', function (hooks) {
   setupTest(hooks);

mirage/factories/index.js renamed to tests/mirage/factories/index.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../../helpers';
-import setupMirage from '../../../helpers/setup-mirage';
+import { setupTest } from '../../../../helpers';
+import setupMirage from '../../../../helpers/setup-mirage';
 
 module('Mirage | PUT /api/v1/crates/:crateId/follow', function (hooks) {
   setupTest(hooks);

mirage/factories/keyword.js renamed to tests/mirage/factories/keyword.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../helpers';
-import setupMirage from '../../helpers/setup-mirage';
+import { setupTest } from '../../../helpers';
+import setupMirage from '../../../helpers/setup-mirage';
 
 module('Mirage | GET /api/v1/crates/:id', function (hooks) {
   setupTest(hooks);

mirage/factories/mirage-session.js renamed to tests/mirage/factories/mirage-session.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../helpers';
-import setupMirage from '../../helpers/setup-mirage';
+import { setupTest } from '../../../helpers';
+import setupMirage from '../../../helpers/setup-mirage';
 
 module('Mirage | GET /api/v1/crates', function (hooks) {
   setupTest(hooks);

mirage/factories/team.js renamed to tests/mirage/factories/team.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../helpers';
-import setupMirage from '../../helpers/setup-mirage';
+import { setupTest } from '../../../helpers';
+import setupMirage from '../../../helpers/setup-mirage';
 
 module('Mirage | GET /api/v1/crates/:id/owner_team', function (hooks) {
   setupTest(hooks);

mirage/factories/user.js renamed to tests/mirage/factories/user.js

@@ -2,8 +2,8 @@ import { module, test } from 'qunit';
 
 import fetch from 'fetch';
 
-import { setupTest } from '../../helpers';
-import setupMirage from '../../helpers/setup-mirage';
+import { setupTest } from '../../../helpers';
+import setupMirage from '../../../helpers/setup-mirage';
 
 module('Mirage | GET /api/v1/crates/:id/owner_user', function (hooks) {
   setupTest(hooks);