Auto merge of #2570 - Turbo87:title, r=locks

bors · bors · commit 57b7e4a551ed · 2020-06-12T13:50:48.000Z
Replace `{{ title }}` with `{{page-title}}` turns out searching for `{{title` doesn't catch the usages that have a space between the curlies and the helper name 😅 r? @locks
diff --git a/app/templates/categories.hbs b/app/templates/categories.hbs
@@ -1,4 +1,4 @@
-{{ title 'Categories' }}
+{{page-title 'Categories'}}
 
 <PageHeader @title="All Categories"/>
 
diff --git a/app/templates/category-slugs.hbs b/app/templates/category-slugs.hbs
@@ -1,4 +1,4 @@
-{{ title 'Category Slugs' }}
+{{page-title 'Category Slugs'}}
 
 <PageHeader @title="All Valid Category Slugs"/>
 
diff --git a/app/templates/category/error.hbs b/app/templates/category/error.hbs
@@ -1 +1 @@
-{{ title 'Category Not Found' }}
+{{page-title 'Category Not Found'}}
diff --git a/app/templates/category/index.hbs b/app/templates/category/index.hbs
@@ -1,4 +1,4 @@
-{{ title this.category.category ' - Categories' }}
+{{page-title this.category.category ' - Categories'}}
 
 <PageHeader local-class="header">
   <LinkTo @route="categories" aria-label="Categories">{{svg-jar "crate"}}</LinkTo>
diff --git a/app/templates/crate/error.hbs b/app/templates/crate/error.hbs
@@ -1 +1 @@
-{{ title 'Crate Not Found' }}
+{{page-title 'Crate Not Found'}}
diff --git a/app/templates/crate/owners.hbs b/app/templates/crate/owners.hbs
@@ -1,4 +1,4 @@
-{{ title 'Manage Crate Owners' }}
+{{page-title 'Manage Crate Owners'}}
 
 <PageHeader
   @title="Manager Crate Owners"
diff --git a/app/templates/crates.hbs b/app/templates/crates.hbs
@@ -1,4 +1,4 @@
-{{ title 'Crates' }}
+{{page-title 'Crates'}}
 
 <PageHeader @title="All Crates" @suffix={{if this.letter (concat "starting with '" this.letter "'")}}/>
 
diff --git a/app/templates/dashboard.hbs b/app/templates/dashboard.hbs
@@ -1,4 +1,4 @@
-{{ title 'Dashboard' }}
+{{page-title 'Dashboard'}}
 
 <PageHeader local-class="header">
   {{svg-jar "dashboard" local-class="header-icon"}}
diff --git a/app/templates/keyword/error.hbs b/app/templates/keyword/error.hbs
@@ -1 +1 @@
-{{ title 'Keyword Not Found' }}
+{{page-title 'Keyword Not Found'}}
diff --git a/app/templates/keyword/index.hbs b/app/templates/keyword/index.hbs
@@ -1,4 +1,4 @@
-{{ title this.keyword.keyword ' - Keywords' }}
+{{page-title this.keyword.keyword ' - Keywords'}}
 
 <PageHeader @title="All Crates" @suffix="for keyword '{{this.keyword.keyword}}'"/>
 
diff --git a/app/templates/keywords.hbs b/app/templates/keywords.hbs
@@ -1,4 +1,4 @@
-{{ title 'Keywords' }}
+{{page-title 'Keywords'}}
 
 <PageHeader @title="All Keywords"/>
 
diff --git a/app/templates/me/crates.hbs b/app/templates/me/crates.hbs
@@ -1,4 +1,4 @@
-{{ title 'My Crates' }}
+{{page-title 'My Crates'}}
 
 <PageHeader @title="My Crates"/>
 
diff --git a/app/templates/me/index.hbs b/app/templates/me/index.hbs
@@ -1,4 +1,4 @@
-{{ title 'Settings' }}
+{{page-title 'Settings'}}
 
 <PageHeader @title="Account Settings" @icon="gear"/>
 
diff --git a/app/templates/me/pending-invites.hbs b/app/templates/me/pending-invites.hbs
@@ -1,4 +1,4 @@
-{{ title 'Pending Invites' }}
+{{page-title 'Pending Invites'}}
 
 <PageHeader @title="Pending Owner Invites" @icon="gear"/>
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-{{ title 'Categories' }}`
	`1`	`+{{page-title 'Categories'}}`
`2`	`2`
`3`	`3`	`<PageHeader @title="All Categories"/>`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-{{ title 'Category Slugs' }}`
	`1`	`+{{page-title 'Category Slugs'}}`
`2`	`2`
`3`	`3`	`<PageHeader @title="All Valid Category Slugs"/>`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{{ title 'Category Not Found' }}`
	`1`	`+{{page-title 'Category Not Found'}}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-{{ title this.category.category ' - Categories' }}`
	`1`	`+{{page-title this.category.category ' - Categories'}}`
`2`	`2`
`3`	`3`	`<PageHeader local-class="header">`
`4`	`4`	`<LinkTo @route="categories" aria-label="Categories">{{svg-jar "crate"}}</LinkTo>`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{{ title 'Crate Not Found' }}`
	`1`	`+{{page-title 'Crate Not Found'}}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-{{ title 'Manage Crate Owners' }}`
	`1`	`+{{page-title 'Manage Crate Owners'}}`
`2`	`2`
`3`	`3`	`<PageHeader`
`4`	`4`	`@title="Manager Crate Owners"`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-{{ title 'Crates' }}`
	`1`	`+{{page-title 'Crates'}}`
`2`	`2`
`3`	`3`	`<PageHeader @title="All Crates" @suffix={{if this.letter (concat "starting with '" this.letter "'")}}/>`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-{{ title 'Dashboard' }}`
	`1`	`+{{page-title 'Dashboard'}}`
`2`	`2`
`3`	`3`	`<PageHeader local-class="header">`
`4`	`4`	`{{svg-jar "dashboard" local-class="header-icon"}}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{{ title 'Keyword Not Found' }}`
	`1`	`+{{page-title 'Keyword Not Found'}}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-{{ title this.keyword.keyword ' - Keywords' }}`
	`1`	`+{{page-title this.keyword.keyword ' - Keywords'}}`
`2`	`2`
`3`	`3`	`<PageHeader @title="All Crates" @suffix="for keyword '{{this.keyword.keyword}}'"/>`
`4`	`4`