Auto merge of #4397 - Turbo87:remove-obsolete-github-route, r=Turbo87

Remove obsolete `/authorize/github` route

This route has been replaced with the `github-redirect.html` file instead and is no longer needed.

Todo:
- [x] check if CSP configuration works with the inline JS in `github-redirect.html`

Author: bors

.env.sample

@@ -42,7 +42,7 @@ export GIT_REPO_URL=file://$PWD/tmp/index-bare
 # not logging into your crates.io instance.
 # When registering a new application on GitHub for use with your local
 # crates.io instance, be sure to set the callback url for that application
-# to the address `http://localhost:4200/authorize/github`.
+# to the address `http://localhost:4200/github-redirect.html`.
 export GH_CLIENT_ID=
 export GH_CLIENT_SECRET=
 

app/router.js

@@ -8,7 +8,6 @@ export default class Router extends EmberRouter {
 }
 
 Router.map(function () {
-  this.route('github-authorize', { path: '/authorize/github' });
   this.route('crates');
   this.route('crate', { path: '/crates/:crate_id' }, function () {
     this.route('versions');

app/routes/github-authorize.js

@@ -463,7 +463,7 @@ OAuth Applications](https://github.com/settings/developers) and click on the
 
 - Application name: name your application whatever you'd like.
 - Homepage URL: `http://localhost:4200/`
-- Authorization callback URL: `http://localhost:4200/authorize/github`
+- Authorization callback URL: `http://localhost:4200/github-redirect.html`
 
 Create the application, then take the Client ID ad Client Secret values and use
 them as the values of the `GH_CLIENT_ID` and `GH_CLIENT_SECRET` in your `.env`.