Merge #1076

1076: Fixes errors on "not found" pages r=Turbo87

Turns out when we were checking for crate/category/etc not being found, we were using `any` from the ember prototype extensions. This PR changes those spots to use `some` instead, and cleans up a few other inconsistencies I noticed.

I tried to write tests for "not found" pages, but that's proving to be a bit more.... interesting... so I decided to open this up to fix production first.

r? @Turbo87

Author: bors-voyager[bot]

app/routes/category.js

@@ -6,8 +6,9 @@ export default Route.extend({
 
     model(params) {
         return this.store.find('category', params.category_id).catch(e => {
-            if (e.errors.any(e => e.detail === 'Not Found')) {
-                this.get('flashMessages').show(`Category '${params.category_id}' does not exist`);
+            if (e.errors.some(e => e.detail === 'Not Found')) {
+                this.get('flashMessages').queue(`Category '${params.category_id}' does not exist`);
+                return this.replaceWith('index');
             }
         });
     }

app/routes/crate.js

@@ -6,7 +6,7 @@ export default Route.extend({
 
     model(params) {
         return this.store.find('crate', params.crate_id).catch(e => {
-            if (e.errors.any(e => e.detail === 'Not Found')) {
+            if (e.errors.some(e => e.detail === 'Not Found')) {
                 this.get('flashMessages').show(`Crate '${params.crate_id}' does not exist`);
                 return;
             }

app/routes/keyword.js

@@ -6,8 +6,9 @@ export default Route.extend({
 
     model({ keyword_id }) {
         return this.store.find('keyword', keyword_id).catch(e => {
-            if (e.errors.any(e => e.detail === 'Not Found')) {
-                this.get('flashMessages').show(`Keyword '${keyword_id}' does not exist`);
+            if (e.errors.some(e => e.detail === 'Not Found')) {
+                this.get('flashMessages').queue(`Keyword '${keyword_id}' does not exist`);
+                return this.replaceWith('index');
             }
         });
     }

app/routes/team.js

@@ -30,8 +30,8 @@ export default Route.extend({
                 });
             },
             (e) => {
-                if (e.errors.any(e => e.detail === 'Not Found')) {
-                    this.get('flashMessages').queue(`User '${params.team_id}' does not exist`);
+                if (e.errors.some(e => e.detail === 'Not Found')) {
+                    this.get('flashMessages').queue(`Team '${params.team_id}' does not exist`);
                     return this.replaceWith('index');
                 }
             }

app/routes/user.js

@@ -23,7 +23,7 @@ export default Route.extend({
                 });
             },
             (e) => {
-                if (e.errors.any(e => e.detail === 'Not Found')) {
+                if (e.errors.some(e => e.detail === 'Not Found')) {
                     this.get('flashMessages').queue(`User '${params.user_id}' does not exist`);
                     return this.replaceWith('index');
                 }