mirage/crate: Replace user|teamOwners relationships with crate-ownership model

Author: Turbo87

mirage/fixtures/crate-ownerships.js

@@ -0,0 +1,18 @@
+export default [
+  {
+    crateId: 'nanomsg',
+    teamId: 1,
+  },
+  {
+    crateId: 'nanomsg',
+    teamId: 303,
+  },
+  {
+    crateId: 'nanomsg',
+    userId: 2,
+  },
+  {
+    crateId: 'nanomsg',
+    userId: 303,
+  },
+];

mirage/models/crate.js

@@ -3,7 +3,5 @@ import { Model, hasMany } from 'ember-cli-mirage';
 export default Model.extend({
   categories: hasMany(),
   keywords: hasMany(),
-  teamOwners: hasMany('team'),
   versions: hasMany(),
-  userOwners: hasMany('user'),
 });

mirage/route-handlers/crates.js

@@ -99,27 +99,31 @@ export function register(server) {
     let crate = schema.crates.find(crateId);
     if (!crate) return notFound();
 
-    let response = this.serialize(crate.userOwners);
+    let ownerships = schema.crateOwnerships.where({ crateId }).filter(it => it.userId).models;
 
-    response.users.forEach(user => {
-      user.kind = 'user';
-    });
-
-    return response;
+    return {
+      users: ownerships.map(it => {
+        let json = this.serialize(it.user, 'user').user;
+        json.kind = 'user';
+        return json;
+      }),
+    };
   });
 
   server.get('/api/v1/crates/:crate_id/owner_team', function (schema, request) {
     let crateId = request.params.crate_id;
     let crate = schema.crates.find(crateId);
     if (!crate) return notFound();
 
-    let response = this.serialize(crate.teamOwners);
+    let ownerships = schema.crateOwnerships.where({ crateId }).filter(it => it.teamId).models;
 
-    response.teams.forEach(team => {
-      team.kind = 'team';
-    });
-
-    return response;
+    return {
+      teams: ownerships.map(it => {
+        let json = this.serialize(it.team, 'team').team;
+        json.kind = 'team';
+        return json;
+      }),
+    };
   });
 
   server.get('/api/v1/crates/:crate_id/reverse_dependencies', function (schema, request) {

tests/mirage/crates-test.js

@@ -685,7 +685,8 @@ module('Mirage | Crates', function (hooks) {
 
     test('returns the list of users that own the specified crate', async function (assert) {
       let user = this.server.create('user', { name: 'John Doe' });
-      this.server.create('crate', { name: 'rand', userOwners: [user] });
+      let crate = this.server.create('crate', { name: 'rand' });
+      this.server.create('crate-ownership', { crate, user });
 
       let response = await fetch('/api/v1/crates/rand/owner_user');
       assert.equal(response.status, 200);
@@ -729,7 +730,8 @@ module('Mirage | Crates', function (hooks) {
 
     test('returns the list of teams that own the specified crate', async function (assert) {
       let team = this.server.create('team', { name: 'maintainers' });
-      this.server.create('crate', { name: 'rand', teamOwners: [team] });
+      let crate = this.server.create('crate', { name: 'rand' });
+      this.server.create('crate-ownership', { crate, team });
 
       let response = await fetch('/api/v1/crates/rand/owner_team');
       assert.equal(response.status, 200);