Skip to content

Commit 7e106b9

Browse files
committed
Add npm install to frontend Docker
The frontend Docker image appears to be following a pretty standard Node convention of adding the package.json, running `npm install`, and then copying the rest of the application, which makes rebuilding new docker images much faster if there are no dependency changes. However, in the great `yarn` cleanup of 2017, `yarn install` was removed but the corresponding `npm install` was not added back. This means that when the frontend docker image tries to run ember, ember is not available because it was never installed.
1 parent 69368a6 commit 7e106b9

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

frontend.Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
FROM node:8.6-alpine
22

33
WORKDIR /app
4-
COPY package.json /app
4+
COPY package.json package-lock.json /app/
5+
6+
RUN npm install
57

68
COPY . /app
79

0 commit comments

Comments
 (0)