Skip to content

Commit 82485ac

Browse files
committed
Kill the remaining raw inserts in update-downloads.rs
1 parent 7239161 commit 82485ac

File tree

1 file changed

+30
-22
lines changed

1 file changed

+30
-22
lines changed

src/bin/update-downloads.rs

Lines changed: 30 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,7 @@ mod test {
115115

116116
use std::collections::HashMap;
117117

118-
use diesel::dsl::sql;
119118
use diesel::insert_into;
120-
use diesel::types::Integer;
121119
use super::*;
122120
use cargo_registry::env;
123121
use cargo_registry::krate::{Crate, NewCrate};
@@ -230,14 +228,18 @@ mod test {
230228

231229
#[test]
232230
fn dont_process_recent_row() {
231+
use diesel::dsl::*;
233232
let conn = conn();
234233
let user = user(&conn);
235234
let (_, version) = crate_and_version(&conn, user.id);
236-
sql::<Integer>(
237-
"INSERT INTO version_downloads \
238-
(version_id, downloads, counted, date, processed)
239-
VALUES ($1, 2, 2, DATE(NOW() - INTERVAL '2 hours'), false)",
240-
).bind::<Integer, _>(version.id)
235+
insert_into(version_downloads::table)
236+
.values((
237+
version_downloads::version_id.eq(version.id),
238+
version_downloads::downloads.eq(2),
239+
version_downloads::counted.eq(2),
240+
version_downloads::date.eq(date(now - 2.hours())),
241+
version_downloads::processed.eq(false),
242+
))
241243
.execute(&conn)
242244
.unwrap();
243245
::update(&conn).unwrap();
@@ -264,18 +266,21 @@ mod test {
264266
.set(crates::updated_at.eq(now - 2.hours()))
265267
.execute(&conn)
266268
.unwrap();
267-
sql::<Integer>(
268-
"INSERT INTO version_downloads \
269-
(version_id, downloads, counted, date, processed)
270-
VALUES ($1, 2, 1, current_date, false)",
271-
).bind::<Integer, _>(version.id)
269+
insert_into(version_downloads::table)
270+
.values((
271+
version_downloads::version_id.eq(version.id),
272+
version_downloads::downloads.eq(2),
273+
version_downloads::counted.eq(1),
274+
version_downloads::date.eq(date(now)),
275+
version_downloads::processed.eq(false),
276+
))
272277
.execute(&conn)
273278
.unwrap();
274-
sql::<Integer>(
275-
"INSERT INTO version_downloads \
276-
(version_id, date)
277-
VALUES ($1, current_date - interval '1 day')",
278-
).bind::<Integer, _>(version.id)
279+
insert_into(version_downloads::table)
280+
.values((
281+
version_downloads::version_id.eq(version.id),
282+
version_downloads::date.eq(date(now - 1.day())),
283+
))
279284
.execute(&conn)
280285
.unwrap();
281286

@@ -325,11 +330,14 @@ mod test {
325330
.set(crates::updated_at.eq(now - 2.days()))
326331
.execute(&conn)
327332
.unwrap();
328-
sql::<Integer>(
329-
"INSERT INTO version_downloads \
330-
(version_id, downloads, counted, date, processed)
331-
VALUES ($1, 2, 2, current_date - interval '2 days', false)",
332-
).bind::<Integer, _>(version.id)
333+
insert_into(version_downloads::table)
334+
.values((
335+
version_downloads::version_id.eq(version.id),
336+
version_downloads::downloads.eq(2),
337+
version_downloads::counted.eq(2),
338+
version_downloads::date.eq(date(now - 2.days())),
339+
version_downloads::processed.eq(false),
340+
))
333341
.execute(&conn)
334342
.unwrap();
335343

0 commit comments

Comments
 (0)