Auto merge of #3075 - Turbo87:sort-order, r=locks

ESLint: Enable `sort-imports` rule

With https://github.com/Tibfib/eslint-plugin-import-helpers and prettier, this rule makes it even easier to import things and have the tooling take care of formatting things in a readable way.

r? `@locks`

Author: bors

.eslintrc.js

@@ -22,6 +22,9 @@ module.exports = {
     // it's fine to use `return` without a value and rely on the implicit `undefined` return value
     'getter-return': 'off',
 
+    // declaration sort is taken care of by `import-helpers/order-imports`
+    'sort-imports': ['error', { ignoreDeclarationSort: true, ignoreCase: true }],
+
     'prettier/prettier': 'error',
 
     // disabled because we still use `this.set()` in a few places and it works just fine

app/adapters/category-slug.js

@@ -1,4 +1,4 @@
-import { underscore, decamelize } from '@ember/string';
+import { decamelize, underscore } from '@ember/string';
 
 import { pluralize } from 'ember-inflector';
 

app/components/follow-button.js

@@ -2,7 +2,7 @@ import { inject as service } from '@ember/service';
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 
-import { task, didCancel } from 'ember-concurrency';
+import { didCancel, task } from 'ember-concurrency';
 
 import ajax from '../utils/ajax';
 

app/controllers/crate/version.js

@@ -1,6 +1,6 @@
 import Controller from '@ember/controller';
 import { computed } from '@ember/object';
-import { gt, readOnly, alias } from '@ember/object/computed';
+import { alias, gt, readOnly } from '@ember/object/computed';
 import { inject as service } from '@ember/service';
 
 import { task } from 'ember-concurrency';

app/controllers/search.js

@@ -1,6 +1,6 @@
 import Controller from '@ember/controller';
 import { action, computed } from '@ember/object';
-import { readOnly, bool } from '@ember/object/computed';
+import { bool, readOnly } from '@ember/object/computed';
 
 import { task } from 'ember-concurrency';
 

app/models/dependency.js

@@ -1,4 +1,4 @@
-import Model, { belongsTo, attr } from '@ember-data/model';
+import Model, { attr, belongsTo } from '@ember-data/model';
 
 import Inflector from 'ember-inflector';
 

app/models/version-download.js

@@ -1,4 +1,4 @@
-import Model, { belongsTo, attr } from '@ember-data/model';
+import Model, { attr, belongsTo } from '@ember-data/model';
 
 export default class VersionDownload extends Model {
   /** @type number */

mirage/models/api-token.js

@@ -1,4 +1,4 @@
-import { Model, belongsTo } from 'ember-cli-mirage';
+import { belongsTo, Model } from 'ember-cli-mirage';
 
 export default Model.extend({
   user: belongsTo(),

mirage/models/crate-ownership.js

@@ -1,4 +1,4 @@
-import { Model, belongsTo } from 'ember-cli-mirage';
+import { belongsTo, Model } from 'ember-cli-mirage';
 
 export default Model.extend({
   crate: belongsTo(),

mirage/models/crate.js

@@ -1,4 +1,4 @@
-import { Model, hasMany } from 'ember-cli-mirage';
+import { hasMany, Model } from 'ember-cli-mirage';
 
 export default Model.extend({
   categories: hasMany(),

mirage/models/dependency.js

@@ -1,4 +1,4 @@
-import { Model, belongsTo } from 'ember-cli-mirage';
+import { belongsTo, Model } from 'ember-cli-mirage';
 
 export default Model.extend({
   crate: belongsTo(),

mirage/models/mirage-session.js

@@ -1,4 +1,4 @@
-import { Model, belongsTo } from 'ember-cli-mirage';
+import { belongsTo, Model } from 'ember-cli-mirage';
 
 /**
  * This is a mirage-only model, that is used to keep track of the current

mirage/models/user.js

@@ -1,4 +1,4 @@
-import { Model, hasMany } from 'ember-cli-mirage';
+import { hasMany, Model } from 'ember-cli-mirage';
 
 export default Model.extend({
   followedCrates: hasMany('crate'),

mirage/models/version-download.js

@@ -1,4 +1,4 @@
-import { Model, belongsTo } from 'ember-cli-mirage';
+import { belongsTo, Model } from 'ember-cli-mirage';
 
 export default Model.extend({
   version: belongsTo(),

mirage/models/version.js

@@ -1,4 +1,4 @@
-import { Model, belongsTo } from 'ember-cli-mirage';
+import { belongsTo, Model } from 'ember-cli-mirage';
 
 export default Model.extend({
   crate: belongsTo(),

mirage/route-handlers/categories.js

@@ -1,4 +1,4 @@
-import { pageParams, compareStrings, withMeta, notFound } from './-utils';
+import { compareStrings, notFound, pageParams, withMeta } from './-utils';
 
 export function register(server) {
   server.get('/api/v1/categories', function (schema, request) {

mirage/route-handlers/keywords.js

@@ -1,4 +1,4 @@
-import { pageParams, withMeta, notFound } from './-utils';
+import { notFound, pageParams, withMeta } from './-utils';
 
 export function register(server) {
   server.get('/api/v1/keywords', function (schema, request) {

tests/acceptance/404-test.js

@@ -1,4 +1,4 @@
-import { fillIn, currentURL, triggerEvent, visit } from '@ember/test-helpers';
+import { currentURL, fillIn, triggerEvent, visit } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 

tests/acceptance/api-token-test.js

@@ -1,4 +1,4 @@
-import { currentURL, findAll, click, fillIn } from '@ember/test-helpers';
+import { click, currentURL, fillIn, findAll } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 

tests/acceptance/crate-following-test.js

@@ -1,4 +1,4 @@
-import { visit, waitFor, settled, click } from '@ember/test-helpers';
+import { click, settled, visit, waitFor } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 

tests/acceptance/crate-test.js

@@ -1,6 +1,6 @@
-import { click, currentURL, currentRouteName, visit, waitFor } from '@ember/test-helpers';
+import { click, currentRouteName, currentURL, visit, waitFor } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
-import { module, test, skip } from 'qunit';
+import { module, skip, test } from 'qunit';
 
 import percySnapshot from '@percy/ember';
 import a11yAudit from 'ember-a11y-testing/test-support/audit';

tests/acceptance/front-page-test.js

@@ -1,4 +1,4 @@
-import { currentURL, visit, click, waitFor, settled } from '@ember/test-helpers';
+import { click, currentURL, settled, visit, waitFor } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 

tests/acceptance/invites-test.js

@@ -1,4 +1,4 @@
-import { currentURL, click } from '@ember/test-helpers';
+import { click, currentURL } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 

tests/acceptance/login-test.js

@@ -1,4 +1,4 @@
-import { visit, currentURL, click, waitFor } from '@ember/test-helpers';
+import { click, currentURL, visit, waitFor } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 

tests/acceptance/logout-test.js

@@ -1,4 +1,4 @@
-import { visit, currentURL, click } from '@ember/test-helpers';
+import { click, currentURL, visit } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 

tests/acceptance/search-test.js

@@ -1,4 +1,4 @@
-import { click, fillIn, currentURL, triggerEvent, visit, blur, waitFor, settled } from '@ember/test-helpers';
+import { blur, click, currentURL, fillIn, settled, triggerEvent, visit, waitFor } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 

tests/bugs/2329-test.js

@@ -1,4 +1,4 @@
-import { currentURL, click, waitFor } from '@ember/test-helpers';
+import { click, currentURL, waitFor } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 

tests/helpers/visit-ignoring-abort.js

@@ -1,4 +1,4 @@
-import { settled, visit as _visit } from '@ember/test-helpers';
+import { visit as _visit, settled } from '@ember/test-helpers';
 
 // see https://github.com/emberjs/ember-test-helpers/issues/332
 export async function visit(url) {