worker: Inline connection() fn (#8384)

Author: Turbo87

crates/crates_io_worker/src/runner.rs

@@ -4,7 +4,7 @@ use crate::worker::Worker;
 use crate::{storage, BackgroundJob};
 use anyhow::anyhow;
 use diesel::prelude::*;
-use diesel::r2d2::{ConnectionManager, Pool, PoolError, PooledConnection};
+use diesel::r2d2::{ConnectionManager, Pool};
 use futures_util::future::join_all;
 use std::collections::HashMap;
 use std::sync::Arc;
@@ -16,7 +16,6 @@ use tracing::{info, info_span, warn, Instrument};
 const DEFAULT_POLL_INTERVAL: Duration = Duration::from_secs(1);
 
 pub type ConnectionPool = Pool<ConnectionManager<PgConnection>>;
-pub type PooledConn = PooledConnection<ConnectionManager<PgConnection>>;
 
 /// The core runner responsible for locking and running jobs
 pub struct Runner<Context> {
@@ -99,16 +98,13 @@ impl<Context: Clone + Send + Sync + 'static> Runner<Context> {
         RunHandle { handles }
     }
 
-    pub fn connection(&self) -> Result<PooledConn, PoolError> {
-        self.connection_pool.get()
-    }
-
     /// Check if any jobs in the queue have failed.
     ///
     /// This function is intended for use in tests and will return an error if
     /// any jobs have failed.
     pub fn check_for_failed_jobs(&self) -> anyhow::Result<()> {
-        let failed_jobs = storage::failed_job_count(&mut *self.connection()?)?;
+        let mut conn = self.connection_pool.get()?;
+        let failed_jobs = storage::failed_job_count(&mut conn)?;
         if failed_jobs == 0 {
             Ok(())
         } else {