tests/publish/dependencies: Add invalid_feature_name() test

Author: Turbo87

src/tests/builders/dependency.rs

@@ -1,9 +1,11 @@
 use crates_io::views::krate_publish as u;
+use crates_io::views::krate_publish::EncodableFeature;
 
 /// A builder for constructing a dependency of another crate.
 pub struct DependencyBuilder {
     explicit_name_in_toml: Option<u::EncodableDependencyName>,
     name: String,
+    features: Vec<String>,
     registry: Option<String>,
     version_req: u::EncodableCrateVersionReq,
 }
@@ -14,6 +16,7 @@ impl DependencyBuilder {
         DependencyBuilder {
             explicit_name_in_toml: None,
             name: name.to_string(),
+            features: vec![],
             registry: None,
             version_req: u::EncodableCrateVersionReq("> 0".to_string()),
         }
@@ -42,14 +45,25 @@ impl DependencyBuilder {
         self
     }
 
+    pub fn add_feature<T: Into<String>>(mut self, feature: T) -> Self {
+        self.features.push(feature.into());
+        self
+    }
+
     /// Consume this builder to create a `u::CrateDependency`. If the dependent crate doesn't
     /// already exist, publishing a crate with this dependency will fail.
     pub fn build(self) -> u::EncodableCrateDependency {
+        let features = self
+            .features
+            .into_iter()
+            .map(|d| EncodableFeature(d))
+            .collect();
+
         u::EncodableCrateDependency {
             name: u::EncodableCrateName(self.name),
             optional: false,
             default_features: true,
-            features: Vec::new(),
+            features,
             version_req: self.version_req,
             target: None,
             kind: None,

src/tests/krate/publish/dependencies.rs

@@ -223,3 +223,16 @@ fn new_krate_sorts_deps() {
     let crates = app.crates_from_index_head("two-deps");
     assert_json_snapshot!(crates);
 }
+
+#[test]
+fn invalid_feature_name() {
+    let (app, _, _, token) = TestApp::full().with_token();
+
+    let response = token.publish_crate(
+        PublishBuilder::new("foo", "1.0.0")
+            .dependency(DependencyBuilder::new("bar").add_feature("🍺")),
+    );
+    assert_eq!(response.status(), StatusCode::OK);
+    assert_json_snapshot!(response.into_json());
+    assert!(app.stored_files().is_empty());
+}

src/tests/krate/publish/snapshots/all__krate__publish__dependencies__invalid_feature_name.snap

@@ -0,0 +1,11 @@
+---
+source: src/tests/krate/publish/dependencies.rs
+expression: response.into_json()
+---
+{
+  "errors": [
+    {
+      "detail": "invalid upload request: invalid value: string \"🍺\", expected a valid feature name at line 1 column 111"
+    }
+  ]
+}