Skip to content

Commit 897c50d

Browse files
committed
Fix ESLINT_LEGACY_OBJECT_REST_SPREAD
ES2018 supports the feature officially, and eslint deprecated `experimentalObjectRestSpread` because of that. The warning is also coming from eslint-plugin-ember. That's why the plugin is updated.
1 parent 95a4722 commit 897c50d

File tree

3 files changed

+27
-21
lines changed

3 files changed

+27
-21
lines changed

.eslintrc.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
module.exports = {
22
root: true,
33
parserOptions: {
4-
ecmaVersion: 2017,
4+
ecmaVersion: 2018,
55
sourceType: 'module',
6-
ecmaFeatures: {
7-
experimentalObjectRestSpread: true,
8-
},
96
},
107
plugins: ['ember', 'prettier'],
118
extends: ['eslint:recommended', 'plugin:ember/recommended', 'plugin:prettier/recommended'],
@@ -21,6 +18,10 @@ module.exports = {
2118
'comma-dangle': 'off',
2219
'dot-notation': 'off',
2320
'operator-linebreak': 'off',
21+
22+
'ember/no-observers': 'warn',
23+
'ember/no-new-mixins': 'warn',
24+
'ember/require-return-from-computed': 'warn',
2425
},
2526
overrides: [
2627
// node files
@@ -37,7 +38,7 @@ module.exports = {
3738
],
3839
parserOptions: {
3940
sourceType: 'script',
40-
ecmaVersion: 2015,
41+
ecmaVersion: 2018,
4142
},
4243
env: {
4344
browser: false,

package-lock.json

Lines changed: 20 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
"emberx-select": "^3.1.1",
7676
"eslint": "^5.16.0",
7777
"eslint-config-prettier": "^2.9.0",
78-
"eslint-plugin-ember": "^5.1.0",
78+
"eslint-plugin-ember": "^7.0.0",
7979
"eslint-plugin-prettier": "^2.6.0",
8080
"loader.js": "^4.5.1",
8181
"normalize.css": "^7.0.0",

0 commit comments

Comments
 (0)