mirage: Add route handler for PUT /api/v1/confirm/:token endpoint

Author: Turbo87

mirage/factories/user.js

@@ -18,6 +18,12 @@ export default Factory.extend({
 
   avatar: 'https://avatars1.githubusercontent.com/u/14631425?v=4',
 
-  emailVerified: true,
-  emailVerificationSent: true,
+  emailVerified: null,
+  emailVerificationToken: null,
+
+  afterCreate(model) {
+    if (model.emailVerified === null) {
+      model.update({ emailVerified: !model.emailVerificationToken });
+    }
+  },
 });

mirage/route-handlers/me.js

@@ -16,4 +16,17 @@ export function register(server) {
 
     return json;
   });
+
+  server.put('/api/v1/confirm/:token', (schema, request) => {
+    let { token } = request.params;
+
+    let user = schema.users.findBy({ emailVerificationToken: token });
+    if (!user) {
+      return new Response(400, {}, { errors: [{ detail: 'Email belonging to token not found.' }] });
+    }
+
+    user.update({ emailVerified: true, emailVerificationToken: null });
+
+    return { ok: true };
+  });
 }

mirage/serializers/user.js

@@ -23,7 +23,10 @@ export default BaseSerializer.extend({
     if (removePrivateData) {
       delete hash.email;
       delete hash.email_verified;
-      delete hash.email_verification_sent;
+    } else {
+      hash.email_verification_sent = hash.email_verified || Boolean(hash.email_verification_token);
     }
+
+    delete hash.email_verification_token;
   },
 });

tests/acceptance/email-confirmation-test.js

@@ -2,7 +2,6 @@ import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';
 import { currentURL } from '@ember/test-helpers';
 import window, { setupWindowMock } from 'ember-window-mock';
-import { Response } from 'ember-cli-mirage';
 
 import { visit } from '../helpers/visit-ignoring-abort';
 import setupMirage from '../helpers/setup-mirage';
@@ -13,60 +12,36 @@ module('Acceptance | Email Confirmation', function (hooks) {
   setupMirage(hooks);
 
   test('unauthenticated happy path', async function (assert) {
-    assert.expect(3);
-
-    this.server.put('/api/v1/confirm/:token', (schema, request) => {
-      assert.equal(request.params.token, 'badc0ffee');
-      return { ok: true };
-    });
+    let user = this.server.create('user', { emailVerificationToken: 'badc0ffee' });
+    assert.strictEqual(user.emailVerified, false);
 
     await visit('/confirm/badc0ffee');
     assert.equal(currentURL(), '/confirm/badc0ffee');
     assert.dom('[data-test-success-message]').exists();
+
+    user.reload();
+    assert.strictEqual(user.emailVerified, true);
   });
 
   test('authenticated happy path', async function (assert) {
-    assert.expect(4);
-
-    let emailVerified = false;
+    let user = this.server.create('user', { emailVerificationToken: 'badc0ffee' });
+    assert.strictEqual(user.emailVerified, false);
 
+    this.server.create('mirage-session', { user });
     window.localStorage.setItem('isLoggedIn', '1');
 
-    this.server.get('/api/v1/me', () => ({
-      user: {
-        id: 42,
-        login: 'johnnydee',
-        email_verified: emailVerified,
-        email_verification_sent: true,
-        name: 'John Doe',
-        email: '[email protected]',
-        avatar: 'https://avatars2.githubusercontent.com/u/1234567?v=4',
-        url: 'https://github.com/johnnydee',
-      },
-      owned_crates: [],
-    }));
-
-    this.server.put('/api/v1/confirm/:token', (schema, request) => {
-      assert.equal(request.params.token, 'badc0ffee');
-
-      emailVerified = true;
-
-      return { ok: true };
-    });
-
     await visit('/confirm/badc0ffee');
     assert.equal(currentURL(), '/confirm/badc0ffee');
     assert.dom('[data-test-success-message]').exists();
 
     let { currentUser } = this.owner.lookup('service:session');
     assert.strictEqual(currentUser.email_verified, true);
+
+    user.reload();
+    assert.strictEqual(user.emailVerified, true);
   });
 
   test('error case', async function (assert) {
-    this.server.put('/api/v1/confirm/:token', () => {
-      return new Response(400, {}, { errors: [{ detail: 'Email belonging to token not found.' }] });
-    });
-
     await visit('/confirm/badc0ffee');
     assert.equal(currentURL(), '/');
     assert.dom('[data-test-flash-message]').hasText('Unknown error in email confirmation');

tests/mirage/me-test.js

@@ -44,4 +44,46 @@ module('Mirage | /me', function (hooks) {
       });
     });
   });
+
+  module('GET /api/v1/confirm/:token', function () {
+    test('returns `ok: true` for a known token (unauthenticated)', async function (assert) {
+      let user = this.server.create('user', { emailVerificationToken: 'foo' });
+      assert.strictEqual(user.emailVerified, false);
+
+      let response = await fetch('/api/v1/confirm/foo', { method: 'PUT' });
+      assert.equal(response.status, 200);
+
+      let responsePayload = await response.json();
+      assert.deepEqual(responsePayload, { ok: true });
+
+      user.reload();
+      assert.strictEqual(user.emailVerified, true);
+    });
+
+    test('returns `ok: true` for a known token (authenticated)', async function (assert) {
+      let user = this.server.create('user', { emailVerificationToken: 'foo' });
+      assert.strictEqual(user.emailVerified, false);
+
+      this.server.create('mirage-session', { user });
+
+      let response = await fetch('/api/v1/confirm/foo', { method: 'PUT' });
+      assert.equal(response.status, 200);
+
+      let responsePayload = await response.json();
+      assert.deepEqual(responsePayload, { ok: true });
+
+      user.reload();
+      assert.strictEqual(user.emailVerified, true);
+    });
+
+    test('returns an error for unknown tokens', async function (assert) {
+      let response = await fetch('/api/v1/confirm/unknown', { method: 'PUT' });
+      assert.equal(response.status, 400);
+
+      let responsePayload = await response.json();
+      assert.deepEqual(responsePayload, {
+        errors: [{ detail: 'Email belonging to token not found.' }],
+      });
+    });
+  });
 });