Skip to content

Commit 8cfa142

Browse files
committed
Extract a test helper function
1 parent dccc89f commit 8cfa142

File tree

1 file changed

+11
-15
lines changed

1 file changed

+11
-15
lines changed

src/bin/update-downloads.rs

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,14 @@ mod test {
252252
assert_eq!(Ok(false), processed);
253253
}
254254

255+
fn version_find_first(conn: &PgConnection, id: i32) -> Version {
256+
versions::table
257+
.find(id)
258+
.select(cargo_registry::models::version::ALL_COLUMNS)
259+
.first::<Version>(conn)
260+
.unwrap()
261+
}
262+
255263
#[test]
256264
fn increment_a_little() {
257265
use diesel::dsl::*;
@@ -286,21 +294,13 @@ mod test {
286294
.execute(&conn)
287295
.unwrap();
288296

289-
let version_before = versions::table
290-
.find(version.id)
291-
.select(cargo_registry::models::version::ALL_COLUMNS)
292-
.first::<Version>(&conn)
293-
.unwrap();
297+
let version_before = version_find_first(&conn, version.id);
294298
let krate_before = Crate::all()
295299
.filter(crates::id.eq(krate.id))
296300
.first::<Crate>(&conn)
297301
.unwrap();
298302
crate::update(&conn).unwrap();
299-
let version2 = versions::table
300-
.find(version.id)
301-
.select(cargo_registry::models::version::ALL_COLUMNS)
302-
.first::<Version>(&conn)
303-
.unwrap();
303+
let version2 = version_find_first(&conn, version.id);
304304
assert_eq!(version2.downloads, 2);
305305
assert_eq!(version2.updated_at, version_before.updated_at);
306306
let krate2 = Crate::all()
@@ -311,11 +311,7 @@ mod test {
311311
assert_eq!(krate2.updated_at, krate_before.updated_at);
312312
crate_downloads!(&conn, krate.id, 1);
313313
crate::update(&conn).unwrap();
314-
let version3 = versions::table
315-
.find(version.id)
316-
.select(cargo_registry::models::version::ALL_COLUMNS)
317-
.first::<Version>(&conn)
318-
.unwrap();
314+
let version3 = version_find_first(&conn, version.id);
319315
assert_eq!(version3.downloads, 2);
320316
}
321317

0 commit comments

Comments
 (0)