Skip to content

Commit 9bce0eb

Browse files
committed
mirage: Remove default scenario
Supporting mirage in development builds is difficult without `ember-cli-mirage` since without proper tree shaking we would be shipping the additional mirage dependency bytes to production as well. Since most development happens in `start:live` mode and with help of the test suite, the use of this default scenario is somewhat questionable anyway.
1 parent da6acf7 commit 9bce0eb

File tree

3 files changed

+6
-22
lines changed

3 files changed

+6
-22
lines changed

docs/CONTRIBUTING.md

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -134,18 +134,12 @@ To build and serve the frontend assets, use the command `pnpm start`. There
134134
are variations on this command that change which backend your frontend tries to
135135
talk to:
136136

137-
| Command | Backend | Use case |
138-
| ----------------------------------------- | --------------------------------------------- | ------------------------------------------------------- |
139-
| `pnpm start:live` | <https://crates.io> | Testing UI changes with the full live site's data |
140-
| `pnpm start:staging` | <https://staging-crates-io.herokuapp.com> | Testing UI changes with a smaller set of realistic data |
141-
| `pnpm start` | Static fixture test data in `mirage/fixtures` | Setting up particular situations, see note |
142-
| `pnpm start:local` | Backend server running locally | See the Working on the backend section for setup |
143-
| `pnpm start -- --proxy https://crates.io` | Whatever is specified in `--proxy` arg | If your use case is not covered here |
144-
145-
> Note: If you want to set up a particular situation, you can edit the fixture
146-
> data used for tests in `mirage/fixtures`. The fixture data does not currently
147-
> contain JSON needed to support every page, so some pages might not load
148-
> correctly.
137+
| Command | Backend | Use case |
138+
| ----------------------------------------- | ----------------------------------------- | ------------------------------------------------------- |
139+
| `pnpm start:live` | <https://crates.io> | Testing UI changes with the full live site's data |
140+
| `pnpm start:staging` | <https://staging-crates-io.herokuapp.com> | Testing UI changes with a smaller set of realistic data |
141+
| `pnpm start:local` | Backend server running locally | See the Working on the backend section for setup |
142+
| `pnpm start -- --proxy https://crates.io` | Whatever is specified in `--proxy` arg | If your use case is not covered here |
149143

150144
#### Running the frontend tests
151145

mirage/scenarios/default.js

Lines changed: 0 additions & 9 deletions
This file was deleted.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"precompress": "node ./script/precompress-assets.mjs",
2525
"prettier:check": "prettier --check package.json '**/*.js' '**/*.mjs' '**/*.ts' '**/*.md'",
2626
"prettier:write": "prettier --write package.json '**/*.js' '**/*.mjs' '**/*.ts' '**/*.md'",
27-
"start": "ember serve",
2827
"start:docker": "ember serve --proxy http://backend:8888",
2928
"start:live": "ember serve --proxy https://crates.io",
3029
"start:local": "ember serve --proxy http://127.0.0.1:8888",

0 commit comments

Comments
 (0)