Auto merge of #4072 - Turbo87:edition, r=JohnTitor

Rust 2021 Edition

This PR updates the Rust version that we use to v1.56.0 and sets the `edition` field to 2021.

see https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html

Author: bors

.github/workflows/ci.yml

@@ -77,9 +77,8 @@ jobs:
       - name: Install Rust
         run: |
           rustup set profile minimal
-          # Pin to older version until a clippy regression is fixed
-          rustup update 1.54.0
-          rustup default 1.54.0
+          rustup update 1.56.0
+          rustup default 1.56.0
 
       - run: rustup component add rustfmt
       - run: rustup component add clippy

Cargo.toml

@@ -5,8 +5,7 @@ version = "0.2.2"
 license = "MIT OR Apache-2.0"
 repository = "https://github.com/rust-lang/crates.io"
 description = "Backend of crates.io"
-edition = "2018"
-resolver = "2"
+edition = "2021"
 default-run = "server"
 
 [workspace]

RustConfig

@@ -1 +1 @@
-VERSION=1.54.0
+VERSION=1.56.0

src/controllers/krate/publish.rs

@@ -75,6 +75,7 @@ pub fn publish(req: &mut dyn RequestExt) -> EndpointResult {
     // Create a transaction on the database, if there are no errors,
     // commit the transactions to record a new or updated crate.
     conn.transaction(|| {
+        let _ = &new_crate;
         let name = new_crate.name;
         let vers = &*new_crate.vers;
         let links = new_crate.links;

src/tests/record.rs

@@ -326,6 +326,7 @@ fn replay_http(
     }
 
     async {
+        let _ = &exchange;
         assert_eq!(
             to_bytes(req.into_body()).await.unwrap(),
             base64::decode(&exchange.request.body).unwrap()

src/util/errors/json.rs

@@ -136,8 +136,6 @@ impl fmt::Display for ServiceUnavailable {
 
 impl AppError for TooManyRequests {
     fn response(&self) -> Option<AppResponse> {
-        use std::convert::TryInto;
-
         const HTTP_DATE_FORMAT: &str = "%a, %d %b %Y %H:%M:%S GMT";
         let retry_after = self.retry_after.format(HTTP_DATE_FORMAT);