Have the test fn req_with_documentation always take documentation

Otherwise, it isn't really with documentation :) We can use new_req to
create a version without a documentation link.

Author: carols10cents

src/tests/all.rs

@@ -552,10 +552,10 @@ fn new_req_with_documentation(
     app: Arc<App>,
     krate: &str,
     version: &str,
-    documentation: Option<String>,
+    documentation: &str,
 ) -> MockRequest {
     let mut krate = ::krate(krate);
-    krate.documentation = documentation;
+    krate.documentation = Some(documentation.into());
     new_req_full(app, krate, version, Vec::new())
 }
 

src/tests/krate.rs

@@ -1603,7 +1603,7 @@ fn publish_after_removing_documentation() {
             Arc::clone(&app),
             "docscrate",
             "0.2.1",
-            Some("http://foo.rs".to_owned()),
+            "http://foo.rs",
         );
         ::sign_in_as(&mut req, &user);
         let mut response = ok_resp!(middle.call(&mut req));
@@ -1621,7 +1621,7 @@ fn publish_after_removing_documentation() {
 
     // 3. Remove the documentation
     {
-        let mut req = ::new_req_with_documentation(Arc::clone(&app), "docscrate", "0.2.2", None);
+        let mut req = ::new_req(Arc::clone(&app), "docscrate", "0.2.2");
         ::sign_in_as(&mut req, &user);
         let mut response = ok_resp!(middle.call(&mut req));
         let json: GoodCrate = ::json(&mut response);